Skip to content

Merge release-1.1 into master. (Final batch)#774

Merged
hklai merged 4 commits intoistio:masterfrom
hklai:1.1-master
Jan 27, 2019
Merged

Merge release-1.1 into master. (Final batch)#774
hklai merged 4 commits intoistio:masterfrom
hklai:1.1-master

Conversation

@hklai
Copy link
Contributor

@hklai hklai commented Jan 27, 2019

Details:
https://discuss.istio.io/t/announcement-locking-down-1-1-release-unlocking-master/378

For all subsequent PRs merging to release-1.1, please cherry-pick them to master if needed.

kyessenov and others added 4 commits January 22, 2019 12:08
Signed-off-by: Kuat Yessenov <kuat@google.com>
* Add sds_name into gateway config

* Update comment

* Update comment
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jan 27, 2019
@hklai hklai added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jan 27, 2019
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@hklai hklai merged commit 825044c into istio:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. review/done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants