Merge 1.1 to master by louiscryan · Pull Request #806 · istio/api

louiscryan · 2019-02-21T00:29:20Z

No description provided.

* Replace public/private scoping with namespace scoped exports Add flags to control scopeTo defaults Update doc for locality weighted LB * Hide from docs and other misc fixes

* Enabling SDS in the gateway Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * lint Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

This reverts commit 3c7e31a.

…tio#770) * Add mechanism to signal encoding used for CompressedAttributes to mixer proto * Update proto.lock

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Enabling SDS in the gateway Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * lint Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * nits Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * cleanups Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * update Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * updates Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * protolock Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Add service_accounts field in ServiceEntry * Ran make proto-commit * Added example with format * Rename to subject_alt_names * Move example out of the message definition * Added a period * Remove hide_from_docs

* Update comment for credentialName * Update comment

* Rename "principals" to "names". Since this is defined under "subjects", we are basically referring to the "name" of a subject. * Update comments.

* add server_name to mixer remote handler tls / mtls * proto.lock

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

googlebot · 2019-02-21T00:29:37Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

googlebot · 2019-02-21T00:29:54Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Googlers can find more info about SignCLA and this PR by following this link.

rshriram · 2019-02-21T00:57:54Z

/lgtm

istio-testing · 2019-02-21T00:57:55Z

@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rshriram · 2019-02-21T00:58:34Z

/approve
/lgtm

istio-testing · 2019-02-21T00:58:35Z

@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Details

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing · 2019-02-21T00:58:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: louiscryan, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Louis Ryan and others added 16 commits January 28, 2019 15:31

Replace 'scope' with 'export_to' namespace (istio#758)

b524b1e

* Replace public/private scoping with namespace scoped exports Add flags to control scopeTo defaults Update doc for locality weighted LB * Hide from docs and other misc fixes

Enabling SDS in the gateway (istio#778)

3c7e31a

* Enabling SDS in the gateway Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * lint Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

Revert "Enabling SDS in the gateway (istio#778)" (istio#779)

5c6aec2

This reverts commit 3c7e31a.

Add way to signal encoding used for CompressedAttributes to Mixer (is…

1b0a034

…tio#770) * Add mechanism to signal encoding used for CompressedAttributes to mixer proto * Update proto.lock

revert sds name (istio#781)

d5da499

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

Add subject_alt_names field in ServiceEntry (istio#785)

3094619

* Add service_accounts field in ServiceEntry * Ran make proto-commit * Added example with format * Rename to subject_alt_names * Move example out of the message definition * Added a period * Remove hide_from_docs

Update comment for credentialName (istio#786)

1a129f0

* Update comment for credentialName * Update comment

Doc fixes (istio#788)

9883956

Add transport error retry config to mixer client. (istio#792)

07829e0

Rename "principals" to "names". (istio#791)

27010bf

* Rename "principals" to "names". Since this is defined under "subjects", we are basically referring to the "name" of a subject. * Update comments.

Doc fix to have the mesh config show up on istio.io. (istio#794)

92b7ddc

Fix typos in sidecar.proto (1.1) (istio#796)

d817a1a

add server_name to mixer remote handler tls / mtls (istio#789)

5945a02

* add server_name to mixer remote handler tls / mtls * proto.lock

doc fixes (istio#801)

1b39429

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

Merge branch 'release-1.1' into Merge11ToMaster

823a224

louiscryan requested a review from rshriram February 21, 2019 00:29

istio-testing requested a review from frankbu February 21, 2019 00:29

googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Feb 21, 2019

rshriram approved these changes Feb 21, 2019

View reviewed changes

istio-testing added the approved label Feb 21, 2019

louiscryan merged commit 53b11a3 into istio:master Feb 21, 2019

louiscryan deleted the Merge11ToMaster branch February 21, 2019 00:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge 1.1 to master#806

Merge 1.1 to master#806
louiscryan merged 16 commits intoistio:masterfrom
louiscryan:Merge11ToMaster

louiscryan commented Feb 21, 2019

Uh oh!

googlebot commented Feb 21, 2019

Uh oh!

googlebot commented Feb 21, 2019

Uh oh!

rshriram commented Feb 21, 2019

Uh oh!

istio-testing commented Feb 21, 2019

Uh oh!

rshriram commented Feb 21, 2019

Uh oh!

istio-testing commented Feb 21, 2019

Uh oh!

istio-testing commented Feb 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

louiscryan commented Feb 21, 2019

Uh oh!

googlebot commented Feb 21, 2019

Uh oh!

googlebot commented Feb 21, 2019

Uh oh!

rshriram commented Feb 21, 2019

Uh oh!

istio-testing commented Feb 21, 2019

Uh oh!

rshriram commented Feb 21, 2019

Uh oh!

istio-testing commented Feb 21, 2019

Uh oh!

istio-testing commented Feb 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants