Skip to content

[Cherry-pick]Adding weights to service entry endpoints (#704)#706

Merged
istio-testing merged 2 commits intoistio:masterfrom
rshriram:cp_704
Nov 14, 2018
Merged

[Cherry-pick]Adding weights to service entry endpoints (#704)#706
istio-testing merged 2 commits intoistio:masterfrom
rshriram:cp_704

Conversation

@rshriram
Copy link
Member

From #704

Signed-off-by: Shriram Rajagopalan shriramr@vmware.com

* add dynamic state to attribute list

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Adding weights to service entry endpoints

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* undo
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 14, 2018
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Copy link
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 93b99d4 into istio:master Nov 14, 2018
louiscryan pushed a commit to louiscryan/api that referenced this pull request Jan 16, 2019
…stio#706)

* Adding weights to service entry endpoints (istio#704)

* add dynamic state to attribute list

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Adding weights to service entry endpoints

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* undo

* update protolock

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants