policy: direct response -- add response headers#769
Merged
istio-testing merged 1 commit intoistio:release-1.1from Jan 22, 2019
Merged
policy: direct response -- add response headers#769istio-testing merged 1 commit intoistio:release-1.1from
istio-testing merged 1 commit intoistio:release-1.1from
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
googlebot
added
the
cla: yes
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyessenov, mandarjog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the previous PR.
We should treat error case separately from the normal case. The error case can supply headers directly as part of error details, while the normal case should rely on the rule action results. This avoids the problem of multiple rules contributing headers in the error case.
/assign @mandarjog
Signed-off-by: Kuat Yessenov kuat@google.com