Skip to content

Fix typo, 'target' is not known #725

Merged
frankbu merged 1 commit intoistio:masterfrom
pilhuhn:policy_typo
Dec 5, 2018
Merged

Fix typo, 'target' is not known #725
frankbu merged 1 commit intoistio:masterfrom
pilhuhn:policy_typo

Conversation

@pilhuhn
Copy link
Copy Markdown
Contributor

@pilhuhn pilhuhn commented Dec 5, 2018

target -> targets

Supersedes bad pr istio/istio.io#2946

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 5, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @pilhuhn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Please also update the dependent files by running scripts/generate-protos.sh as described here.

@pilhuhn
Copy link
Copy Markdown
Contributor Author

pilhuhn commented Dec 5, 2018

Thank you @frankbu for guiding me. The make proto-commit had no (visible) effect. I guess because the definitions stayed the same and only the comment changed (?)

@frankbu
Copy link
Copy Markdown
Contributor

frankbu commented Dec 5, 2018

@pilhuhn That's right, you only need to run make proto-comit if you change the actual message structure.

Copy link
Copy Markdown
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Dec 5, 2018

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu, ozevren, pilhuhn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frankbu frankbu merged commit b917615 into istio:master Dec 5, 2018
@pilhuhn pilhuhn deleted the policy_typo branch December 5, 2018 15:41
@hklai
Copy link
Copy Markdown
Contributor

hklai commented Dec 11, 2018

@pilhuhn/@frankbu master is actually locked. Please merge to release-1.1 before master is unlocked.

Also, perhaps it is worthwhile to cherry-pick this to release-1.1 as well?

louiscryan pushed a commit to louiscryan/api that referenced this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants