Skip to content

Add ISY994 variables as number entities#85457

Closed
shbatm wants to merge 35 commits into
home-assistant:devfrom
shbatm:isy994_variables
Closed

Add ISY994 variables as number entities#85457
shbatm wants to merge 35 commits into
home-assistant:devfrom
shbatm:isy994_variables

Conversation

@shbatm
Copy link
Copy Markdown
Contributor

@shbatm shbatm commented Jan 8, 2023

DRAFT

Ready for review, but pending merge of #85429 to update some string literal constants

Breaking change

ISY/IoX Variables have been changed from sensor entities to number entities. The isy994.set_variable service has been deprecated in favor of using the number entities to directly set the variable values. Please update any dashboards and automations that may be using these entites or service.

Proposed change

Add the number platform to ISY994 and move ISY/IoX Variables from sensor with a custom service to the new platform.

There is an existing Config Option for choosing which Variables are added to Home Assistant. This is now used to determine which entities are enabled by default, but all Variables can now be imported.

For each Variable in the ISY/IoX, 2 entities are created; one for the current value and one for the initial value. The initial value entities are always disabled by default.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 8, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (isy994) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of isy994 can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign isy994 Removes the current integration label and assignees on the issue, add the integration domain after the command.

shbatm and others added 18 commits January 9, 2023 01:39
…5368)

* Limit timestamp changes to +/- 60 seconds

* Add timestamp callback tests
Co-authored-by: J. Nick Koston <nick@koston.org>
dbuezas and others added 16 commits January 9, 2023 10:54
…assistant#83733)

Co-authored-by: J. Nick Koston <nick@koston.org>
fixes undefined
* Google Assistant SDK: support Korean and Japanese

* Fix Korean and Japanese broadcast commands
…ome-assistant#85452)

* Cover: Fixed calibration errors and add missing is_closed

* Style

* Style

* whitespace
…thub (home-assistant#85476)

* Add code owners to receive notifications on github

* fixup! Add code owners to receive notifications on github
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add config flow to imap

fix coverage

fix config_flows.py

* move coordinator to seperate file, remove name key

* update intrgations.json

* update requirements_all.txt

* fix importing issue_registry

* Address comments

* Improve handling exceptions on intial connection

* exit loop tasks properly

* fix timeout

* revert async_timeout

* Improve entity update handling

* ensure we wait for idle to finish

* fix typing

* Update deprecation period

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@shbatm shbatm closed this Jan 9, 2023
@shbatm shbatm deleted the isy994_variables branch January 9, 2023 10:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.