Skip to content

Add ISY994 variables as number entities#25650

Merged
bdraco merged 4 commits into
home-assistant:nextfrom
shbatm:isy994-variables
Jan 10, 2023
Merged

Add ISY994 variables as number entities#25650
bdraco merged 4 commits into
home-assistant:nextfrom
shbatm:isy994-variables

Conversation

@shbatm
Copy link
Copy Markdown
Contributor

@shbatm shbatm commented Jan 8, 2023

Proposed change

Add the number platform to ISY994 and move ISY/IoX Variables from sensor with a custom service to the new platform.

There is an existing Config Option for choosing which Variables are added to Home Assistant. This is now used to determine which entities are enabled by default, but all Variables can now be imported.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jan 8, 2023
@shbatm shbatm marked this pull request as ready for review January 9, 2023 11:04
@shbatm shbatm requested a review from bdraco as a code owner January 9, 2023 11:04
@shbatm
Copy link
Copy Markdown
Contributor Author

shbatm commented Jan 9, 2023

Note: expecting a merge conflict when #25609 is merged. Will update after.

Comment thread source/_integrations/isy994.markdown Outdated
frenck
frenck previously approved these changes Jan 9, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 9, 2023
@shbatm
Copy link
Copy Markdown
Contributor Author

shbatm commented Jan 10, 2023

Merge conflict fixed.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jan 10, 2023

Thanks @shbatm

@bdraco bdraco merged commit 45399f2 into home-assistant:next Jan 10, 2023
@home-assistant home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Jan 10, 2023
@shbatm shbatm deleted the isy994-variables branch January 11, 2023 02:32
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants