Skip to content

Fix fetching of initial data of Netgear sensors#85450

Merged
thecode merged 1 commit into
home-assistant:devfrom
starkillerOG:Netgear_fix5
Jan 8, 2023
Merged

Fix fetching of initial data of Netgear sensors#85450
thecode merged 1 commit into
home-assistant:devfrom
starkillerOG:Netgear_fix5

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Jan 8, 2023

Breaking change

Proposed change

@MartinHjelmare pointed out I was using the wrong commond to do the initial fetch of data through the coordinator when no previous data is available:
Use self.coordinator.async_request_refresh() instead of self.schedule_update_ha_state()

This was discussed in PR: #85299

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 8, 2023

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netgear can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign netgear Removes the current integration label and assignees on the issue, add the integration domain after the command.

@thecode thecode merged commit b0270f1 into home-assistant:dev Jan 8, 2023
Comment thread homeassistant/components/netgear/sensor.py
tronikos pushed a commit to tronikos/home-assistant-core that referenced this pull request Jan 9, 2023
shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Jan 9, 2023
@starkillerOG starkillerOG mentioned this pull request Jan 9, 2023
19 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants