Skip to content

Code styling tweaks to Bluetooth#85448

Merged
bdraco merged 5 commits into
devfrom
frenck-2023-0063
Jan 8, 2023
Merged

Code styling tweaks to Bluetooth#85448
bdraco merged 5 commits into
devfrom
frenck-2023-0063

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jan 8, 2023

Proposed change

Small code-styling tweaks for the Bluetooth components.

All of them have been triggered by line length, I still had to ignore a couple of cases, simple because some methods have been extremely long, making it impossible to adhere to coding standards.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 8, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (bluetooth) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bluetooth can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign bluetooth Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM is the ci likes it

Comment thread homeassistant/components/bluetooth/base_scanner.py Outdated
Comment thread homeassistant/components/bluetooth/manager.py Outdated
Comment thread homeassistant/components/bluetooth/base_scanner.py Outdated
Comment thread homeassistant/components/bluetooth/base_scanner.py Outdated
Comment thread homeassistant/components/bluetooth/manager.py Outdated
Comment thread homeassistant/components/bluetooth/manager.py Outdated
Co-authored-by: J. Nick Koston <nick@koston.org>
Comment thread homeassistant/components/bluetooth/manager.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jan 8, 2023

I think we should get this merged and than I'll fix the conflicts in #83733

Comment thread homeassistant/components/bluetooth/base_scanner.py Outdated
Comment thread homeassistant/components/bluetooth/base_scanner.py Outdated
Comment thread homeassistant/components/bluetooth/wrappers.py
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry for the long names. I was trying to follow bleak's naming too closely and I think it would have been a better design to break from that pattern.

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Jan 8, 2023

Sorry for the long names.

No need to apologize for that. And the upside, they are very clear 🤷
I have no strong opinion on one or the other.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jan 8, 2023

Thanks @frenck

@bdraco bdraco merged commit 487782a into dev Jan 8, 2023
@bdraco bdraco deleted the frenck-2023-0063 branch January 8, 2023 21:20
tronikos pushed a commit to tronikos/home-assistant-core that referenced this pull request Jan 9, 2023
Co-authored-by: J. Nick Koston <nick@koston.org>
shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Jan 9, 2023
Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants