Skip to content

Z-Wave.Me: Cover: Fixed calibration errors and add missing is_closed#85452

Merged
balloob merged 4 commits into
home-assistant:devfrom
Z-Wave-Me:ZME-cover-fix
Jan 9, 2023
Merged

Z-Wave.Me: Cover: Fixed calibration errors and add missing is_closed#85452
balloob merged 4 commits into
home-assistant:devfrom
Z-Wave-Me:ZME-cover-fix

Conversation

@PoltoS
Copy link
Copy Markdown
Contributor

@PoltoS PoltoS commented Jan 8, 2023

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 8, 2023

Hey there @lawfulchaos, @Z-Wave-Me, mind taking a look at this pull request as it has been labeled with an integration (zwave_me) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_me can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign zwave_me Removes the current integration label and assignees on the issue, add the integration domain after the command.

@PoltoS
Copy link
Copy Markdown
Contributor Author

PoltoS commented Jan 8, 2023

Fixes #77279 and #73755

@balloob balloob merged commit 1f86a0a into home-assistant:dev Jan 9, 2023
tronikos pushed a commit to tronikos/home-assistant-core that referenced this pull request Jan 9, 2023
…ome-assistant#85452)

* Cover: Fixed calibration errors and add missing is_closed

* Style

* Style

* whitespace
shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Jan 9, 2023
…ome-assistant#85452)

* Cover: Fixed calibration errors and add missing is_closed

* Style

* Style

* whitespace
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error adding entities for domain cover with platform zwave_me

2 participants