Add network resource button entities to ISY994 and bump PyISY to 3.0.12#85429
Merged
Conversation
Contributor
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
19 tasks
bdraco
reviewed
Jan 8, 2023
bdraco
reviewed
Jan 8, 2023
bdraco
reviewed
Jan 8, 2023
bdraco
reviewed
Jan 8, 2023
Member
|
Looks good. Minor comments above. Testing now |
Member
Member
|
Nevermind it works great. Its under |
bdraco
reviewed
Jan 9, 2023
bdraco
approved these changes
Jan 9, 2023
Member
|
Thanks @shbatm |
tronikos
pushed a commit
to tronikos/home-assistant-core
that referenced
this pull request
Jan 9, 2023
…12 (home-assistant#85429) Co-authored-by: J. Nick Koston <nick@koston.org>
shbatm
added a commit
to shbatm/home-assistant-core
that referenced
this pull request
Jan 9, 2023
…12 (home-assistant#85429) Co-authored-by: J. Nick Koston <nick@koston.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
The
isy994.run_network_resourcehas been deprecated and will be removed in a future release. Network Resources have been added as button entities and those should be used instead.Proposed change
Add full support for the ISY/IoX's Network Resources by creating button entities to trigger each resource. Previously these were only possible to control from Home Assistant using the integration-specific service
isy994.run_network_resource. These are being added as buttons because they are one-shot executions with no return values (they operate similar to therest_commandintegration).Resources will be added to a single "ISY Networking Module" device entry as this is a separate and optional module in the ISY.
Also included in this PR:
isy.configurationdict keys to string literals where used.Note when testing: there appears to be a bug in the most recent version of IoX firmware where network resources will report an error when called, but will be called successfully. This shows up as a warning in the log only, and no changes will be required here once UDI fixes the issue on their end.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: