Skip to content

Google Assistant SDK: support Korean and Japanese#85419

Merged
balloob merged 2 commits into
home-assistant:devfrom
tronikos:google_assistant_sdk_lang
Jan 9, 2023
Merged

Google Assistant SDK: support Korean and Japanese#85419
balloob merged 2 commits into
home-assistant:devfrom
tronikos:google_assistant_sdk_lang

Conversation

@tronikos
Copy link
Copy Markdown
Member

@tronikos tronikos commented Jan 8, 2023

Proposed change

Support Korean and Japanese languages.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob merged commit 05187d7 into home-assistant:dev Jan 9, 2023
tronikos added a commit to tronikos/home-assistant-core that referenced this pull request Jan 9, 2023
* Google Assistant SDK: support Korean and Japanese

* Fix Korean and Japanese broadcast commands
shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Jan 9, 2023
* Google Assistant SDK: support Korean and Japanese

* Fix Korean and Japanese broadcast commands
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing language support(ja-JP and ko-KR) @ Google Assistant SDK integration

2 participants