Skip to content

Remove invalid Signal Strength device class from NETGEAR#85510

Merged
frenck merged 1 commit into
devfrom
frenck-2023-0071
Jan 9, 2023
Merged

Remove invalid Signal Strength device class from NETGEAR#85510
frenck merged 1 commit into
devfrom
frenck-2023-0071

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jan 9, 2023

Proposed change

The NETGEAR signal strength sensor provides a signal strength in %, which is not a supported unit of measurement for the signal_strength device class.

This PR removes this occurrence as reported in #85361

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 9, 2023

Hey there @hacf-fr, @Quentame, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netgear can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign netgear Removes the current integration label and assignees on the issue, add the integration domain after the command.

@frenck frenck added this to the 2023.1.3 milestone Jan 9, 2023
@frenck frenck merged commit c225ed0 into dev Jan 9, 2023
@frenck frenck deleted the frenck-2023-0071 branch January 9, 2023 10:39
shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Jan 9, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

4 participants