Upgrade zeroconf to 0.27.1

[bdraco]

Add zeroconf as an explicit dependency to integrations that load it or load it in their deps. This ensures that zeroconf is updated without needing to restart twice.

Should also help https://community.home-assistant.io/t/python3-high-cpu-usage/160012/24

Changes

Fix for chromecast audio python-zeroconf/python-zeroconf#245

Other commits are minor sans the removal of the legacy address compat
python-zeroconf/python-zeroconf@ab72aa8
python-zeroconf/python-zeroconf@87a0fe2
python-zeroconf/python-zeroconf@488ee1e
python-zeroconf/python-zeroconf@178cec7
python-zeroconf/python-zeroconf@d881aba
python-zeroconf/python-zeroconf@beff998
python-zeroconf/python-zeroconf@10065b9

Remaining

• Remove zeroconf from homekit Remove zeroconf options from homekit #35687
• Fix zeroconf tests
• HAP-python release (may not be needed with Remove zeroconf options from homekit #35687)
• pychromecast PR here: Support zeroconf 0.27 home-assistant-libs/pychromecast#368, once merged+released cast needs to
• bump the pychromecast version Bump pychromecast to 6.0.0 #36414
• Determine cause and fix After upgrading to 0.27.0 log is flooded with packets() made no progress adding records; returning python-zeroconf/python-zeroconf#272
• New release of zeroconf 0.27.1 needed to complete issue Fixed false logging warning python-zeroconf/python-zeroconf#273

Breaking change

There is a backwards incompatible change in 0.27
python-zeroconf/python-zeroconf@ab72aa8

The address argument has been removed, and the addresses must be used instead. Its been marked as deprecated for a while but we didn't noticed until it broke 🙉

Example of the change needed
ikalchev/HAP-python#263

Discussion:
ikalchev/HAP-python#262

cc @emontnemery in case this causes problems for cast

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[emontnemery]

@bdraco Thanks for the heads up!
This indeed affects cast too.
pychromecast PR here: home-assistant-libs/pychromecast#368, once merged+released cast needs to bump the pychromecast version.

[bdraco]

Verified the spurious warning is fixed in 0.27.1

[bdraco]

So dyson, soundtouch, aiohomekit, miio, pyvizio, all load zeroconf as well

so this needs to go in setup.py instead I think but that seems like we should not do in beta.

[balloob]

Are these all integrations that use zeroconf discovery? Should we update the validation.

We explicitly allow referencing zeroconf without having it in after_deps: https://github.com/home-assistant/core/blob/dev/script/hassfest/dependencies.py#L163-L166

[balloob]

Actually, that hassfest check is accompanied with automatic dependency management:

When we install requirements, we actually automatically mark zeroconf as a dependency for integrations that are discoverable via zeroconf to make sure we have the latest requirements: https://github.com/home-assistant/core/blob/dev/homeassistant/requirements.py#L87-L93

[bdraco]

Are these all integrations that use zeroconf discovery? Should we update the validation.

Its all the integrations that import zeroconf that could load it before its updated. Many of them don't actually use zeroconf directly because of how they are integrated, but it doesn't stop them from importing.

[balloob]

So hassfest should check for this.

The logic in hassfest is:

• gather all dependencies that we import from
• mark dependencies as allowed if discovery specified in manifest

The setup logic is:

1. gather all requirements of integration
2. gather all dependencies. If discovery specified in manifest, gather those integrations too.
   • For each dep: do step 1 (recursively)

So that means that all integrations that are updated in this PR that already have zeroconf in their manifest should have already had zeroconf requirements be processed.

[bdraco]

I'm a bit confused here. For clarity, all of these integration are loading the python zeroconf pypi package via a dependency, not directly.

[balloob]

Oh snap, I misunderstood. Okay my bad.

[balloob]

I thought that the problem was that the latest zeroconf wasn't installed. That should not happen as long as they depend on zeroconf integration via deps, after_deps or use zeroconf discovery.

[balloob]

Ok, so here is why this fixes things:

The ssdp integration does not rely on zeroconf discovery. It only imports PyPI package netdisco, which imports PyPI package python-zeroconf. This would be the old version.

Now we install python-zeroconf as part of setting up the zeroconf integration, but Python will already have loaded the old python-zeroconf because it was already imported. It would require a restart to resolve imports to the new python-zeroconf.

[balloob]

Restarting 3.7 test. Test failed without clear reason.