Skip to content

Import dhcp in the executor to avoid blocking the event loop#111589

Merged
balloob merged 1 commit into
devfrom
dhcp_executor
Feb 27, 2024
Merged

Import dhcp in the executor to avoid blocking the event loop#111589
balloob merged 1 commit into
devfrom
dhcp_executor

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 27, 2024

Proposed change

Discovery integrations load a lot earlier when many modules are not yet loaded so they have a lot less overlapping deps

dhcp uses scapy which is large to import. I hope one day to replace it with something more lightweight

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Discovery integrations load a lot earlier when many modules
are not yet loaded so they have a lot less overlapping deps

dhcp uses scapy which is large to import. I hope one
day to replace it with something more lightweight
@balloob balloob merged commit d6d2ded into dev Feb 27, 2024
@balloob balloob deleted the dhcp_executor branch February 27, 2024 04:20
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants