Skip to content

Remove zeroconf from ssdp after deps#111326

Merged
balloob merged 3 commits into
devfrom
remove_zeroconf_ssdp_after
Feb 27, 2024
Merged

Remove zeroconf from ssdp after deps#111326
balloob merged 3 commits into
devfrom
remove_zeroconf_ssdp_after

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 25, 2024

Proposed change

This was added in #36277 but is no longer needed since we setup discovery integrations ahead of time to ensure their deps are updated before other integrations can load them

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This was added in #36277 but is no longer needed since
we setup discovery integrations ahead of time to ensure
their deps are updated before other integrations can load
them
@bdraco bdraco marked this pull request as ready for review February 25, 2024 09:59
@balloob balloob merged commit 587854f into dev Feb 27, 2024
@balloob balloob deleted the remove_zeroconf_ssdp_after branch February 27, 2024 04:57
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants