Skip to content

Use eager start for august subscriber refreshes#111581

Merged
balloob merged 1 commit into
devfrom
august_refresh
Feb 27, 2024
Merged

Use eager start for august subscriber refreshes#111581
balloob merged 1 commit into
devfrom
august_refresh

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 27, 2024

Proposed change

Since most of the time this call will be a noop since pubnub will be connected we can avoid scheduling a task on the event loop every time it fires

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Since most of the time this call will be a noop since pubnub will be connected
we can avoid scheduling a task on the event loop every time it fires
"""Refresh data."""

@callback
def _async_scheduled_refresh(self, now: datetime) -> None:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an eager keyword for our listeners, or maybe a decorator for the functions we pass in ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking decorate coros like we do with @callback but I think after the initial flood of these we won't have that many. If I turn out to be wrong on that, I think I'll switch gears and add the decorator, but I don't want to put more checks in the HassJob path if it's not going to be more generally used

@balloob balloob merged commit 1e02260 into dev Feb 27, 2024
@balloob balloob deleted the august_refresh branch February 27, 2024 04:13
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants