Use eager start for august subscriber refreshes#111581
Merged
Merged
Conversation
Since most of the time this call will be a noop since pubnub will be connected we can avoid scheduling a task on the event loop every time it fires
balloob
reviewed
Feb 27, 2024
| """Refresh data.""" | ||
|
|
||
| @callback | ||
| def _async_scheduled_refresh(self, now: datetime) -> None: |
Member
There was a problem hiding this comment.
Should there be an eager keyword for our listeners, or maybe a decorator for the functions we pass in ?
Member
Author
There was a problem hiding this comment.
I was thinking decorate coros like we do with @callback but I think after the initial flood of these we won't have that many. If I turn out to be wrong on that, I think I'll switch gears and add the decorator, but I don't want to put more checks in the HassJob path if it's not going to be more generally used
balloob
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Since most of the time this call will be a noop since pubnub will be connected we can avoid scheduling a task on the event loop every time it fires
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: