Skip to content

Create bootstrap tasks eagerly#111497

Merged
balloob merged 1 commit into
devfrom
eager_start_bootstrap
Feb 27, 2024
Merged

Create bootstrap tasks eagerly#111497
balloob merged 1 commit into
devfrom
eager_start_bootstrap

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 26, 2024

Proposed change

Create bootstrap tasks eagerly

We can avoid one event loop iteration to start the tasks here.

This does not create the setup component tasks eagerly. This will be a separate PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We can avoid one event loop iteration to start the tasks here
@bdraco bdraco marked this pull request as ready for review February 26, 2024 19:45
@bdraco bdraco requested a review from a team as a code owner February 26, 2024 19:45
@balloob balloob merged commit de48ad5 into dev Feb 27, 2024
@balloob balloob deleted the eager_start_bootstrap branch February 27, 2024 04:56
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants