Skip to content

Fully fix race in removing entities#111499

Merged
balloob merged 3 commits into
devfrom
fully_fix_race
Feb 27, 2024
Merged

Fully fix race in removing entities#111499
balloob merged 3 commits into
devfrom
fully_fix_race

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 26, 2024

Proposed change

Followup to #110978 now that we can start the task eagerly it completely closes the race window

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Followup to #110978 now that we can start the task
eagerly it completely closes the race window
@bdraco bdraco requested a review from a team as a code owner February 26, 2024 17:54
@home-assistant home-assistant Bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Feb 26, 2024
@bdraco bdraco changed the title Full fix race in removing entities Fully fix race in removing entities Feb 26, 2024
@bdraco bdraco marked this pull request as draft February 26, 2024 19:45
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Feb 26, 2024

I think that failing test is actually wrong as it’s relying on the race and not actually testing what it intends to test

bdraco added a commit that referenced this pull request Feb 26, 2024
Once the race in #111499 is fixed, this will fail
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Feb 26, 2024

The test failure is highlighting an actual bug in the integration

@bdraco bdraco marked this pull request as ready for review February 26, 2024 20:47
@balloob balloob merged commit ce0fb1e into dev Feb 27, 2024
@balloob balloob deleted the fully_fix_race branch February 27, 2024 04:55
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants