Skip to content

Refactor eafm to avoid creating entities in the coordinator update#111601

Merged
bdraco merged 4 commits into
devfrom
eafm_refactor
Feb 27, 2024
Merged

Refactor eafm to avoid creating entities in the coordinator update#111601
bdraco merged 4 commits into
devfrom
eafm_refactor

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 27, 2024

Proposed change

Refactor eafm to avoid creating entities in the coordinator update. Creating the entities inside the coordinator relies on the add entities call happening after the coordinator finishes and sets data. We should not create entities inside the coordinator update path as there is no guarantee that the coordinator data is set before its returned

Screenshot 2024-02-26 at 8 21 23 PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Jc2k, mind taking a look at this pull request as it has been labeled with an integration (eafm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of eafm can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign eafm Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco marked this pull request as ready for review February 27, 2024 06:22
@bdraco bdraco requested a review from Jc2k as a code owner February 27, 2024 06:22
@Jc2k
Copy link
Copy Markdown
Member

Jc2k commented Feb 27, 2024

Cheers!

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Feb 27, 2024

thanks

@bdraco bdraco merged commit d812507 into dev Feb 27, 2024
@bdraco bdraco deleted the eafm_refactor branch February 27, 2024 07:08
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants