[4.3] Cherry-picks for the 4.3 branch (future 4.3.1) - 1st batch #97082

…e do our own sRGB conversion (cherry picked from commit dfcff4e)

(cherry picked from commit 4727c4f)

(cherry picked from commit b1421a0)

Co-authored-by: majikayogames <[email protected]> (cherry picked from commit 4457b11)

…anual light probes (cherry picked from commit 97205ea)

(cherry picked from commit 1c31e30)

…baking The sky rotation now affects the baked environment lighting as it should, making it match how real-time ambient light rendering works. Co-authored-by: Per Melin <[email protected]> (cherry picked from commit 661cf1f)

Fail if submit or sync called multiple times in a row (cherry picked from commit b0e33aa)

…he Compatibility renderer (cherry picked from commit 1bf594f)

(cherry picked from commit e6c45fb)

(cherry picked from commit 1fc8255)

When getting the minimum size for a tooltip, we get the value as a Vector2. Window::set_size() takes a Vector2i, so this size was getting truncated. At certain display scales, this could be enough to cut off part of the tooltip. Updated to call Vector2::ceil() to round up before calling Window::set_size() Fixes godotengine#91958 (cherry picked from commit ca8e3d4)

…rides and added the GlobalClass attribute (cherry picked from commit 74389e8)

(cherry picked from commit e7f215c)

(cherry picked from commit f15ad72)

…ne level module init. (cherry picked from commit 69d52ed)

… of wrapped string. Allow starting/ending RTL selection before line start. (cherry picked from commit 932acce)

(cherry picked from commit d74749f)

(cherry picked from commit 140f9dc)

(cherry picked from commit f483c3a)

(cherry picked from commit bcd776e)

(cherry picked from commit 2d4e573)

(cherry picked from commit 84c5403)

(cherry picked from commit 970a237)

(cherry picked from commit 8c626f2)

Adds NavigationLink function to change navigation map. (cherry picked from commit e6ff4e5)

(cherry picked from commit 3260437)

(cherry picked from commit d357a7d)

(cherry picked from commit b9876b6)

…nds instead of milliseconds (cherry picked from commit cde873b)

(cherry picked from commit 6895f6f)

(cherry picked from commit 3dfac16)

(cherry picked from commit bde8c59)

(cherry picked from commit 4cc065c)

…call count (cherry picked from commit 3388a4a)

(cherry picked from commit 13b2082)

`GDExtension::open_library` has a check in it to see if the library was loaded from a temp file, and if it was to restore the original name as that is the one we actually care about. This check is breaking extension reloading on Mac when the library path is to a framework folder, as the file inside the framework will not generally be the same name as the folder. This check also shouldn't be necessary even on Windows, which is the only platform that uses `generate_temp_files`, since disposal of the created temp file is handled within `OS_Windows::open_dynamic_library`, and `GDExtension::open_library` (which is the only function to call `open_dynamic_library` with a `p_data` argument) only cares about the original library file path and has to do extra work to remove the name of the temp file. Instead, I have removed that check and set `OS_Windows::open_dynamic_library` to return the name of the original file and not the name of the copy. This fixes GDExtension reloading on macOS. I do not have a Windows machine available to test that it still works properly on Windows, so someone should check that before merging this. (cherry picked from commit f44d6a2)

(cherry picked from commit 8aa444d)

(cherry picked from commit 78dc310)

(cherry picked from commit 138bcc7)

(cherry picked from commit 37be585)

(cherry picked from commit e7e6337)

(cherry picked from commit 8c7dd3c)

(cherry picked from commit b1a45d9)

(cherry picked from commit 2206f5c)

And apply luminance multiplier after fog in RD renderer (cherry picked from commit 578049b)

(cherry picked from commit b1c9731)

(cherry picked from commit 70f41e4)

(cherry picked from commit e46280d)

…ileSystemDock is in split mode (cherry picked from commit b55e97c)

(cherry picked from commit 1bd8372)

(cherry picked from commit 115cd47)

Co-authored-by: Thiago Lages de Alencar <[email protected]> (cherry picked from commit de55812)

(cherry picked from commit 2dc9cf5)

(cherry picked from commit 2860b99)

(cherry picked from commit 6aee6c1)

Before this change StringName used regular static field definitions for its mutex, _table, configured and debug_stringname fields. Since in the general case the ordering of the static variable and field initialization and destruction is undefined, it was possible that the destruction of StringName's static fields happened prior to the destruction of statically allocated StringName instances. By changing the static field definitions to inline in string_name.h, the C++17 standard guarantees the correct initialization and destruction ordering. (cherry picked from commit 723878b)

(cherry picked from commit 61e2aa7)

(cherry picked from commit 32b7f83)

…ness fade in SSR (cherry picked from commit b99d0d7)

(cherry picked from commit d65ea6f)

(cherry picked from commit 246cc7e)

(cherry picked from commit 8228d64)

The issue was that Node3DEditorViewport was using the render server's BVH to filter out nodes, which is not correct for gizmos that have no renderable components, or have collision triangles that exceed the bounds of their renderable components. (cherry picked from commit 45f6110)

Fixes godotengine#95837. (cherry picked from commit bde165c)

(cherry picked from commit e8254dc)

(cherry picked from commit e698351)

(cherry picked from commit 3f7efd2)

(cherry picked from commit da31679)

(cherry picked from commit 4db3e6e)

(cherry picked from commit 36c9d31)

Before this change, a skeleton that was not updated every frame would result in a difference of 2+ between last_change and frame index every frame, which would disable the buffer rotation and set motion vectors to zero. This results in significant visual artifacts for FSR2 that are especially prominent on the characters that move together with the view such as the main character in third person mode. This is a significant problem for high refresh rate displays: at 120 Hz, we are effectively guaranteed to skip skeleton updates every other frame with skeleton update happening during physics processing, and the lack of physics interpolation for skeletons. This happens by default in TPS demo when FSR2 is enabled. In other places where motion vectors are disabled, such as multi-mesh and mesh rendering (where previous transform is updated), the logic effectively allows for a single-frame gap in updates, because it compares the frame where the update happened (which is the current frame if updates are consistent) with the current frame, so the latency of 0 means "update just happened", but both multi-mesh and mesh transform updates permit a latency of 1 as well. Here, however, last_change is updated *after* the frame processing has concluded, so a zero-latency update has a distance of 1. Allowing a distance of 2 (latency 1) reduces the severity of the problem and aligns the logic with transform updates. Note that the problem will still happen when refresh rate is noticeably higher than physics rate times 2. For example, it still happens at 240 Hz. However, a longer latency allowance is inconsistent with other transforms and could lead to issues, so ideally long term physical interpolation of skeleton transforms would completely solve this. (cherry picked from commit 92f2bc7)

Before this change, using FSR2 resulted in the following error when the effect was destroyed: ERROR: Attempted to free invalid ID: 662734928609453 at: _free_internal (servers/rendering/rendering_device.cpp:4957) This happened because ACCUMULATE and ACCUMULATE_SHARPEN passes shared the same shader_version object but had different pipeline IDs. When version_free was called for ACCUMULATE pass, it destroyed pipelines created from that version, including the pipeline for the ACCUMULATE_SHARPEN pass. Using a unique version could work around this problem, but it's easier to rely on version_free destroying the created pipelines through the dependency mechanism. (cherry picked from commit 0024cfa)

(cherry picked from commit 080acd7)

(cherry picked from commit 0987a9d)

(cherry picked from commit 5183588)

Updated a couple parts that seemed to be copied over from AnimationNodeBlendSpace1D (cherry picked from commit 05bcfda)

Ported the existing zero length check in C++ into C#. (cherry picked from commit 0d6e9de)

…g is disabled (cherry picked from commit 11dd1f5)

(cherry picked from commit b516742)

(cherry picked from commit 1928a84)

(cherry picked from commit 5279fec)

(cherry picked from commit aaafd16)

-avoid use of transitive wayland include -resolves godotengine#95830 Signed-off-by: Joel Winarske <[email protected]> (cherry picked from commit 6ce71f0)

…ystem setting update. (cherry picked from commit 9708535)

(cherry picked from commit 3c0eaec)

… textures (cherry picked from commit e8b4568)

(cherry picked from commit 08ef14a)

There were two small errors in this code example that kept it from working when copied to a new node locally. These are the fixes I used locally to test the example. (cherry picked from commit 97cf2c1)

…ial::render_priority`. (cherry picked from commit ba23b22)

The issue would cause log spams when trying to update the bone pose position or rotation with an invalid bone index. (cherry picked from commit 039722a)

… state and filling both halves of buffer (cherry picked from commit 52cd5ac)

(cherry picked from commit 9a2977f)

(cherry picked from commit ccae47a)

(cherry picked from commit 1b7626f)

(cherry picked from commit 23927c3)

…menu entry (cherry picked from commit b5fa2a3)

(cherry picked from commit ab13513)

(cherry picked from commit 279ccd6)

(cherry picked from commit e8bd385)

(cherry picked from commit e67cc73)

(cherry picked from commit 6ed54ab)

(cherry picked from commit 81799b8)

(cherry picked from commit 5ae85a4)

(cherry picked from commit 6b13236)

Fixes godotengine#96159 (cherry picked from commit fcc8518)

… macOS. (cherry picked from commit 0a57dd4)

…tmap mode looks correct Also remove the metallic option from directional lightmap as it is guaranteed to return negative numbers in many cases (cherry picked from commit f4ccba7)

(cherry picked from commit b97c128)

(cherry picked from commit 760099c)

…ible in reflections from reflection probes. (cherry picked from commit 929c69b)

(cherry picked from commit 5a0a025)

(cherry picked from commit d16dcbb)

The debugger reports synchronizers with empty state to the editor even if no data is being sent to other peers. The editor conditional to avoid division by zero was checking the wrong variable. (cherry picked from commit 042b264)

…esn't support threads (cherry picked from commit b47b98d)

(cherry picked from commit f2186ee)

(cherry picked from commit 09e59fb)

Use correct shadow sampling for omni and spot lights Disable transmittance if shadows are disabled Correct DirectionalLight transmittance bias to match shadow bias (its still pretty sensitive though) (cherry picked from commit d61fae3)

(cherry picked from commit b5fd29e)

(cherry picked from commit 02113df)

(cherry picked from commit 2fd39ec)

(cherry picked from commit 79d0254)

(cherry picked from commit 308186a)

(cherry picked from commit 7e7a4f2)

Updated Viewport destructor to remove itself from World2D, to avoid World2D keeping invalid pointers. (cherry picked from commit 7a9acd5)

Array.sort_custom descending sort example was comparing index 0, but had expected result based on comparing index 1. Updated to use index 1 consistently. (cherry picked from commit 39ca8b4)

(cherry picked from commit 70860aa)

When an AnimationPlayer is made root of a scene, the track links may become broken and clicking on them will crash. Current master branch also breaks node links when AnimationPlayer is made scene root, and can also crash the engine if another node was made scene root prior to the AnimationPlayer. This happens because when made root, the editor loses track of AnimPlayer's root node. By keeping a copy of the AnimPlayer's root_node, the track links remain functional. Fixes godotengine#91043. (cherry picked from commit e905be8)

(cherry picked from commit 44e526d)

(cherry picked from commit d2f5c1a)

…ons. (cherry picked from commit 319bfa9)

(cherry picked from commit d2a8b33)

Also: - Fix holding down keys repeatedly committing instant transformations, and disallow starting instant during non-instant - Fix echoed inputs starting new instant transformations after clicking to confirm, and disallow left mouse release committing instant transformations (cherry picked from commit 060a1a0)

(cherry picked from commit 88f1b67)

(cherry picked from commit 613d4d1)

Duplicate buttons were added when editor description changed (cherry picked from commit ab04d76)

(cherry picked from commit 62d98c6)

(cherry picked from commit 1b6af3a)

Both the tile map layers and the debug navigation canvas items did fight for the same z order causing a lot of flickering in certain situations. (cherry picked from commit 5bedaf7)

(cherry picked from commit 7d78d75)

…uses (cherry picked from commit d1e2afa)

… args (cherry picked from commit 1d09970)

(cherry picked from commit 86c773d)

(cherry picked from commit b11ccf3)

(cherry picked from commit 8da49ab)

(cherry picked from commit 4fa6287)

(cherry picked from commit 9dc2313)

- Drop STL copy in favor of old-school for loops. - Be explicit about loads and stores to atomic value. (This also fixes an error in certain compiler toolchains.) (cherry picked from commit 1cc485b)

(cherry picked from commit d3ddce6)

(cherry picked from commit dee0453)

(cherry picked from commit 7f1989b)

(cherry picked from commit 2c991a7)

MSAA support is built into GLES3 core, eliminating the need to check for GL_EXT_framebuffer_multisample, which was necessary only in GLES2 due to the lack of inherent multisample framebuffer support. This commit corrects an oversight from GLES2-based code, ensuring compatibility with GLES3 where multisampling is natively supported without extensions. (cherry picked from commit fc955fa)

Co-authored-by: Yaohua Xiong <[email protected]> (cherry picked from commit 51b8b74)

(cherry picked from commit 8f66513)

…rlap (cherry picked from commit ab504b3)

(cherry picked from commit ee9cea5)

…extures (cherry picked from commit 359aaa4)

Prevents cache issues by not purging cache before starting a build. Splits cache purge related code from progress code and delays the purge until after final build is done. (cherry picked from commit acffc53)

(cherry picked from commit e120792)

(cherry picked from commit e517eaf)

…ezier editor changes (cherry picked from commit 9d0944b)

(cherry picked from commit 0182294)

(cherry picked from commit 147accd)

…ethod when assinging a node. Fixes godotengine#96238 (cherry picked from commit dabeaa6)

(cherry picked from commit f21a969)

(cherry picked from commit 575a0b4)

(cherry picked from commit 96aa2f2)

Prevents DST from rearranging file times. (cherry picked from commit 7139f46)

Fixes godotengine#81758 DisplayServerWeb::process_joypads handles buttons 6 and 7 of the HTML5 Standard Gamepad as a special case by doing: `input->joy_axis(idx, (JoyAxis)b, s_btns[b]);` This doesn't work because there is no JoyAxis 6 or 7 in the enum To fix this we use JoyAxis::TRIGGER_LEFT and TRIGGER_RIGHT for button 6 and 7 However since we are now lying to input->joy_axis we also need to lie in the mappings for the standard gamepad in godotcontrollersdb.txt, otherwise input->joy_axis will try to find a mapping to axis 4(LT) and axis 5(RT) that's not defined. Therefore we set lefttrigger to +a4 and righttrigger to +a5 in the mapping, to match what we are actually sending. A cleaner, and more involved fix to this would be modifying input->joy_button so that it can handle analog buttons and map them to axes preserving their value instead of converting to boolean (cherry picked from commit 9dd372f)

…acefully Co-authored-by: lawnjelly <[email protected]> (cherry picked from commit 10e2318)

(cherry picked from commit bb77520)

(cherry picked from commit 4d713d9)

(cherry picked from commit e064efc)

(cherry picked from commit c6f7c89)

(cherry picked from commit 8d30ccd)

(cherry picked from commit 8155c1f)

(cherry picked from commit 701188f)

(cherry picked from commit 66832e9)

…ted options not saved. (cherry picked from commit ea25267)

…ementation (cherry picked from commit 42b0e91)

Fixes godotengine#95861. (cherry picked from commit f16d4af)

Fixes godotengine#96262 by backporting thorvg/thorvg#2702. (cherry picked from commit 7375f9b)

Fixes godotengine#96491. Update fix for godotengine#96262 to a simple revert of the problematic commit, as the upstream fix is still being debated and caused other issues. Also include fix for upstream regression 2715 added in 0.14.9. (cherry picked from commit a6ab039)

More fixes to rendering of SVG files with broken text tags. Also backports upstream patch to fix godotengine#97078. (cherry picked from commit 0c0336f)

…ocks (cherry picked from commit 5dade0e)

…ssing export properties. (cherry picked from commit 1df0159)

(cherry picked from commit d06c7ad)

(cherry picked from commit 2b3cf24)

(cherry picked from commit 3038de4)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.3] Cherry-picks for the 4.3 branch (future 4.3.1) - 1st batch #97082

[4.3] Cherry-picks for the 4.3 branch (future 4.3.1) - 1st batch #97082

Commits on Sep 16, 2024

Commits on Sep 17, 2024