forked from godotengine/godot
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GDScript: Do not produce
UNUSED_SIGNAL
warning for common implicit …
…uses
- Loading branch information
Showing
3 changed files
with
63 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 23 additions & 6 deletions
29
modules/gdscript/tests/scripts/analyzer/warnings/unused_signal.gd
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,29 @@ | ||
signal s1() | ||
signal s2() | ||
signal s3() | ||
# Doesn't produce the warning: | ||
signal used_as_first_class_signal() | ||
signal used_with_signal_constructor() | ||
signal used_with_signal_emit() | ||
signal used_with_object_emit_signal() | ||
signal used_with_object_connect() | ||
signal used_with_object_disconnect() | ||
signal used_with_self_prefix() | ||
|
||
# Produce the warning: | ||
signal used_with_dynamic_name() | ||
signal just_unused() | ||
@warning_ignore("unused_signal") | ||
signal s4() | ||
signal unused_but_ignored() | ||
|
||
func no_exec(): | ||
s1.emit() | ||
print(s2) | ||
print(used_as_first_class_signal) | ||
print(Signal(self, "used_with_signal_constructor")) | ||
used_with_signal_emit.emit() | ||
print(emit_signal("used_with_object_emit_signal")) | ||
print(connect("used_with_object_connect", Callable())) | ||
disconnect("used_with_object_disconnect", Callable()) | ||
print(self.emit_signal("used_with_self_prefix")) | ||
|
||
var dynamic_name := "used_with_dynamic_name" | ||
print(emit_signal(dynamic_name)) | ||
|
||
func test(): | ||
pass |
8 changes: 6 additions & 2 deletions
8
modules/gdscript/tests/scripts/analyzer/warnings/unused_signal.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
GDTEST_OK | ||
>> WARNING | ||
>> Line: 3 | ||
>> Line: 11 | ||
>> UNUSED_SIGNAL | ||
>> The signal "s3" is declared but never explicitly used in the class. | ||
>> The signal "used_with_dynamic_name" is declared but never explicitly used in the class. | ||
>> WARNING | ||
>> Line: 12 | ||
>> UNUSED_SIGNAL | ||
>> The signal "just_unused" is declared but never explicitly used in the class. |