[4.3] Cherry-picks for the 4.3 branch (future 4.3.1) - 1st batch #97082
+3,631
−2,114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e do our own sRGB conversion (cherry picked from commit dfcff4e)
(cherry picked from commit 4727c4f)
(cherry picked from commit b1421a0)
Co-authored-by: majikayogames <[email protected]> (cherry picked from commit 4457b11)
…anual light probes (cherry picked from commit 97205ea)
(cherry picked from commit 1c31e30)
…baking The sky rotation now affects the baked environment lighting as it should, making it match how real-time ambient light rendering works. Co-authored-by: Per Melin <[email protected]> (cherry picked from commit 661cf1f)
Fail if submit or sync called multiple times in a row (cherry picked from commit b0e33aa)
…he Compatibility renderer (cherry picked from commit 1bf594f)
(cherry picked from commit e6c45fb)
(cherry picked from commit 1fc8255)
When getting the minimum size for a tooltip, we get the value as a Vector2. Window::set_size() takes a Vector2i, so this size was getting truncated. At certain display scales, this could be enough to cut off part of the tooltip. Updated to call Vector2::ceil() to round up before calling Window::set_size() Fixes godotengine#91958 (cherry picked from commit ca8e3d4)
…rides and added the GlobalClass attribute (cherry picked from commit 74389e8)
(cherry picked from commit e7f215c)
(cherry picked from commit f15ad72)
…ne level module init. (cherry picked from commit 69d52ed)
… of wrapped string. Allow starting/ending RTL selection before line start. (cherry picked from commit 932acce)
(cherry picked from commit d74749f)
(cherry picked from commit 140f9dc)
(cherry picked from commit f483c3a)
(cherry picked from commit bcd776e)
(cherry picked from commit 2d4e573)
(cherry picked from commit 84c5403)
(cherry picked from commit 970a237)
(cherry picked from commit 8c626f2)
Adds NavigationLink function to change navigation map. (cherry picked from commit e6ff4e5)
(cherry picked from commit 3260437)
(cherry picked from commit d357a7d)
(cherry picked from commit b9876b6)
…nds instead of milliseconds (cherry picked from commit cde873b)
(cherry picked from commit 0182294)
(cherry picked from commit 147accd)
…ethod when assinging a node. Fixes godotengine#96238 (cherry picked from commit dabeaa6)
(cherry picked from commit f21a969)
(cherry picked from commit 575a0b4)
(cherry picked from commit 96aa2f2)
Prevents DST from rearranging file times. (cherry picked from commit 7139f46)
Fixes godotengine#81758 DisplayServerWeb::process_joypads handles buttons 6 and 7 of the HTML5 Standard Gamepad as a special case by doing: `input->joy_axis(idx, (JoyAxis)b, s_btns[b]);` This doesn't work because there is no JoyAxis 6 or 7 in the enum To fix this we use JoyAxis::TRIGGER_LEFT and TRIGGER_RIGHT for button 6 and 7 However since we are now lying to input->joy_axis we also need to lie in the mappings for the standard gamepad in godotcontrollersdb.txt, otherwise input->joy_axis will try to find a mapping to axis 4(LT) and axis 5(RT) that's not defined. Therefore we set lefttrigger to +a4 and righttrigger to +a5 in the mapping, to match what we are actually sending. A cleaner, and more involved fix to this would be modifying input->joy_button so that it can handle analog buttons and map them to axes preserving their value instead of converting to boolean (cherry picked from commit 9dd372f)
…acefully Co-authored-by: lawnjelly <[email protected]> (cherry picked from commit 10e2318)
(cherry picked from commit bb77520)
(cherry picked from commit 4d713d9)
(cherry picked from commit e064efc)
(cherry picked from commit c6f7c89)
(cherry picked from commit 8d30ccd)
(cherry picked from commit 8155c1f)
(cherry picked from commit 701188f)
(cherry picked from commit 66832e9)
…ted options not saved. (cherry picked from commit ea25267)
…ementation (cherry picked from commit 42b0e91)
Fixes godotengine#95861. (cherry picked from commit f16d4af)
Fixes godotengine#96262 by backporting thorvg/thorvg#2702. (cherry picked from commit 7375f9b)
Fixes godotengine#96491. Update fix for godotengine#96262 to a simple revert of the problematic commit, as the upstream fix is still being debated and caused other issues. Also include fix for upstream regression 2715 added in 0.14.9. (cherry picked from commit a6ab039)
More fixes to rendering of SVG files with broken text tags. Also backports upstream patch to fix godotengine#97078. (cherry picked from commit 0c0336f)
…ocks (cherry picked from commit 5dade0e)
…ssing export properties. (cherry picked from commit 1df0159)
(cherry picked from commit d06c7ad)
(cherry picked from commit 2b3cf24)
(cherry picked from commit 3038de4)
akien-mga
force-pushed
the
4.3-cherrypicks
branch
from
8db3f1a
to
3a2804a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of cherry-picks for 4.3.1, quite a lot of stuff, more than I'd usually be comfortable with for a first patch release. But it's already been a month so a lot accumulated, and I don't see an easy safe subset to target for a first patch release (or we'd just move the big subset to 4.3.2 and have the same difficulty to get it validated there).
So I think we'll go with YOLO cherry-picks and a long testing phase for 4.3.1 RC 1.
This batch handles most
bugPRs, I'll check the enhancements later. And there's still #96606 which should be included in some form, but is still undergoing frequent changes and may need some "safe subset" treatment.