Fail to build on windows using MSVC 14.42 due to ThorVG

[HKunogi]

Tested versions

• Reproducible with commit 826de79 on windows

System information

Windows 11 - MSVC 14.42

Issue description

• When trying to build on windows with C# support it throws the following errors due to thorvg, it builds fine on linux

D:\IDE\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.42.34226\include\mutex(37): error C3861: '_Mtx_init_in_situ': identifier not found
D:\IDE\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.42.34226\include\mutex(536): error C3861: '_Cnd_init_in_situ': identifier not found
D:\IDE\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.42.34226\include\condition_variable(56): error C3861: '_Cnd_init_in_situ': identifier not found
scons: *** [thirdparty\thorvg\src\loaders\svg\tvgSvgLoader.windows.editor.x86_64.obj] Error 2
scons: building terminated because of errors.

Steps to reproduce

• Simply build the engine source with C# support using latest MSVC 14.42 with latest Windows 11 SDK on Windows.

Minimal reproduction project (MRP)

This is an engine build problem, thus it does not have an actual project.

[fire]

@hermet linking you for tracking

[shadowfox87]

Hello, any update on this? We are unable to build on Windows. We already compiled v4.4 but this still hasn't been implemented.

[akien-mga]

You are using the Preview version of VS 2022, which may not be supported yet. It seems like they broke compatibility in some Windows SDK MSVC STL headers, which might require adjustments in downstream code, or may be a bug on MS' side which will be fixed eventually.

If you need a solution now, I suggest staying to the stable release of VS 2022.

[akien-mga]

I would also try to suggest cleaning all build artifacts (run your usual scons command with --clean added to it, or clean with git clean -fxd, but note this removes all untracked files).

From reading the PR that made this change in the MSVC STL, it seems like your error may come from a mismatched between code compiled with an older version, and the new version of that header.

[akien-mga]

See https://github.com/microsoft/STL/wiki/Changelog#vs-2022-1710

Godot by default doesn't mix binaries from different compiler versions, when you compile Godot from source it should compile everything. One exception to that would be D3D12 dependencies compiled by Microsoft themselves, and ANGLE static compiled by us. Are you including either of those? Please give your full build command in the OP.

CC @bruvzg - if it's ANGLE static, we might need to provide different builds for different versions of MSVC :(

[bruvzg]

Current MSVC tools version is 14.41.34120, and it's building without issues. But the error might be related to the installation location, I think there were reports about SCons not detecting MSVC in non-standard locations (not on drive C:).

See https://github.com/microsoft/STL/wiki/Changelog#vs-2022-1710

This change is in current stable MSVC (17.11.1), so unlikely related.

Edit: seems like current SCons still using hardcoded paths to look for MSVC - https://github.com/SCons/scons/blob/master/SCons/Tool/MSCommon/vc.py#L927-L940

[hermet]

Hello, just for your information, thorvg previsouly applied that option in v0.14.0 (thorvg/thorvg#2385)
and reverted in v0.14.5 (thorvg/thorvg#2611)

[akien-mga]

Oh thanks for the headsup. I really thought thorvg was a red herring here, and just happened the first one to hit a STL mutex include. I hadn't seen that _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR was indeed defined in thorvg. I'll update to fix it.