[WIP] moving canvas interpreter to core by ppisljar · Pull Request #23353 · elastic/kibana

ppisljar · 2018-09-20T11:29:28Z

preparation for #23185

moves some parts of canvas to kibana core:

interpreter parse functions are moved to @kbn/interpreter
function, render function and type registires are moved to @kbn/interpreter
some helper functions are moved to @kbn/interpreter
all types are moved to @kbn/interpreter
most common functions are moved to @kbn/interpreter
browser, location and urlparam browser functions are moved to @kbn/interpreter
es_docs and timelion server functions are moved to @kbn/interpreter
es_fields, es_indices, get_auth, socket, plugin and translate server routes are moved to the interpreter core_plugin
browser socket wrapper is moved to the interpreter core_plugin

qa: nothing should change functionally

…ic#22379) Allows Kibana users to configure the max_concurrent_shard_requests param used by Kibana when sending _msearch requests. Exposes the config as an advanced setting. By default we won't send the param at all, relying on the ES default instead.

…lastic#22904) The `deepFreeze()` function used by `core.injectedMetadata` uses a recursive type definition to indicate that all of the child types within the passed argument become readonly, which works fine for objects but represents arrays as objects instead of using the `ReadonlyArray<>` type. This PR fixes the type definition to use a `RecursiveReadonlyArray<>` type that properly represents arrays with their methods like `push()`, and iterates into the array properly to propagate `ReadOnly<>`, as proven by the tests.

* conditionalize Monitoring tests for Cloud testing * make security_page/login wait * revert these files from another PR * revert these files from another PR

…#21505) * Default to chromium and add deprecation warning for phantom. * use int, not float

…lastic#22875)

* migrate reporting top nav to sharing menu * pass share extensions to visualize share menu * start creating the reporting panel component * add buttons * generate report generatation URL * require save if url changes * add print layout UI * putting it all together - generate reports from share context menu * ensure copy button fills entire menu width * inject job params functionallity * refactor print layout out of ReportingContentPanel * CSV report generation * disable report generation when app is dirty * update URL when window is resized * remove all the old stuff * clean up CSV report register provider * fix typescript errors * fix functional retests * remove failure_debug folder * close popover when generate button clicked, more work on functional tests * set size on button and text, do not use EuiFormRow * use ReactElement type * move ShareContextMenuExtensionsRegistryProvider to ui/share and create interfaces for registy * strictor typing, do not use hard coded object type name * move registry files to typescript * remove destructuring in the interface * convert createReportingJob to async function, remove unneeded comment

- The aim of this is to more clearly visualize how the timerange of the cell selected in the swimlane relates to the time span shown in the charts. - The most important change is that the vertical date axis ticks no longer are randomly positioned by d3. Instead they are aligned with the cell interval of the swimlane. This way, the date information shown in the swimlane tooltip will always align with the date tick shown left of the emphasized area in the chart. - The highlighted area now features a gray rounded border to resemble the styling of the selected cell in the swimlane. - The chart also fixes where to long chart headers would wrap the "View" link to a new line. - The x/y axis labels blackness has been reduced to reduce emphasis on the labels.

* [jest] disable testURL hotfix * [console] mock jquery.ajax in tests * [ui/share] update urls in snapshots

* Capture browser logs * spit out in logs, simulate failure to test * remove leftover code * simulate failure * Remove forced failure

- This fixes a regression introduced in elastic#22814. The influencer list wouldn't update if no cell in the swimlanes was selected. - Renames getTopInfluencers to loadTopInfluencers to be in line with the other functions loadDataForCharts and loadAnomaliesTableData - Changes the order of arguments for loadDataForCharts so they are the same like in loadTopInfluencers.

…lastic#22810) * [Tools] Throw FailError with code context on babel/parser exception * Add description for createParserErrorMessage function

* bump EUI to 3.9.0 * add @types/react-virtualized * remove react-virtualized from x-pack package.json * bump to 3.11.0

- Fixes a regression introduced in elastic#22814. Because of the stricter checking for scope/props updates, resizing the browser window would miss updating the Anomaly Explorer Charts widths. This fixes it by adding a check to trigger anomalyDataChange in redrawOnResize(). - Additionally, if only one chart is up for display, this update makes sure a single chart always spans across the full available width.

…tic#22990) * [ML] Add links to rule editor for quick edit of value or filter * [ML] Updates to rule editor quick links following review

… issues (elastic#22787) * Bring back most of the filtering tests, only bypass the known current issues. * Clean up after the test suite run so it can be run multiple times in a row. * goal and guage issues were because of a bad cache

…lastic#22981) The `UiBundlesController.resetBundleDir()` method deletes old bundle assets when necessary using `del()`, which by default limits deletes to directories within `process.cwd`. This is normally very helpful, but in our case we don't want to limit the `optimize.bundleDir` to the current working directory, so we must use the `force: true` config to disable this check. release notes: Trying to run a Kibana optimization (usually after installing or disabling a plugin) from a directory that is not a parent of the `optimize.bundleDir` configuration or the Kibana installation will no longer fail with "Cannot delete files/folders outside the current working directory".

) The plugin helper tests have failed due to timeouts every once and a while, which makes sense because they run a bunch of CLI tasks, so this just moved them to the jest integration tests where tests can take a little longer to run.

I was surprised when I tried to spread a `Set` in TypeScript and the browser complained about `Set.slice()` not being defined. This is because TypeScript does not automatically enable support for iterators when targeting earlier ES versions, like we do in the browser, unless you use the `"downlevelIteration": true` compiler option. This injects some helpers into the necessary files for reading/spreading iterators, which can be stuffed behind an import statement with using the `"importHelpers": true` compiler option and include `tslib` in our dependencies. This is already a dependency of several of our packages, so it shouldn't cause any additional modules.

adds license headers and includes project linting overrides

node_modules is in a different relative path

ghost · 2018-10-10T17:28:12Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2018-10-10T17:29:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-10T19:05:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ppisljar · 2018-10-11T07:22:03Z

retest

ghost · 2018-10-11T07:22:16Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2018-10-11T09:01:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ghost · 2018-10-11T11:23:24Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2018-10-11T13:06:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ghost · 2018-10-12T07:41:08Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

ppisljar · 2018-10-12T08:32:01Z

retest

ghost · 2018-10-12T08:32:14Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2018-10-12T10:10:09Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ppisljar · 2018-10-12T16:00:19Z

retest

ghost · 2018-10-12T16:00:33Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2018-10-12T16:59:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ghost · 2018-10-13T15:15:07Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

ghost · 2018-10-13T15:21:24Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2018-10-13T16:21:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ppisljar · 2018-10-13T17:00:51Z

retest

ghost · 2018-10-13T17:01:04Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

elasticmachine · 2018-10-13T18:47:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ghost · 2018-10-15T07:47:28Z

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

ppisljar · 2018-10-15T09:20:23Z

i tried to fix the author email and messed up the commit history completely ... ups ....

replaced by #23994

elasticmachine · 2018-10-15T10:47:20Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ppisljar and others added 30 commits September 11, 2018 16:10

fixing sorting of terms bucket (elastic#22919)

748b3fc

Fix rbac test (elastic#22912)

b49397d

* conditionalize Monitoring tests for Cloud testing * make security_page/login wait * revert these files from another PR * revert these files from another PR

Default to chromium and add deprecation warning for phantom. (elastic…

cba3f66

…#21505) * Default to chromium and add deprecation warning for phantom. * use int, not float

translate tutorials(aerospike_metrics, apache_logs, apache_metrics) (e…

caff627

…lastic#22875)

[core/public] stop loadingCount, improve stop() tests (elastic#22937)

945997a

fixed editor state updates for parent pipeline aggs (elastic#22874)

a350797

[DOCS] Synchronize location of Breaking Changes (elastic#22939)

4aeb73c

Remove testURL hotfix from jest upgrade (elastic#22953)

81c7001

* [jest] disable testURL hotfix * [console] mock jquery.ajax in tests * [ui/share] update urls in snapshots

Capture browser logs on test failure (elastic#22670)

21e3cac

* Capture browser logs * spit out in logs, simulate failure to test * remove leftover code * simulate failure * Remove forced failure

[Tools] Throw FailError with code context on babel/parser exception (e…

3ffa698

…lastic#22810) * [Tools] Throw FailError with code context on babel/parser exception * Add description for createParserErrorMessage function

bump EUI to 3.11.0 (elastic#22745)

ce720b0

* bump EUI to 3.9.0 * add @types/react-virtualized * remove react-virtualized from x-pack package.json * bump to 3.11.0

[ML] Add links to rule editor for quick edit of value or filter (elas…

7c3e39a

…tic#22990) * [ML] Add links to rule editor for quick edit of value or filter * [ML] Updates to rule editor quick links following review

hierarchical response handler rewrite (elastic#22578)

d4b2fc9

chore: merge canvas into x-pack

02c1cfc

chore: eslint fixes in canvas

8ea888c

adds license headers and includes project linting overrides

chore: rename files to match rules

bfff015

chore: copy canvas dependencies

0669f10

chore: fix include paths

d9184ef

node_modules is in a different relative path

chore: reduce package.json to essentials

c1ffa36

chore: make canvas work in xpack

a967af0

adding kbn:bootstrap task

151bef5

updating paths

19e70dd

adding eslint exception

e485d72

cleaning globals ?

f63e14d

ppisljar force-pushed the ref/moveCanvasInterpreterToCore branch from 60b7260 to f63e14d Compare October 15, 2018 09:05

ppisljar closed this Oct 15, 2018

Conversation

ppisljar commented Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 10, 2018

Uh oh!

elasticmachine commented Oct 10, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Oct 10, 2018

💔 Build Failed

Uh oh!

ppisljar commented Oct 11, 2018

Uh oh!

ghost commented Oct 11, 2018

Uh oh!

elasticmachine commented Oct 11, 2018

💔 Build Failed

Uh oh!

ghost commented Oct 11, 2018

Uh oh!

elasticmachine commented Oct 11, 2018

💔 Build Failed

Uh oh!

ghost commented Oct 12, 2018

Uh oh!

ppisljar commented Oct 12, 2018

Uh oh!

ghost commented Oct 12, 2018

Uh oh!

elasticmachine commented Oct 12, 2018

💔 Build Failed

Uh oh!

ppisljar commented Oct 12, 2018

Uh oh!

ghost commented Oct 12, 2018

Uh oh!

elasticmachine commented Oct 12, 2018

💔 Build Failed

Uh oh!

ghost commented Oct 13, 2018

Uh oh!

ghost commented Oct 13, 2018

Uh oh!

elasticmachine commented Oct 13, 2018

💔 Build Failed

Uh oh!

ppisljar commented Oct 13, 2018

Uh oh!

ghost commented Oct 13, 2018

Uh oh!

elasticmachine commented Oct 13, 2018

💔 Build Failed

Uh oh!

ghost commented Oct 15, 2018

Uh oh!

ppisljar commented Oct 15, 2018

Uh oh!

elasticmachine commented Oct 15, 2018

💔 Build Failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

ppisljar commented Sep 20, 2018 •

edited

Loading