fixed editor state updates for parent pipeline aggs#22874
Merged
ppisljar merged 3 commits intoelastic:masterfrom Sep 12, 2018
Merged
fixed editor state updates for parent pipeline aggs#22874ppisljar merged 3 commits intoelastic:masterfrom
ppisljar merged 3 commits intoelastic:masterfrom
Conversation
ppisljar
added
Feature:Visualizations
markov00
reviewed
Sep 10, 2018
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Pulled PR and tested locally. I can resolve the visualization configuration error now.
Two small comments on the added functional tests.
Approve after changes/comments and CI pass.
Contributor
There was a problem hiding this comment.
Could you add this in as a function in the visualize_page
Contributor
Author
There was a problem hiding this comment.
i am not a huge fan of putting functions that are never reused in there, but i can move it.
Contributor
💚 Build Succeeded |
markov00
approved these changes
Sep 10, 2018
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
ppisljar
force-pushed
the
fix/pipelineAggEditorState
branch
from
3d18e83 to
fa6b6d9
Compare
Contributor
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Sep 12, 2018
ppisljar
added a commit
that referenced
this pull request
Sep 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #22833
release notes: editor now correctly shows errors for parent pipeline aggregations
qa: create a vertical bar chart, choose derivative as a metric and add date histogram bucket agg.
after this add another bucket agg, select split rows, terms, any field ... before you wouldn't get an error, you could apply the change and get elasticsearch error. after this nothing worked.