Remove testURL hotfix from jest upgrade#22953
Merged
spalger merged 3 commits intoelastic:masterfrom Sep 12, 2018
Merged
Conversation
spalger
force-pushed
the
fix/jest/no-accidental-fetch
branch
from
aa2db5f to
63b17f4
Compare
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 12, 2018
* [jest] disable testURL hotfix * [console] mock jquery.ajax in tests * [ui/share] update urls in snapshots
spalger
pushed a commit
that referenced
this pull request
Sep 13, 2018
Contributor
Author
|
6.5/6.x: a82af28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While upgrading jest in #22791 I had to set the
testURLconfig toabout:blankto prevent JSDom from executing ajax requests, but turns out fixing the problem isn't that hard and using the default allows simulate navigation, which I need to test #20696.