[Tools] Throw FailError with code context on babel/parser exception#22810
Merged
maryia-lapata merged 2 commits intoelastic:masterfrom Sep 13, 2018
Merged
Conversation
LeanidShutau
added
Team:Core
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
LeanidShutau
requested review from
azasypkin,
maryia-lapata and
pavel06081991
azasypkin
approved these changes
Sep 11, 2018
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
LGTM, tested on JS, html and pug file, worked as expected, just one nit.
src/dev/i18n/utils.js
Outdated
| } | ||
|
|
||
| /** | ||
| * @param {string} content |
Contributor
There was a problem hiding this comment.
nit: please add a detailed description here so that it is clear what this function does
Contributor
|
retest |
Contributor
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Sep 13, 2018
…lastic#22810) * [Tools] Throw FailError with code context on babel/parser exception * Add description for createParserErrorMessage function
Contributor
Author
|
6.x/6.5: 0a44c3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@babel/parsersyntax errors should be described on throwing them to console.