Expose max_concurrent_shard_requests for _msearch requests#22379
Expose max_concurrent_shard_requests for _msearch requests#22379Bargs merged 2 commits intoelastic:masterfrom
max_concurrent_shard_requests for _msearch requests#22379Conversation
There was a problem hiding this comment.
While this technically works, I'd like to change it to use the snake case version once the es.js API generation script is re-run to make maxConcurrentShardRequests a first class citizen.
There was a problem hiding this comment.
Ah, so elasticsearch.js will pass arbitrary properties through? I didn't realize that...
💚 Build Succeeded |
|
A negative value for this will cause fatal errors to be fired, and I had to navigate by URL back to the management panel to fix the issue. Can we do some validation to ensure it is either zero or a positive integer? Also, can you add tests? |
|
@Bargs any progress on this? |
|
Been OOO for the past week, I should be able to make updates based on Court's feedback this week. |
|
@Bargs ping :) |
|
@epixa which page were you getting fatal errors on? I'm only able to get a regular error that already has a pretty clear message:
Validation on the advanced settings page itself would be ideal, but afaik we don't have an existing mechanism for validation on that page and building one would be beyond the scope of this PR IMO. |
|
@Bargs I'll have to check. Perhaps the fatal error issue was fixed. |
Bargs
force-pushed
the
addMaxShardRequestsSetting
branch
from
5100c93 to
dbf4f9c
Compare
|
Ok, I added a couple tests as well. Lemme know what you find. |
|
The fatal error is still happening for me: Firefox 62/macOS I can reproduce consistently by starting up a fresh Kibana:
It also breaks on Dashboard. |
💚 Build Succeeded |
|
@epixa Have you pulled my most recent changes? I rebased before my last push, so perhaps that fixed something inadvertently. I still can't get that fatal error to happen with the exact same data, OS, and browser.
|
epixa
left a comment
epixa
left a comment
There was a problem hiding this comment.
LGTM
I originally didn't see a merge and didn't notice your rebase, so I didn't pull down the latest. Pulled down now and I see the same thing you see, which works for me since the error message is clear and the user can navigate back to fix it.
…ic#22379) Allows Kibana users to configure the max_concurrent_shard_requests param used by Kibana when sending _msearch requests. Exposes the config as an advanced setting. By default we won't send the param at all, relying on the ES default instead.
… (#22930) Allows Kibana users to configure the max_concurrent_shard_requests param used by Kibana when sending _msearch requests. Exposes the config as an advanced setting. By default we won't send the param at all, relying on the ES default instead.
4 participants
Fixes #22206
Allows Kibana users to configure the
max_concurrent_shard_requestsparam used by Kibana when sending_msearchrequests. Exposes the config as an advanced setting. By default we won't send the param at all, relying on the ES default instead.