[kbn-plugin-helpers] move jest tests to integration suite#23005
Merged
spalger merged 1 commit intoelastic:masterfrom Sep 13, 2018
Merged
[kbn-plugin-helpers] move jest tests to integration suite#23005spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
spalger
force-pushed
the
fix/plugin-helpers/integration-tests
branch
2 times, most recently
from
b74a09d to
d0b4fcc
Compare
spalger
force-pushed
the
fix/plugin-helpers/integration-tests
branch
from
d0b4fcc to
4b6af4f
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
fix/plugin-helpers/integration-tests
branch
from
4b6af4f to
94a9170
Compare
w33ble
approved these changes
Sep 13, 2018
Contributor
w33ble
left a comment
w33ble
left a comment
There was a problem hiding this comment.
I don't know anything about how jest tests are run in our stack, or why changing file paths does anything, but if the CI passes, then LGETM.
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
spalger
pushed a commit
that referenced
this pull request
Sep 14, 2018
…23012) The plugin helper tests have failed due to timeouts every once and a while, which makes sense because they run a bunch of CLI tasks, so this just moved them to the jest integration tests where tests can take a little longer to run.
Contributor
Author
|
6.5/6.x: bd9e214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin helper tests have failed due to timeouts every once and a while, which makes sense because they run a bunch of CLI tasks, so this just moved them to the jest integration tests where tests can take a little longer to run.