hierarchical response handler rewrite#22578
Merged
ppisljar merged 6 commits intoelastic:masterfrom Sep 13, 2018
Merged
Conversation
ppisljar
added
WIP
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
rewrite/hierarchicalResponseHandler
branch
from
0677969 to
8d5163b
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
rewrite/hierarchicalResponseHandler
branch
from
8b533fc to
24faf14
Compare
Contributor
💚 Build Succeeded |
markov00
reviewed
Sep 12, 2018
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
To minor comments on the code.
Overall looks good. Tested on chrome
| const name = fieldFormatter(row[columnIndex].value); | ||
| const size = row[columnIndex + 1].value; | ||
| const aggConfig = table.columns[columnIndex].aggConfig; | ||
| const aggConfigResult = row[columnIndex + 1]; |
Contributor
There was a problem hiding this comment.
As a formatting hint I will rather rewrite this as:
for(;;)
const { aggConfig } = table.columns[columnIndex]
const bucketColumn = row[columnIndex];
const metricColumn = row[columnIndex + 1];
const fieldFormatter = aggConfig.fieldFormatter('text');
const name = fieldFormatter(bucketColumn.value);
const size = metricColumn.value;
markov00
approved these changes
Sep 13, 2018
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
nreese
approved these changes
Sep 13, 2018
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review, tested pie chart visualization with 3 slices and one split. Functionally the same as master. Verified tooltips and filtering also work.
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Sep 13, 2018
ppisljar
added a commit
that referenced
this pull request
Sep 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrites hierarchical response handler in preparation for #19813
all response handlers needs to be based on top of tabify. hierarchical was still using es raw response directly.