[core/public] stop loadingCount, improve stop() tests#22937
Merged
spalger merged 1 commit intoelastic:masterfrom Sep 11, 2018
Merged
[core/public] stop loadingCount, improve stop() tests#22937spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
spalger
requested review from
azasypkin and
epixa
and removed request for
epixa
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 11, 2018
spalger
pushed a commit
that referenced
this pull request
Sep 12, 2018
Contributor
Author
|
6.x/6.5: 3c9fcd5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that we forgot to stop the
LoadingCountServicein theCoreSystemand that the tests forCoreSystem.stop()were lacking, so fixed the bug and improved the tests.