Conversation
LeeDr
added
test
Team:Security
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
|
Pulled the PR and tested it on local in a loop. It has been passing consistently. However on cloud I see that it failed. I have attached the output here. |
| describe('Management', () => { | ||
| before(async () => { | ||
| await PageObjects.security.login('elastic', 'changeme'); | ||
| // await PageObjects.security.login('elastic', 'changeme'); |
Contributor
There was a problem hiding this comment.
Commented line can be removed.
legrego
approved these changes
Sep 11, 2018
Member
legrego
left a comment
legrego
left a comment
There was a problem hiding this comment.
LGTM - tested rbac tests locally
Contributor
|
It passed successfully on cloud - ran it twice. LGTM . |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Sep 11, 2018
* conditionalize Monitoring tests for Cloud testing * make security_page/login wait * revert these files from another PR * revert these files from another PR
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Sep 11, 2018
* conditionalize Monitoring tests for Cloud testing * make security_page/login wait * revert these files from another PR * revert these files from another PR
Author
This was referenced Sep 11, 2018
LeeDr
pushed a commit
that referenced
this pull request
Sep 11, 2018
LeeDr
pushed a commit
that referenced
this pull request
Sep 11, 2018
liza-mae
added
failed-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common_page navigateToUrl and navigateToApp both check if they hit a login page when navigating. This is in the OSS Kibana test page objects (and not x-pack) so that we can run the kibana functional UI tests against Cloud or any other Kibana which has security enabled. It doesn't allow for logging in as different users. Only the configured super user (which can be passed in env vars for the Cloud case).
We also have login/logout methods in x-pack/test/functional/page_objects/security_page.js. And these do allow passing specific user/pwd. But the login method in security_page instantly returned after clicking Submit. So any actions (like navigation) that happen right after that login could have problems because the page was still loading.
I added the same check after clicking Submit that we had in the common_page method.
But then I found that the test for invalid user/pwd failed because it was waiting for kibanaChrome element which never appears in that case. So I added a
expectSuccess = trueparameter to the login method and only wait for kibanaChrome if that's true. The invalid login test now passesfalse.I thought about eliminating any redundancy between that common_page and security_page, but didn't want the OSS kibana tests to reference x-pack code when everything else references from x-pack to OSS.
At some point we might just combine all the test stuff into the base OSS folders...