[WIP] Flag @kbn/config-schema as server-only#189476
Open
afharo wants to merge 8 commits intoelastic:mainfrom
Open
[WIP] Flag @kbn/config-schema as server-only#189476afharo wants to merge 8 commits intoelastic:mainfrom
@kbn/config-schema as server-only#189476afharo wants to merge 8 commits intoelastic:mainfrom
Conversation
afharo
added
release_note:skip
afharo
added
the
technical debt
This was referenced Jul 30, 2024
1 task
Member
Author
|
/ci |
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
1 task
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
This was referenced Aug 30, 2024
Contributor
|
@afharo, are there still plans to follow through this PR? |
Member
Author
I'd love it if we complete it... but other priorities came through. |
daviddetorres
added
the
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #188606, let's enforce
@kbn/config-schemato be ashared-serverto ensure that it never leaks to the browser anymore.To make reviews easier, I'll apply the fixes in separate PRs, and keep rebasing this one until the CI is green. Not setting it as draft to avoid having to comment
/cion every push. Reviewers, feel free to unsubscribe from the notifications. I'll ping you once it's all ready.For maintainers