[Move @kbn/config-schema to server] unified_search#191773
Merged
afharo merged 1 commit intoelastic:mainfrom Aug 30, 2024
Merged
[Move @kbn/config-schema to server] unified_search#191773afharo merged 1 commit intoelastic:mainfrom
@kbn/config-schema to server] unified_search#191773afharo merged 1 commit intoelastic:mainfrom
Conversation
afharo
added
technical debt
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
nickofthyme
approved these changes
Aug 29, 2024
Contributor
nickofthyme
left a comment
nickofthyme
left a comment
There was a problem hiding this comment.
Vis code changes LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
ashokaditya
approved these changes
Aug 30, 2024
ymao1
approved these changes
Aug 30, 2024
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
response ops changes lgtm. code review only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #189476.
We want to avoid
@kbn/config-schemafrom leaking to the browser, and this plugin is using it outside the./serverdirectory.For maintainers