Skip to content

[Move @kbn/config-schema to server] kbn-reporting#191689

Merged
afharo merged 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/kbn-reporting
Aug 29, 2024
Merged

[Move @kbn/config-schema to server] kbn-reporting#191689
afharo merged 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/kbn-reporting

Conversation

@afharo
Copy link
Member

@afharo afharo commented Aug 28, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this package depends on it.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Aug 28, 2024
@afharo afharo requested a review from a team as a code owner August 28, 2024 23:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@afharo afharo enabled auto-merge (squash) August 28, 2024 23:45
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / Detection Engine - Exception workflows APIs @serverless @serverlessQA @ess rule exceptions execution creating rules with exceptions should be able to execute against an exception list that does include valid case sensitive entries and get back 0 alerts

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 78e6d16 into elastic:main Aug 29, 2024
@afharo afharo deleted the move-config-schema-to-server/kbn-reporting branch August 29, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// technical debt Improvement of the software architecture and operational architecture v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants