Minimize `shared-common` everywhere by afharo · Pull Request #188606 · elastic/kibana

afharo · 2024-07-17T22:08:34Z

Summary

At the moment, our package generator creates all packages with the type shared-common. This means that we cannot enforce boundaries between server-side-only code and the browser, and vice-versa.

I started fixing packages/core/*
It took me to fixing src/core/ type to be identified by the plugin pattern (public and server directories) vs. a package (either common, or single-scoped)
Unsurprisingly, this extended to packages importing core packages hitting the boundaries eslint rules. And other packages importing the latter.
Also a bunch of common logic that shouldn't be so common 🙃

For maintainers

This was checked for breaking API changes and was labeled appropriately

afharo · 2024-07-17T22:09:04Z

/ci

afharo · 2024-07-18T16:29:48Z

/ci

afharo · 2024-07-18T16:33:19Z

/ci

elasticmachine · 2024-07-18T16:51:33Z

💔 Build Failed

Buildkite Build
Commit: afabd06

Failed CI Steps

Quick Checks

History

💔 Build #222235 failed 9592b321179d7c96a061c5a5831f314b8d879cc2

cc @afharo

afharo · 2024-07-18T17:33:56Z

/ci

…verywhere

…fix'

tiansivive

LGTM from Security Entity Analytics

…verywhere

…agement'

…verywhere

dmlemeshko

appex-qa changes LGTM

…verywhere

MadameSheema

Thanks!! :)

afharo · 2024-07-29T15:58:36Z

Thank you all for approving!

Updating from main (hopefully) one last time! And enabling auto-merge.

kibana-ci · 2024-07-29T17:48:43Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 1d5c572

Failed CI Steps

Test Failures

[job] [logs] Jest Integration Tests #6 / telemetry tasks endpoint-meta-telemetry should execute when scheduled

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`esUiShared`	238	241	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/server-route-repository-utils`	-	5	+5
`@kbn/synthetics-e2e`	-	32	+32
total			+37

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`@kbn/synthetics-e2e`	-	2	+2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`synthetics`	0	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`esUiShared`	158.1KB	158.9KB	+799.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/server-route-repository-utils`	-	5	+5
`@kbn/synthetics-e2e`	-	32	+32
total			+37

ESLint disabled in files

id	before	after	diff
`@kbn/apm-ftr-e2e`	-	2	+2
`@kbn/synthetics-e2e`	-	1	+1
`@kbn/test-suites-serverless`	-	1	+1
`@kbn/test-suites-src`	-	6	+6
`@kbn/test-suites-xpack`	-	23	+23
`apm`	14	12	-2
`synthetics`	7	6	-1
total			+30

ESLint disabled line counts

id	before	after	diff
`@kbn/apm-ftr-e2e`	-	3	+3
`@kbn/observability-onboarding-e2e`	-	3	+3
`@kbn/synthetics-e2e`	-	20	+20
`@kbn/test-suites-serverless`	-	2	+2
`@kbn/test-suites-src`	-	43	+43
`@kbn/test-suites-xpack`	-	705	+705
`@kbn/test-suites-xpack-performance`	-	2	+2
`apm`	73	70	-3
`observabilityOnboarding`	15	12	-3
`synthetics`	84	64	-20
total			+752

References to deprecated APIs

id	before	after	diff
`@kbn/test-suites-xpack`	-	2	+2

Total ESLint disabled count

id	before	after	diff
`@kbn/apm-ftr-e2e`	-	5	+5
`@kbn/observability-onboarding-e2e`	-	3	+3
`@kbn/synthetics-e2e`	-	21	+21
`@kbn/test-suites-serverless`	-	3	+3
`@kbn/test-suites-src`	-	49	+49
`@kbn/test-suites-xpack`	-	728	+728
`@kbn/test-suites-xpack-performance`	-	2	+2
`apm`	87	82	-5
`observabilityOnboarding`	19	16	-3
`synthetics`	91	70	-21
total			+782

History

💚 Build #224393 succeeded 313612a
💔 Build #224303 failed a5854ae
💔 Build #224222 failed 3746376
💔 Build #224144 failed bbf3750
💔 Build #224056 failed 89d46ae
💔 Build #223916 failed 4f0d7d4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

TinaHeiligers

LGTM

## Summary I noticed `elastic/appex-qa` is pinged for quite many PRs. with #188606 some test folders became packages with `"owner": "@elastic/appex-qa",`, that autmatically updated CODEOWNERS file with appex-qa listed for basically every test path. https://github.com/elastic/kibana/pull/188606/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7R878-R881 This PR removes `owner` for the following test "packages" - x-pack/test_serverless - test - x-pack/test and CODEOWNERS file keeps these paths without specific owner. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

afharo self-assigned this Jul 18, 2024

afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting technical debt Improvement of the software architecture and operational architecture labels Jul 18, 2024

afharo force-pushed the shared-common-everywhere branch from 78033e7 to 4688a67 Compare July 18, 2024 16:13

afharo added 4 commits July 18, 2024 18:28

Minimize shared-common everywhere

ae1b8ec

Fix packages types

92c704b

Fix more packages and plugins

2f2c69f

Missing case core

0ed5298

afharo force-pushed the shared-common-everywhere branch from 0fcfca4 to 0ed5298 Compare July 18, 2024 16:29

Fix tsconfig.json

afabd06

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

73842e9

afharo marked this pull request as ready for review July 18, 2024 19:11

afharo requested a review from a team as a code owner July 18, 2024 19:11

afharo requested a review from a team July 18, 2024 19:11

afharo requested review from a team as code owners July 18, 2024 19:11

afharo requested a review from tiansivive July 25, 2024 16:13

afharo and others added 2 commits July 25, 2024 18:23

Merge branch 'main' of github.com:elastic/kibana into shared-common-e…

e151903

…verywhere

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

cdfaf19

…fix'

tiansivive approved these changes Jul 25, 2024

View reviewed changes

afharo added 3 commits July 25, 2024 21:14

Fix CI errors

4f0d7d4

Convert e2e dirs to packages

9b97f3b

Merge branch 'main' of github.com:elastic/kibana into shared-common-e…

89d46ae

…verywhere

afharo force-pushed the shared-common-everywhere branch from 59b3145 to 89d46ae Compare July 26, 2024 13:22

afharo added 2 commits July 26, 2024 17:28

Fix types

6acbde0

Merge branch 'main' of github.com:elastic/kibana into shared-common-e…

c80f20b

…verywhere

afharo force-pushed the shared-common-everywhere branch from d9a8e6d to c80f20b Compare July 26, 2024 16:05

kibanamachine and others added 3 commits July 26, 2024 16:48

[CI] Auto-commit changed files from 'yarn openapi:bundle:endpoint-man…

bbf3750

…agement'

Merge branch 'main' of github.com:elastic/kibana into shared-common-e…

3746376

…verywhere

Merge branch 'main' into shared-common-everywhere

a5854ae

dmlemeshko approved these changes Jul 29, 2024

View reviewed changes

wayneseymour approved these changes Jul 29, 2024

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into shared-common-e…

313612a

…verywhere

MadameSheema approved these changes Jul 29, 2024

View reviewed changes

Merge branch 'main' into shared-common-everywhere

1d5c572

afharo enabled auto-merge (squash) July 29, 2024 15:58

TinaHeiligers approved these changes Jul 29, 2024

View reviewed changes

Ikuni17 disabled auto-merge July 29, 2024 18:47

Ikuni17 merged commit 11b750b into elastic:main Jul 29, 2024

kibanamachine added the v8.16.0 label Jul 29, 2024

afharo deleted the shared-common-everywhere branch July 29, 2024 18:54

afharo mentioned this pull request Jul 30, 2024

[WIP] Flag @kbn/config-schema as server-only #189476

Open

1 task

dmlemeshko mentioned this pull request Jul 31, 2024

[CODEOWNERS] fix appex-qa ownership #189602

Merged

Comments

Conversation

afharo commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

For maintainers

Uh oh!

afharo commented Jul 17, 2024

Uh oh!

afharo commented Jul 18, 2024

Uh oh!

afharo commented Jul 18, 2024

Uh oh!

elasticmachine commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

afharo commented Jul 18, 2024

Uh oh!

tiansivive left a comment

Choose a reason for hiding this comment

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

MadameSheema left a comment

Choose a reason for hiding this comment

Uh oh!

afharo commented Jul 29, 2024

Uh oh!

kibana-ci commented Jul 29, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Public APIs missing exports

Page load bundle

API count

ESLint disabled in files

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

afharo commented Jul 17, 2024 •

edited

Loading

elasticmachine commented Jul 18, 2024 •

edited

Loading