Skip to content

[Move @kbn/config-schema to server] transform#191685

Merged
afharo merged 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/transform
Aug 29, 2024
Merged

[Move @kbn/config-schema to server] transform#191685
afharo merged 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/transform

Conversation

@afharo
Copy link
Member

@afharo afharo commented Aug 28, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this plugin is using it outside the ./server directory.

For maintainers

@afharo afharo added Team:QA Platform QA t// :ml technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Team:ML Team label for ML (also use :ml) t// Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Aug 28, 2024
@afharo afharo requested review from a team as code owners August 28, 2024 23:29
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 28, 2024

Pinging @elastic/appex-qa (Team:QA)

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 28, 2024

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 28, 2024

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 28, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@afharo afharo enabled auto-merge (squash) August 28, 2024 23:29
@kibana-ci
Copy link

kibana-ci commented Aug 29, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wayneseymour
wayneseymour approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR only, LGTM

@walterra walterra self-requested a review August 29, 2024 08:28
ymao1
ymao1 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes lgtm

walterra
walterra approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking this up!

@afharo afharo merged commit b36b198 into elastic:main Aug 29, 2024
@afharo afharo deleted the move-config-schema-to-server/transform branch August 29, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@ymao1 ymao1 ymao1 approved these changes

+1 more reviewer

@wayneseymour wayneseymour wayneseymour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:ML Team label for ML (also use :ml) t// Team:QA Platform QA t// Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// technical debt Improvement of the software architecture and operational architecture v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@afharo @elasticmachine @kibana-ci @walterra @shahzad31 @wayneseymour @ymao1 @kibanamachine