Skip to content

[Move @kbn/config-schema to server] triggers_actions_ui#191684

Merged
afharo merged 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/triggers_actions_ui
Aug 29, 2024
Merged

[Move @kbn/config-schema to server] triggers_actions_ui#191684
afharo merged 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/triggers_actions_ui

Conversation

@afharo
Copy link
Member

@afharo afharo commented Aug 28, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this plugin is using it outside the ./server directory.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Aug 28, 2024
@afharo afharo requested a review from a team as a code owner August 28, 2024 23:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@@ -1,14 +0,0 @@
/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a more recent duplicate of this file at ./server/config.ts

@afharo afharo enabled auto-merge (squash) August 28, 2024 23:17
@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 7aa10d1 into elastic:main Aug 29, 2024
@afharo afharo deleted the move-config-schema-to-server/triggers_actions_ui branch August 29, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// technical debt Improvement of the software architecture and operational architecture v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants