[Move @kbn/config-schema to server] examples/response_stream#189520
Merged
afharo merged 2 commits intoelastic:mainfrom Jul 30, 2024
Merged
Conversation
afharo
added
:ml
technical debt
Contributor
|
Pinging @elastic/ml-ui (:ml) |
walterra
reviewed
Jul 30, 2024
| export { reducerStreamReducer } from './reducer'; | ||
| export { reducerStreamRequestBodySchema } from './request_body_schema'; | ||
| export type { ReducerStreamRequestBodySchema } from './request_body_schema'; | ||
| export type { ReducerStreamRequestBodySchema } from '../../../server/routes/schemas/reducer_stream'; |
Contributor
There was a problem hiding this comment.
This was in common originally because just the type was reused on the client (which shouldn't leak the whole lib). It looks like this usage is no longer the case so I think you can remove this export from common.
|
|
||
| export { simpleStringStreamRequestBodySchema } from './request_body_schema'; | ||
| export type { SimpleStringStreamRequestBodySchema } from './request_body_schema'; | ||
| export type { SimpleStringStreamRequestBodySchema } from '../../../server/routes/schemas/simple_string_stream'; |
Contributor
There was a problem hiding this comment.
Same here, it looks like this can be removed from common altogether.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
walterra
approved these changes
Jul 30, 2024
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
Latest changes LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #189476.
We want to avoid
@kbn/config-schemafrom leaking to the browser.For maintainers