Skip to content

[Move @kbn/config-schema to server] @kbn/config#189525

Merged
afharo merged 3 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/kbn-config
Jul 30, 2024
Merged

[Move @kbn/config-schema to server] @kbn/config#189525
afharo merged 3 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/kbn-config

Conversation

@afharo
Copy link
Member

@afharo afharo commented Jul 30, 2024 •
edited
Loading

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser.

For maintainers

@afharo afharo added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Jul 30, 2024
@afharo afharo self-assigned this Jul 30, 2024
@afharo afharo requested a review from a team as a code owner July 30, 2024 14:51
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 30, 2024

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo requested a review from a team as a code owner July 30, 2024 15:59
nreese
nreese approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@afharo afharo enabled auto-merge (squash) July 30, 2024 20:19
@kibana-ci
Copy link

kibana-ci commented Jul 30, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #98 / Cloud Security Posture Findings Page - Alerts Create detection rule Creates a detection rule from the Alerts section and navigates to rule page
  • [job] [logs] FTR Configs #47 / machine learning - permissions for user with full ML access with data loaded (ft_ml_poweruser_spaces) should display elements on Single Metric Viewer page correctly

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

TinaHeiligers
TinaHeiligers approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo merged commit 3c9b2f4 into elastic:main Jul 30, 2024
@afharo afharo deleted the move-config-schema-to-server/kbn-config branch July 30, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees

@afharo afharo

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// technical debt Improvement of the software architecture and operational architecture v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@afharo @elasticmachine @kibana-ci @nreese @TinaHeiligers @kibanamachine