Skip to content

[Move @kbn/config-schema to server] actions#191850

Draft
afharo wants to merge 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/actions
Draft

[Move @kbn/config-schema to server] actions#191850
afharo wants to merge 2 commits intoelastic:mainfrom
afharo:move-config-schema-to-server/actions

Conversation

@afharo
Copy link
Member

@afharo afharo commented Aug 30, 2024

Summary

Part of #189476.

We want to avoid @kbn/config-schema from leaking to the browser, and this plugin is using it outside the ./server directory.

I cannot find this code being imported in the UI, so I don't expect it to have any impact on bundle metrics, but this PR is still useful to avoid potential future leaks.

For maintainers

@afharo afharo added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Aug 30, 2024
@afharo afharo requested a review from a team as a code owner August 30, 2024 14:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@afharo afharo enabled auto-merge (squash) August 30, 2024 14:55
@afharo afharo requested a review from a team as a code owner August 30, 2024 17:12
@afharo afharo requested review from pzl and szwarckonrad August 30, 2024 17:12
@pzl pzl requested review from ashokaditya and removed request for pzl August 30, 2024 17:19
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szwarckonrad
Copy link
Contributor

@afharo
Apologies, it seems this PR slipped through the cracks. Would you still like us to take a look at it?

@afharo
Copy link
Member Author

afharo commented Dec 12, 2024

@szwarckonrad, thanks! Let me move it to draft until I resolve the conflicts and will get back to you

@afharo afharo disabled auto-merge December 12, 2024 09:15
@afharo afharo marked this pull request as draft December 12, 2024 10:28
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@szwarckonrad
Copy link
Contributor

@afharo
I'm doing some spring cleaning of my GitHub assignments, feel free to reassing me once you move it off the draft :)

@szwarckonrad szwarckonrad removed their request for review April 22, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// technical debt Improvement of the software architecture and operational architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants