Fix SwipeView memory leak when SwipeItems are reused or replaced

[Vignesh-SF3580]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

SwipeView instances and their ancestor chain (page, view model, payload) are not collected when a cached SwipeItems instance is reused across multiple SwipeViews or when SwipeItems are replaced at runtime. Over time, each page push/pop retains additional SwipeView and view-model instances, causing continuous memory growth.

Root Cause

SwipeView subscribes to SwipeItems events through two separate paths, and those subscriptions are not properly removed when SwipeItems outlives the SwipeView.
In OnSwipeItemsChanged, local-function handlers were used for CollectionChanged and PropertyChanged. Since each += created a new delegate instance, the later -= could not remove the original handler. As a result, old SwipeItems instances continued holding references to the SwipeView.
In OnChildAdded and OnChildRemoved, SwipeView also subscribed to child.PropertyChanged for logical children, including SwipeItems. The matching unsubscribe only happened through RemoveLogicalChild, which is not called when a cached SwipeItems is retained and reused by the user.
Both cases created strong references from long-lived SwipeItems objects to short-lived SwipeViews, preventing the SwipeView, page, and related view models from being garbage collected.

Description of Change

The notification ownership was inverted so SwipeItems now notifies its parent SwipeView directly instead of the SwipeView subscribing to SwipeItems events.
SwipeItems now overrides OnCollectionChanged and OnPropertyChanged. From those overrides, it walks the Element.Parent chain to find the owning SwipeView and calls an internal OnSwipeItemsChangedFromChild(...) method.
SwipeView.OnSwipeItemsChanged no longer subscribes to CollectionChanged or PropertyChanged events on SwipeItems. It now only handles property, style, and child setup while still invoking the same internal SendChange(...) logic.
SwipeView.OnChildAdded and OnChildRemoved were also updated to skip PropertyChanged subscriptions for SwipeItems children, since the new parent-driven notification flow already covers those updates.
With this approach, there is no longer any strong reference from cached SwipeItems instances to a SwipeView. The SwipeView can now be garbage collected normally once its page is removed, even if the app keeps the SwipeItems alive in a cache.

Issues fixed

Fixes #35481

Screenshots

iOS:

Before Issue Fix	After Issue Fix
35481iOSBeforeFix.mov	35481iOSAfterFix.mov

Android:

Before Issue Fix	After Issue Fix
35481AndroidBeforeFix.mov	35481AndroidAfterFix.mov

Windows:

Before Issue Fix	After Issue Fix
35481WindowsBeforeFix.mp4	35481WindowsAfterFix.mp4

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35539

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35539"

[kubaflo]

/review -b feature/regression-check -p android

[MauiBot]

🤖 AI Summary

👋 @Vignesh-SF3580 — new AI review results are available. Please review the latest session below.

📊 Review Session — bead39d · Update PropertyChanged. · 2026-05-20 20:38 UTC

🚦 Gate — Test Before & After Fix

Gate Result: ✅ PASSED

Platform: ANDROID · Base: main · Merge base: 59797ba3

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🧪 SwipeViewTests SwipeViewTests	✅ FAIL — 108s	✅ PASS — 83s

🔴 Without fix — 🧪 SwipeViewTests: FAIL ✅ · 108s

(truncated to last 15,000 chars)

was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [6]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [7]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [8]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [9]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [10]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [11]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [12]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [13]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [14]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [15]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [16]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [17]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [18]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [19]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.66]       Stack Trace:
[xUnit.net 00:00:01.66]         /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs(595,0): at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.CachedSwipeItemsDoesNotKeepSwipeViewAlive()
[xUnit.net 00:00:01.66]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:01.66]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed TestSwipeItemView [46 ms]
  Passed TestContentBindingContextPropagatesToPassedInSwipeItem [9 ms]
  Passed BindingContextTransfersToNewSetOfSwipeItems [5 ms]
  Passed TestRightItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToAddedSwipeItems [< 1 ms]
  Passed SwipeViewFindsScrollParentDirectlyWhenTreeIsConnected [3 ms]
  Failed CachedSwipeItemsDoesNotKeepSwipeViewAlive [122 ms]
  Error Message:
   Assert.All() Failure: 20 out of 20 items in the collection did not pass.
[0]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[1]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[2]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[3]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[4]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[5]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[6]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[7]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[8]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[9]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[10]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[11]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[12]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[13]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[14]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[15]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[16]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[17]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[18]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[19]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.CachedSwipeItemsDoesNotKeepSwipeViewAlive() in /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs:line 595
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed TestBottomItems [< 1 ms]
  Passed TestDefaultSwipeItems [7 ms]
[xUnit.net 00:00:01.79]     ReplacingCachedSwipeItemsReleasesPreviousOwnerReference [FAIL]
[xUnit.net 00:00:01.79]       Replaced SwipeView was kept alive by its previously-assigned cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.79]       Stack Trace:
[xUnit.net 00:00:01.79]         /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs(637,0): at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.ReplacingCachedSwipeItemsReleasesPreviousOwnerReference()
[xUnit.net 00:00:01.79]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:01.79]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed SwipeViewResubscribesToScrollParentAfterRemovalAndReaddition [1 ms]
  Passed TestConstructor [3 ms]
  Passed TestSwipeViewBindingContextChangedEvent [< 1 ms]
  Passed TestProgrammaticallyClose [2 ms]
  Passed TestSwipeItemsSwipeBehaviorOnInvoked [< 1 ms]
  Passed SwipeItemsRemainInLogicalTreeWhenContentIsSet [31 ms]
  Failed ReplacingCachedSwipeItemsReleasesPreviousOwnerReference [89 ms]
  Error Message:
   Replaced SwipeView was kept alive by its previously-assigned cached SwipeItems — issue #35481 regression.
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.ReplacingCachedSwipeItemsReleasesPreviousOwnerReference() in /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs:line 637
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed TestContentBindingContextChangedEvent [< 1 ms]
  Passed TestTemplatedContentBindingContextChangedEvent [3 ms]
[xUnit.net 00:00:01.80]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestProgrammaticallyOpen [< 1 ms]
  Passed ClearRemovesLogicalChildren [< 1 ms]
  Passed TestLeftItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToNewSwipeItems [< 1 ms]
  Passed TestSwipeItemsExecuteMode [< 1 ms]
  Passed TestTopItems [< 1 ms]
  Passed SwipeViewRediscoversScrollParentWhenTemplateRootIsReparented [< 1 ms]
  Passed SwipeViewFindsScrollParentAfterTemplateParentConnected [< 1 ms]

Total tests: 26
     Passed: 24
     Failed: 2
Test Run Failed.
 Total time: 2.2943 Seconds

🟢 With fix — 🧪 SwipeViewTests: PASS ✅ · 83s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  TestUtils -> /home/vsts/work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.15]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:01.37]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:01.39]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestSwipeItemView [45 ms]
  Passed TestContentBindingContextPropagatesToPassedInSwipeItem [13 ms]
  Passed BindingContextTransfersToNewSetOfSwipeItems [5 ms]
  Passed TestRightItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToAddedSwipeItems [< 1 ms]
  Passed SwipeViewFindsScrollParentDirectlyWhenTreeIsConnected [3 ms]
  Passed CachedSwipeItemsDoesNotKeepSwipeViewAlive [91 ms]
  Passed TestBottomItems [< 1 ms]
  Passed TestDefaultSwipeItems [4 ms]
  Passed SwipeViewResubscribesToScrollParentAfterRemovalAndReaddition [1 ms]
  Passed TestConstructor [1 ms]
  Passed TestSwipeViewBindingContextChangedEvent [< 1 ms]
  Passed TestProgrammaticallyClose [2 ms]
  Passed TestSwipeItemsSwipeBehaviorOnInvoked [< 1 ms]
  Passed SwipeItemsRemainInLogicalTreeWhenContentIsSet [27 ms]
  Passed ReplacingCachedSwipeItemsReleasesPreviousOwnerReference [81 ms]
  Passed TestContentBindingContextChangedEvent [< 1 ms]
  Passed TestTemplatedContentBindingContextChangedEvent [1 ms]
[xUnit.net 00:00:01.73]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestProgrammaticallyOpen [< 1 ms]
  Passed ClearRemovesLogicalChildren [< 1 ms]
  Passed TestLeftItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToNewSwipeItems [< 1 ms]
  Passed TestSwipeItemsExecuteMode [< 1 ms]
  Passed TestTopItems [< 1 ms]
  Passed SwipeViewRediscoversScrollParentWhenTemplateRootIsReparented [< 1 ms]
  Passed SwipeViewFindsScrollParentAfterTemplateParentConnected [< 1 ms]

Test Run Successful.
Total tests: 26
     Passed: 26
 Total time: 2.2228 Seconds

📁 Fix files reverted (2 files)

• src/Controls/src/Core/SwipeView/SwipeItems.cs
• src/Controls/src/Core/SwipeView/SwipeView.cs

---

🧪 UI Tests — SwipeView

Detected UI test categories: SwipeView

🧪 UI Test Execution Results

⏭️ SKIPPED — 0 passed, 0 failed, 1 skipped (platform: android)

Category	Result	Tests	Duration	Notes
SwipeView	⏭️ SKIPPED	—	0.6s	Runner threw an exception

Failures here are informational only — they do not block the gate or affect try-fix candidate scoring.

---

🔍 Pre-Flight — Context & Validation

Issue: #35481 — SwipeView leaks when SwipeItems are reused or replaced
PR: #35539 — Fix SwipeView memory leak when SwipeItems are reused or replaced
Platforms Affected: Android, iOS, MacCatalyst (cross-platform Controls layer)
Files Changed: 2 implementation (SwipeItems.cs, SwipeView.cs), 1 test (SwipeViewTests.cs)

Key Findings

• Root cause: SwipeView.OnSwipeItemsChanged previously created local-function delegates for CollectionChanged / PropertyChanged each time the callback ran. Each += created a fresh delegate instance, so a later -= could not match, and old SwipeItems (when cached/shared) kept holding references to the SwipeView via those subscriptions.
• Secondary path: OnChildAdded/OnChildRemoved also subscribed to child.PropertyChanged for SwipeItems logical children; unsubscribe only happened through RemoveLogicalChild, which never runs if SwipeItems is cached externally and reused.
• PR's fix (approach: parent-driven notification / ownership inversion):
  • SwipeItems overrides nothing; instead its ctor += OnSwipeItemsChanged (already there) plus a new PropertyChanged += OnSelfPropertyChanged self-subscription (no leak — target is self).
  • On change, SwipeItems.NotifyOwner() walks Element.Parent to the owning SwipeView and calls Handler?.UpdateValue(...) for whichever side this collection occupies.
  • SwipeView.OnSwipeItemsChanged no longer subscribes to events; it only AddLogicalChilds the new items (which reassigns Element.Parent).
  • SwipeView.OnChildAdded/OnChildRemoved skip PropertyChanged subscription when child is SwipeItems.
• Regression tests (already added in PR):
  • CachedSwipeItemsDoesNotKeepSwipeViewAlive — 20 SwipeViews share a cached SwipeItems, then each reassigns RightItems to a fresh instance; after GC, all 20 must be collected.
  • ReplacingCachedSwipeItemsReleasesPreviousOwnerReference — single SwipeView assigns cached then replaces; after GC, SwipeView must be collected.

Code Review Summary

Verdict: SKIPPED (independence-first sub-agent not invoked — task focus is alternative-fix generation; gate already PASSED per task brief)
Confidence: N/A
Errors: 0 | Warnings: 0 | Suggestions: 0

Observations on the PR fix worth probing in alternatives:

• ⚠️ NotifyOwner fires on any PropertyChanged of SwipeItems (including Parent, BindingContext, Style, etc.), not just the swipe-relevant property Mode. Previously the subscription was filtered indirectly because only changes flowing through SwipeItems would fire it; now every Element-level property change triggers a Handler refresh. Potential perf regression.
• ⚠️ OnSelfPropertyChanged is added unconditionally in ctor and never removed; harmless for GC (self-target) but a redundant subscription path vs simply overriding OnPropertyChanged.
• ⚠️ Skipping child.PropertyChanged += OnPropertyChanged for SwipeItems in OnChildAdded is safe because SwipeItems no longer needs IsEnabled/Margin change forwarding — but worth verifying no behavior regression for the very rare case of SwipeItems-level IsEnabled changes.
• 💡 An alternative could use stored-field delegates (single delegate per SwipeView, properly unsubscribed) which is simpler and addresses the "delegate identity" root cause directly — though it would still leak when the consumer never reassigns/disposes the SwipeView side.
• 💡 Another alternative: weak event subscription via WeakReference<SwipeView> side-car, which is the most robust pattern for "cached subject, ephemeral observer".

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #35539	Parent-driven notification: SwipeItems walks Element.Parent to notify its owning SwipeView	✅ PASSED (gate)	SwipeItems.cs, SwipeView.cs	Original PR

---

🔧 Fix — Analysis & Comparison

Try-Fix Aggregate — PR #35539

Issue: #35481 — SwipeView leaks when SwipeItems are reused or replaced.
PR fix approach: Ownership inversion — SwipeItems self-subscribes to its own events and walks Element.Parent to notify the owning SwipeView.
Test target: src/Controls/tests/Core.UnitTests/SwipeViewTests.cs (Core.UnitTests, xUnit).
Gate: ✅ Already PASSED (per task brief).
Platform tested locally: Linux dev box, net10.0 Controls.Core.UnitTests (Android-style CI tests would target the same xUnit assembly).

Candidate Summary

#	Approach	Test Result	Files Changed	Diff size	Notes
PR	Parent-driven notification (SwipeItems walks Element.Parent)	✅ PASSED (gate)	SwipeView.cs, SwipeItems.cs	+168 / −33	Original PR
1	Handler-scoped stored-field delegates (SwipeView subscribes only while handler attached, via HandlerChanging/HandlerChanged events on this)	✅ PASSED — 26/26 SwipeView tests, 0 regressions	SwipeView.cs only (SwipeItems reverted to pre-PR)	194 lines	Smaller surface area, no SwipeItems behavior change visible externally
2	Weak-reference side-car listener (private nested class with WeakReference<SwipeView>, one per side)	✅ PASSED — 26/26 SwipeView tests, 5556/5556 full Core.UnitTests, 0 regressions	SwipeView.cs (+nested class), revert SwipeItems.cs	208 lines	Most defensively correct — correctness derives from GC reachability graph

Iteration log

Iteration 1 — Generated Candidate A (handler-scoped fields)

• Expert reviewer (maui-expert-reviewer agent) proposed two alternative approaches in a single round, knowing the PR's approach to avoid duplication.
• Applied Candidate A to working tree (SwipeView.cs + SwipeItems.cs revert).
• First build failed with RS0016 — new protected override OnHandlerChanging/OnHandlerChanged added to public API. Adapted: swapped overrides for event subscription (HandlerChanging += handler / HandlerChanged += handler) in the constructor, targeting this (no leak). This actually improved the design: less ceremony, no public API change.
• Rebuild & test: Build succeeded. SwipeView tests: 26/26 passed.

Iteration 2 — Generated Candidate B (weak side-car)

• Applied Candidate B (revert SwipeItems + nested SwipeItemsListener class with WeakReference<SwipeView>).
• Note on adaptation: Original expert proposal used a ref SwipeItemsListener? slot = ref ... ternary, which is unusual C# and fragile. Replaced with explicit per-side if/else dispatch using ReferenceEquals(newValue, swipeView.LeftItems) etc. — functionally identical, more readable.
• Build & test: Build succeeded. SwipeView tests: 26/26 passed. Ran the full Controls.Core.UnitTests sweep as the broader regression check: 5556 passed, 0 failed, 30 skipped.

Stop condition

• Both candidates pass the gate criteria AND the broader unit-test suite.
• Both explore meaningfully different approaches from the PR (one keeps SV-side ownership with handler-scoped subscription; the other uses a textbook weak-event pattern).
• Further variations (e.g., ConditionalWeakTable<SwipeItems, List<SwipeView>>, source-generated weak event) would be trivial variations of Candidate 2 with no architectural change. Stopping after 2 candidates.

Recommendation

All three approaches pass the gate. Ranked by mergeability for this specific bug:

1. PR (as-is) — Smallest functional change, most centralized, idiomatic to MAUI Element model. ⚠️ Minor concern: OnSelfPropertyChanged fires Handler.UpdateValue(...) on every Element property change (including Parent, BindingContext, Style), not just SwipeItems-meaningful ones.
2. Candidate 1 — More conventional MAUI subscription-lifetime pattern (subscribe while handler attached). Single-file change. Avoids the PR's PropertyChanged storm.
3. Candidate 2 — Most robust to any future lifetime change (correctness derives from GC graph, not from event ordering). Trade: ~100 lines of new code in SwipeView.cs.

For this PR, Candidate 1 is the strongest alternative: it fixes the same defect, has a narrower blast radius (one file), keeps SwipeItems semantics identical to pre-PR, and avoids the perf concern of indiscriminate Handler.UpdateValue calls on every Element-property change.

If the maintainers want maximum safety against future memory-leak regressions in this area (e.g., to harden against any other lifetime pattern), Candidate 2 is the recommended choice — at the cost of slightly more code.

Files

• try-fix-1/content.md — Candidate 1 detail
• try-fix-2/content.md — Candidate 2 detail
• Diffs available at /tmp/candidate-a.diff and /tmp/candidate-b.diff for the duration of this session.

---

📋 Report — Final Recommendation

Comparative Report — PR #35539

Issue: #35481 — SwipeView leaks when SwipeItems are reused or replaced.
Platform tested: android (xUnit Core.UnitTests assembly is platform-agnostic; CI runs identical assembly on Android pipelines).
Gate: ✅ Already PASSED for PR (tests fail without fix, pass with fix).

Candidates evaluated

#	Candidate	Approach	Test Result	Files Changed	Diff Size
1	pr	Parent-driven notification — SwipeItems self-subscribes to its own PropertyChanged, walks Element.Parent (a WeakReference<Element> internally) to notify the owning SwipeView's handler. SwipeView.OnChildAdded skips PropertyChanged subscription for SwipeItems children.	✅ PASSED (gate)	SwipeItems.cs, SwipeView.cs	+168 / −33
2	pr-plus-reviewer	PR fix + property-name filter in OnPropertyChanged override (only Mode / SwipeBehaviorOnInvoked trigger NotifyOwner) + else if chain in NotifyOwner.	✅ PASSED — 26/26 SwipeView tests	SwipeItems.cs + 3× PublicAPI files	+30 / −15 vs PR
3	try-fix-1	Handler-scoped stored-field delegates — SwipeView subscribes only while platform handler is attached (HandlerChanging/HandlerChanged events on this). SwipeItems.cs reverted to pre-PR.	✅ PASSED — 26/26 SwipeView tests, 0 regressions	SwipeView.cs only	194 lines
4	try-fix-2	Weak-reference side-car listener — private nested class with WeakReference<SwipeView>, one per side. SwipeItems.cs reverted to pre-PR.	✅ PASSED — 26/26 SwipeView tests, 5556/5556 full Core.UnitTests, 0 regressions	SwipeView.cs (+nested class)	208 lines

All four candidates pass the regression tests. No candidate is penalized for test failures.

Comparative dimensions

Correctness

• All four are correct for the documented scenarios.
• try-fix-2 (weak ref) has the strongest theoretical correctness — proof is the GC reachability graph itself.
• pr / pr-plus-reviewer rely on AddLogicalChild always reassigning Element.Parent (true today; an Element invariant).
• try-fix-1 relies on the platform handler always being attached when on-screen and detached when off-screen (true today; a handler lifecycle invariant).

Blast radius (smallest = best)

1. pr-plus-reviewer — Refines one file (+ Public API entries). Same conceptual model as PR.
2. pr — Two files, both narrowly scoped.
3. try-fix-1 — One file but adds 2 fields, 6 helper methods, two new event subscriptions in ctor.
4. try-fix-2 — One file but introduces a 100-line nested class.

Idiomatic MAUI style

• pr-plus-reviewer is the most idiomatic — overrides OnPropertyChanged(string) (the standard MAUI hook) and filters by PropertyName. Matches the pattern used in Shape.OnPropertyChanged and others.
• pr uses constructor-level event subscription (works, but less idiomatic for self-targeted observation).
• try-fix-1 uses handler-attach/detach for subscription lifetime — a recognised MAUI pattern but not commonly applied for collection observation.
• try-fix-2 uses an explicit weak-event side-car — not a pattern previously used in MAUI Controls.

Performance / allocations

• pr — adds a self-PropertyChanged subscription that fires Handler.UpdateValue on every Element/BindableObject property change (Parent, BindingContext, Style, etc.). Measurable noise in CollectionView recycling scenarios.
• pr-plus-reviewer — eliminates that storm via property-name filter. Best of the four.
• try-fix-1 — 2 delegate field allocations per SwipeView; subscription only active while handler attached.
• try-fix-2 — 4 listener allocations (lazy, one per side); per-event WeakReference.TryGetTarget call (cheap but non-zero).

Robustness to future lifetime changes

• try-fix-2 > try-fix-1 ≈ pr-plus-reviewer ≈ pr.
• try-fix-2 is uniquely self-healing: a missed Detach() still cleans up on the next event.

Public API surface

• pr / try-fix-1 / try-fix-2 — no public API change.
• pr-plus-reviewer — adds protected override OnPropertyChanged (tracked in PublicAPI.Unshipped.txt because the class is non-sealed). Trivial entry, no behavior change for consumers.

Ranking

1. pr-plus-reviewer 🏆 — Preserves the PR author's elegant ownership-inversion design while fixing the one real concern (property-change storm). Smallest delta from PR. Most idiomatic MAUI code (uses standard OnPropertyChanged override + name filter). Passes all tests. Easiest for the PR author to accept as inline-comment feedback rather than as a rewrite.
2. pr — Same design as the winner; only loses on the redundant Handler.UpdateValue on every base-Element property change. Fully mergeable as-is.
3. try-fix-1 — Strong alternative that avoids the PropertyChanged storm by using handler-lifetime subscription. Single-file change. Reverts SwipeItems.cs entirely, which is preferable for separation of concerns but is a larger conceptual departure from the PR author's design.
4. try-fix-2 — Most robust defensively (weak reference), but adds the most code and a new pattern not present elsewhere in MAUI Controls. Best long-term insurance against analogous future bugs, but overkill for the specific defect being fixed.

Winner

pr-plus-reviewer — recommend the PR author apply the inline-finding refactor (OnPropertyChanged override + property-name filter + else if in NotifyOwner) and merge.

If maintainers want zero churn from the PR as-submitted, pr is fully acceptable to merge directly; the perf concern is minor and can be addressed in a follow-up.

---

[Vignesh-SF3580]

🤖 AI Summary

👋 @Vignesh-SF3580 — new AI review results are available. Please review the latest session below.

📊 Review Session — bead39d · Update PropertyChanged. · 2026-05-20 20:38 UTC

🚦 Gate — Test Before & After Fix

Gate Result: ✅ PASSED

Platform: ANDROID · Base: main · Merge base: 59797ba3

Test Without Fix (expect FAIL) With Fix (expect PASS)
🧪 SwipeViewTests SwipeViewTests ✅ FAIL — 108s ✅ PASS — 83s
🔴 Without fix — 🧪 SwipeViewTests: FAIL ✅ · 108s
(truncated to last 15,000 chars)

was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [6]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [7]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [8]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [9]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [10]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [11]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [12]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [13]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [14]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [15]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [16]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [17]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [18]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.65]       [19]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
[xUnit.net 00:00:01.65]             Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.66]       Stack Trace:
[xUnit.net 00:00:01.66]         /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs(595,0): at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.CachedSwipeItemsDoesNotKeepSwipeViewAlive()
[xUnit.net 00:00:01.66]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:01.66]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed TestSwipeItemView [46 ms]
  Passed TestContentBindingContextPropagatesToPassedInSwipeItem [9 ms]
  Passed BindingContextTransfersToNewSetOfSwipeItems [5 ms]
  Passed TestRightItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToAddedSwipeItems [< 1 ms]
  Passed SwipeViewFindsScrollParentDirectlyWhenTreeIsConnected [3 ms]
  Failed CachedSwipeItemsDoesNotKeepSwipeViewAlive [122 ms]
  Error Message:
   Assert.All() Failure: 20 out of 20 items in the collection did not pass.
[0]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[1]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[2]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[3]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[4]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[5]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[6]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[7]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[8]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[9]:  Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[10]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[11]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[12]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[13]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[14]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[15]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[16]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[17]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[18]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
[19]: Item:  WeakReference { IsAlive = True, Target = SwipeView { AnchorX = 0.5, AnchorY = 0.5, AutomationId = null, Background = ImmutableBrush { ··· }, BackgroundColor = null, ··· }, TrackResurrection = False }
      Error: SwipeView was kept alive by the cached SwipeItems — issue #35481 regression.
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.CachedSwipeItemsDoesNotKeepSwipeViewAlive() in /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs:line 595
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed TestBottomItems [< 1 ms]
  Passed TestDefaultSwipeItems [7 ms]
[xUnit.net 00:00:01.79]     ReplacingCachedSwipeItemsReleasesPreviousOwnerReference [FAIL]
[xUnit.net 00:00:01.79]       Replaced SwipeView was kept alive by its previously-assigned cached SwipeItems — issue #35481 regression.
[xUnit.net 00:00:01.79]       Stack Trace:
[xUnit.net 00:00:01.79]         /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs(637,0): at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.ReplacingCachedSwipeItemsReleasesPreviousOwnerReference()
[xUnit.net 00:00:01.79]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:01.79]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed SwipeViewResubscribesToScrollParentAfterRemovalAndReaddition [1 ms]
  Passed TestConstructor [3 ms]
  Passed TestSwipeViewBindingContextChangedEvent [< 1 ms]
  Passed TestProgrammaticallyClose [2 ms]
  Passed TestSwipeItemsSwipeBehaviorOnInvoked [< 1 ms]
  Passed SwipeItemsRemainInLogicalTreeWhenContentIsSet [31 ms]
  Failed ReplacingCachedSwipeItemsReleasesPreviousOwnerReference [89 ms]
  Error Message:
   Replaced SwipeView was kept alive by its previously-assigned cached SwipeItems — issue #35481 regression.
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.ReplacingCachedSwipeItemsReleasesPreviousOwnerReference() in /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs:line 637
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed TestContentBindingContextChangedEvent [< 1 ms]
  Passed TestTemplatedContentBindingContextChangedEvent [3 ms]
[xUnit.net 00:00:01.80]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestProgrammaticallyOpen [< 1 ms]
  Passed ClearRemovesLogicalChildren [< 1 ms]
  Passed TestLeftItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToNewSwipeItems [< 1 ms]
  Passed TestSwipeItemsExecuteMode [< 1 ms]
  Passed TestTopItems [< 1 ms]
  Passed SwipeViewRediscoversScrollParentWhenTemplateRootIsReparented [< 1 ms]
  Passed SwipeViewFindsScrollParentAfterTemplateParentConnected [< 1 ms]

Total tests: 26
     Passed: 24
     Failed: 2
Test Run Failed.
 Total time: 2.2943 Seconds

🟢 With fix — 🧪 SwipeViewTests: PASS ✅ · 83s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14150668
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  TestUtils -> /home/vsts/work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.15]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:01.37]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:01.39]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestSwipeItemView [45 ms]
  Passed TestContentBindingContextPropagatesToPassedInSwipeItem [13 ms]
  Passed BindingContextTransfersToNewSetOfSwipeItems [5 ms]
  Passed TestRightItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToAddedSwipeItems [< 1 ms]
  Passed SwipeViewFindsScrollParentDirectlyWhenTreeIsConnected [3 ms]
  Passed CachedSwipeItemsDoesNotKeepSwipeViewAlive [91 ms]
  Passed TestBottomItems [< 1 ms]
  Passed TestDefaultSwipeItems [4 ms]
  Passed SwipeViewResubscribesToScrollParentAfterRemovalAndReaddition [1 ms]
  Passed TestConstructor [1 ms]
  Passed TestSwipeViewBindingContextChangedEvent [< 1 ms]
  Passed TestProgrammaticallyClose [2 ms]
  Passed TestSwipeItemsSwipeBehaviorOnInvoked [< 1 ms]
  Passed SwipeItemsRemainInLogicalTreeWhenContentIsSet [27 ms]
  Passed ReplacingCachedSwipeItemsReleasesPreviousOwnerReference [81 ms]
  Passed TestContentBindingContextChangedEvent [< 1 ms]
  Passed TestTemplatedContentBindingContextChangedEvent [1 ms]
[xUnit.net 00:00:01.73]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestProgrammaticallyOpen [< 1 ms]
  Passed ClearRemovesLogicalChildren [< 1 ms]
  Passed TestLeftItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToNewSwipeItems [< 1 ms]
  Passed TestSwipeItemsExecuteMode [< 1 ms]
  Passed TestTopItems [< 1 ms]
  Passed SwipeViewRediscoversScrollParentWhenTemplateRootIsReparented [< 1 ms]
  Passed SwipeViewFindsScrollParentAfterTemplateParentConnected [< 1 ms]

Test Run Successful.
Total tests: 26
     Passed: 26
 Total time: 2.2228 Seconds

📁 Fix files reverted (2 files)

• src/Controls/src/Core/SwipeView/SwipeItems.cs
• src/Controls/src/Core/SwipeView/SwipeView.cs

🧪 UI Tests — SwipeView

Detected UI test categories: SwipeView

🧪 UI Test Execution Results

⏭️ SKIPPED — 0 passed, 0 failed, 1 skipped (platform: android)

Category Result Tests Duration Notes
SwipeView ⏭️ SKIPPED — 0.6s Runner threw an exception
Failures here are informational only — they do not block the gate or affect try-fix candidate scoring.

🔍 Pre-Flight — Context & Validation

Issue: #35481 — SwipeView leaks when SwipeItems are reused or replaced PR: #35539 — Fix SwipeView memory leak when SwipeItems are reused or replaced Platforms Affected: Android, iOS, MacCatalyst (cross-platform Controls layer) Files Changed: 2 implementation (SwipeItems.cs, SwipeView.cs), 1 test (SwipeViewTests.cs)

Key Findings

• Root cause: SwipeView.OnSwipeItemsChanged previously created local-function delegates for CollectionChanged / PropertyChanged each time the callback ran. Each += created a fresh delegate instance, so a later -= could not match, and old SwipeItems (when cached/shared) kept holding references to the SwipeView via those subscriptions.

• Secondary path: OnChildAdded/OnChildRemoved also subscribed to child.PropertyChanged for SwipeItems logical children; unsubscribe only happened through RemoveLogicalChild, which never runs if SwipeItems is cached externally and reused.

• PR's fix (approach: parent-driven notification / ownership inversion):

  • SwipeItems overrides nothing; instead its ctor += OnSwipeItemsChanged (already there) plus a new PropertyChanged += OnSelfPropertyChanged self-subscription (no leak — target is self).
  • On change, SwipeItems.NotifyOwner() walks Element.Parent to the owning SwipeView and calls Handler?.UpdateValue(...) for whichever side this collection occupies.
  • SwipeView.OnSwipeItemsChanged no longer subscribes to events; it only AddLogicalChilds the new items (which reassigns Element.Parent).
  • SwipeView.OnChildAdded/OnChildRemoved skip PropertyChanged subscription when child is SwipeItems.

• Regression tests (already added in PR):

  • CachedSwipeItemsDoesNotKeepSwipeViewAlive — 20 SwipeViews share a cached SwipeItems, then each reassigns RightItems to a fresh instance; after GC, all 20 must be collected.
  • ReplacingCachedSwipeItemsReleasesPreviousOwnerReference — single SwipeView assigns cached then replaces; after GC, SwipeView must be collected.

Code Review Summary

Verdict: SKIPPED (independence-first sub-agent not invoked — task focus is alternative-fix generation; gate already PASSED per task brief) Confidence: N/A Errors: 0 | Warnings: 0 | Suggestions: 0

Observations on the PR fix worth probing in alternatives:

• ⚠️ NotifyOwner fires on any PropertyChanged of SwipeItems (including Parent, BindingContext, Style, etc.), not just the swipe-relevant property Mode. Previously the subscription was filtered indirectly because only changes flowing through SwipeItems would fire it; now every Element-level property change triggers a Handler refresh. Potential perf regression.
• ⚠️ OnSelfPropertyChanged is added unconditionally in ctor and never removed; harmless for GC (self-target) but a redundant subscription path vs simply overriding OnPropertyChanged.
• ⚠️ Skipping child.PropertyChanged += OnPropertyChanged for SwipeItems in OnChildAdded is safe because SwipeItems no longer needs IsEnabled/Margin change forwarding — but worth verifying no behavior regression for the very rare case of SwipeItems-level IsEnabled changes.
• 💡 An alternative could use stored-field delegates (single delegate per SwipeView, properly unsubscribed) which is simpler and addresses the "delegate identity" root cause directly — though it would still leak when the consumer never reassigns/disposes the SwipeView side.
• 💡 Another alternative: weak event subscription via WeakReference<SwipeView> side-car, which is the most robust pattern for "cached subject, ephemeral observer".

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #35539 Parent-driven notification: SwipeItems walks Element.Parent to notify its owning SwipeView ✅ PASSED (gate) SwipeItems.cs, SwipeView.cs Original PR
🔧 Fix — Analysis & Comparison

Try-Fix Aggregate — PR #35539

Issue: #35481 — SwipeView leaks when SwipeItems are reused or replaced. PR fix approach: Ownership inversion — SwipeItems self-subscribes to its own events and walks Element.Parent to notify the owning SwipeView. Test target: src/Controls/tests/Core.UnitTests/SwipeViewTests.cs (Core.UnitTests, xUnit). Gate: ✅ Already PASSED (per task brief). Platform tested locally: Linux dev box, net10.0 Controls.Core.UnitTests (Android-style CI tests would target the same xUnit assembly).

Candidate Summary

Approach Test Result Files Changed Diff size Notes

PR Parent-driven notification (SwipeItems walks Element.Parent) ✅ PASSED (gate) SwipeView.cs, SwipeItems.cs +168 / −33 Original PR
1 Handler-scoped stored-field delegates (SwipeView subscribes only while handler attached, via HandlerChanging/HandlerChanged events on this) ✅ PASSED — 26/26 SwipeView tests, 0 regressions SwipeView.cs only (SwipeItems reverted to pre-PR) 194 lines Smaller surface area, no SwipeItems behavior change visible externally
2 Weak-reference side-car listener (private nested class with WeakReference<SwipeView>, one per side) ✅ PASSED — 26/26 SwipeView tests, 5556/5556 full Core.UnitTests, 0 regressions SwipeView.cs (+nested class), revert SwipeItems.cs 208 lines Most defensively correct — correctness derives from GC reachability graph

Iteration log

Iteration 1 — Generated Candidate A (handler-scoped fields)

• Expert reviewer (maui-expert-reviewer agent) proposed two alternative approaches in a single round, knowing the PR's approach to avoid duplication.
• Applied Candidate A to working tree (SwipeView.cs + SwipeItems.cs revert).
• First build failed with RS0016 — new protected override OnHandlerChanging/OnHandlerChanged added to public API. Adapted: swapped overrides for event subscription (HandlerChanging += handler / HandlerChanged += handler) in the constructor, targeting this (no leak). This actually improved the design: less ceremony, no public API change.
• Rebuild & test: Build succeeded. SwipeView tests: 26/26 passed.

Iteration 2 — Generated Candidate B (weak side-car)

• Applied Candidate B (revert SwipeItems + nested SwipeItemsListener class with WeakReference<SwipeView>).
• Note on adaptation: Original expert proposal used a ref SwipeItemsListener? slot = ref ... ternary, which is unusual C# and fragile. Replaced with explicit per-side if/else dispatch using ReferenceEquals(newValue, swipeView.LeftItems) etc. — functionally identical, more readable.
• Build & test: Build succeeded. SwipeView tests: 26/26 passed. Ran the full Controls.Core.UnitTests sweep as the broader regression check: 5556 passed, 0 failed, 30 skipped.

Stop condition

• Both candidates pass the gate criteria AND the broader unit-test suite.
• Both explore meaningfully different approaches from the PR (one keeps SV-side ownership with handler-scoped subscription; the other uses a textbook weak-event pattern).
• Further variations (e.g., ConditionalWeakTable<SwipeItems, List<SwipeView>>, source-generated weak event) would be trivial variations of Candidate 2 with no architectural change. Stopping after 2 candidates.

Recommendation

All three approaches pass the gate. Ranked by mergeability for this specific bug:

1. PR (as-is) — Smallest functional change, most centralized, idiomatic to MAUI Element model. ⚠️ Minor concern: OnSelfPropertyChanged fires Handler.UpdateValue(...) on every Element property change (including Parent, BindingContext, Style), not just SwipeItems-meaningful ones.
2. Candidate 1 — More conventional MAUI subscription-lifetime pattern (subscribe while handler attached). Single-file change. Avoids the PR's PropertyChanged storm.
3. Candidate 2 — Most robust to any future lifetime change (correctness derives from GC graph, not from event ordering). Trade: ~100 lines of new code in SwipeView.cs.

For this PR, Candidate 1 is the strongest alternative: it fixes the same defect, has a narrower blast radius (one file), keeps SwipeItems semantics identical to pre-PR, and avoids the perf concern of indiscriminate Handler.UpdateValue calls on every Element-property change.

If the maintainers want maximum safety against future memory-leak regressions in this area (e.g., to harden against any other lifetime pattern), Candidate 2 is the recommended choice — at the cost of slightly more code.

Files

• try-fix-1/content.md — Candidate 1 detail
• try-fix-2/content.md — Candidate 2 detail
• Diffs available at /tmp/candidate-a.diff and /tmp/candidate-b.diff for the duration of this session.

📋 Report — Final Recommendation

Comparative Report — PR #35539

Issue: #35481 — SwipeView leaks when SwipeItems are reused or replaced. Platform tested: android (xUnit Core.UnitTests assembly is platform-agnostic; CI runs identical assembly on Android pipelines). Gate: ✅ Already PASSED for PR (tests fail without fix, pass with fix).

Candidates evaluated

Candidate Approach Test Result Files Changed Diff Size

1 pr Parent-driven notification — SwipeItems self-subscribes to its own PropertyChanged, walks Element.Parent (a WeakReference<Element> internally) to notify the owning SwipeView's handler. SwipeView.OnChildAdded skips PropertyChanged subscription for SwipeItems children. ✅ PASSED (gate) SwipeItems.cs, SwipeView.cs +168 / −33
2 pr-plus-reviewer PR fix + property-name filter in OnPropertyChanged override (only Mode / SwipeBehaviorOnInvoked trigger NotifyOwner) + else if chain in NotifyOwner. ✅ PASSED — 26/26 SwipeView tests SwipeItems.cs + 3× PublicAPI files +30 / −15 vs PR
3 try-fix-1 Handler-scoped stored-field delegates — SwipeView subscribes only while platform handler is attached (HandlerChanging/HandlerChanged events on this). SwipeItems.cs reverted to pre-PR. ✅ PASSED — 26/26 SwipeView tests, 0 regressions SwipeView.cs only 194 lines
4 try-fix-2 Weak-reference side-car listener — private nested class with WeakReference<SwipeView>, one per side. SwipeItems.cs reverted to pre-PR. ✅ PASSED — 26/26 SwipeView tests, 5556/5556 full Core.UnitTests, 0 regressions SwipeView.cs (+nested class) 208 lines
All four candidates pass the regression tests. No candidate is penalized for test failures.

Comparative dimensions

Correctness

• All four are correct for the documented scenarios.
• try-fix-2 (weak ref) has the strongest theoretical correctness — proof is the GC reachability graph itself.
• pr / pr-plus-reviewer rely on AddLogicalChild always reassigning Element.Parent (true today; an Element invariant).
• try-fix-1 relies on the platform handler always being attached when on-screen and detached when off-screen (true today; a handler lifecycle invariant).

Blast radius (smallest = best)

1. pr-plus-reviewer — Refines one file (+ Public API entries). Same conceptual model as PR.
2. pr — Two files, both narrowly scoped.
3. try-fix-1 — One file but adds 2 fields, 6 helper methods, two new event subscriptions in ctor.
4. try-fix-2 — One file but introduces a 100-line nested class.

Idiomatic MAUI style

• pr-plus-reviewer is the most idiomatic — overrides OnPropertyChanged(string) (the standard MAUI hook) and filters by PropertyName. Matches the pattern used in Shape.OnPropertyChanged and others.
• pr uses constructor-level event subscription (works, but less idiomatic for self-targeted observation).
• try-fix-1 uses handler-attach/detach for subscription lifetime — a recognised MAUI pattern but not commonly applied for collection observation.
• try-fix-2 uses an explicit weak-event side-car — not a pattern previously used in MAUI Controls.

Performance / allocations

• pr — adds a self-PropertyChanged subscription that fires Handler.UpdateValue on every Element/BindableObject property change (Parent, BindingContext, Style, etc.). Measurable noise in CollectionView recycling scenarios.
• pr-plus-reviewer — eliminates that storm via property-name filter. Best of the four.
• try-fix-1 — 2 delegate field allocations per SwipeView; subscription only active while handler attached.
• try-fix-2 — 4 listener allocations (lazy, one per side); per-event WeakReference.TryGetTarget call (cheap but non-zero).

Robustness to future lifetime changes

• try-fix-2 > try-fix-1 ≈ pr-plus-reviewer ≈ pr.
• try-fix-2 is uniquely self-healing: a missed Detach() still cleans up on the next event.

Public API surface

• pr / try-fix-1 / try-fix-2 — no public API change.
• pr-plus-reviewer — adds protected override OnPropertyChanged (tracked in PublicAPI.Unshipped.txt because the class is non-sealed). Trivial entry, no behavior change for consumers.

Ranking

1. pr-plus-reviewer 🏆 — Preserves the PR author's elegant ownership-inversion design while fixing the one real concern (property-change storm). Smallest delta from PR. Most idiomatic MAUI code (uses standard OnPropertyChanged override + name filter). Passes all tests. Easiest for the PR author to accept as inline-comment feedback rather than as a rewrite.
2. pr — Same design as the winner; only loses on the redundant Handler.UpdateValue on every base-Element property change. Fully mergeable as-is.
3. try-fix-1 — Strong alternative that avoids the PropertyChanged storm by using handler-lifetime subscription. Single-file change. Reverts SwipeItems.cs entirely, which is preferable for separation of concerns but is a larger conceptual departure from the PR author's design.
4. try-fix-2 — Most robust defensively (weak reference), but adds the most code and a new pattern not present elsewhere in MAUI Controls. Best long-term insurance against analogous future bugs, but overkill for the specific defect being fixed.

Winner

pr-plus-reviewer — recommend the PR author apply the inline-finding refactor (OnPropertyChanged override + property-name filter + else if in NotifyOwner) and merge.

If maintainers want zero churn from the PR as-submitted, pr is fully acceptable to merge directly; the perf concern is minor and can be addressed in a follow-up.

• Replaced the constructor-level PropertyChanged self-subscription with a protected override OnPropertyChanged(...), following the standard MAUI pattern similar to Shape.OnPropertyChanged.
• Added a property-name filter for Mode and SwipeBehaviorOnInvoked to avoid unnecessary Handler.UpdateValue calls for unrelated property changes.
• Updated NotifyOwner to use an else if chain since only one swipe direction can match at a time.
• Added the 7 ~override entries to PublicAPI.Unshipped.txt.

[kubaflo]

/review -b feature/regression-check

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sheiksyedm]

/azp maui-pr-devicetests

[azure-pipelines]

Command 'maui-pr-devicetests' is not supported by Azure Pipelines.

Supported commands

• help:
• Get descriptions, examples and documentation about supported commands
• Example: help "command_name"
• list:
• List all pipelines for this repository using a comment.
• Example: "list"
• run:
• Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
• Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
• where:
• Report back the Azure DevOps orgs that are related to this repository and org
• Example: "where"

See additional documentation.

[kubaflo]

/azp run maui-pr-devicetests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).