Revert - Fix TalkBack not correctly narrating RadioButtons with Content#35625
Conversation
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## What Restrict the agentic-labeler to apply **exactly one `area-*` label** per item, while still allowing multiple `platform/*` labels. ## Why Backfilling the 26 items affected by the `max:1` bug (fixed in dotnet#35540) revealed that the labeler occasionally applies multiple `area-*` labels for ambiguous cases: - **dotnet#35501** got both `area-layout` and `area-safearea` - **dotnet#35490** got both `area-navigation` and `area-controls-tabbedpage` The intended behavior is exactly one best-fit `area-*` per item (a label-quota distinction not expressible via `safe-outputs.add-labels.max:` — that field counts total labels, not labels per prefix). The fix has to live in the agent's instructions. ## Changes ### `.github/skills/agentic-labeler/SKILL.md` - Scope section: "Exactly one `area-*`" / "One or more `platform/*`". - Area rules section: renamed heading, changed "pick one or more" → "apply exactly one". - New **tie-breaking heuristics** for the area-* selection: - Specific control beats generic area (`area-controls-tabbedpage` over `area-navigation`) - Sub-area beats parent area (`area-safearea` over `area-layout`) - Subject-matter focus beats incidental touch - When genuinely tied, prefer the user-visible feature - Mixed-PR rule clarified: infra-primary PRs get only `area-infrastructure` (no second product area). ### `.github/workflows/agentic-labeler.md` - Added explicit reinforcement in the workflow prompt: "Apply exactly one `area-*` label … and one or more `platform/*` labels". - Fixed two stale `max: 1` comments left over from dotnet#35540 (the cap is now `max: 10`). ### `.github/workflows/agentic-labeler.lock.yml` - Regenerated via `gh aw compile`. Diff is frontmatter-hash + heredoc rotations only — no semantic change to the compiled config. ## Validation - Reviewed all 21 existing eval scenarios in `tests/eval.yaml` — none assert multiple `area-*` labels, so no test updates needed. - The `max: 10` cap in `safe-outputs` is preserved as a blast-radius safeguard (one area + several platforms still fit comfortably). ## Follow-ups (not in this PR) If accuracy of the "one area" rule drops below ~95% in eval runs, consider adding a deterministic post-step that strips extra `area-*` labels per a known precedence list (Option B from the design discussion). Co-authored-by: bot <bot@test> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
## Description
Extends the `maui-copilot` DevDiv pipeline (pipeline 27723) with a
3-stage architecture that runs real UI tests on platform-pool agents and
reports results directly in the AI summary PR comment.
### Pipeline Workflow
```
┌─────────────────────────────────────────────────────────┐
│ Stage 1: ReviewPR │
│ │
│ STEP 1: Branch Setup (checkout + cherry-pick PR) │
│ STEP 2: Detect UI Test Categories │
│ STEP 3: Run Detected UI Tests (in-process, fast) │
│ STEP 4: Regression Cross-Reference │
│ STEP 5: Gate — verify tests fail/pass before/after fix │
│ STEP 6: Code Review — deep analysis via Copilot agent │
│ │
│ Outputs → CopilotLogs artifact + detectedCategories │
└──────────────────────┬──────────────────────────────────┘
│
┌──────────────────────▼──────────────────────────────────┐
│ Stage 2: RunDeepUITests (platform-pool agent) │
│ │
│ iOS: AcesShared Tahoe + iOS 26.4 │
│ Android: ubuntu-22.04 + KVM + AVD │
│ │
│ Runs BuildAndRunHostApp.ps1 per detected category │
│ Outputs → drop-deep-uitests artifact (TRX + diffs) │
└──────────────────────┬──────────────────────────────────┘
│
┌──────────────────────▼──────────────────────────────────┐
│ Stage 3: PostResults │
│ │
│ 1. Download CopilotLogs (review content files) │
│ 2. Download drop-deep-uitests (TRX results) │
│ 3. Merge deep results into uitests/content.md │
│ 4. Post full AI Summary comment on PR │
│ 5. Apply labels (s/agent-reviewed, etc.) │
│ │
│ One comment with everything — no patching needed │
└─────────────────────────────────────────────────────────┘
```
### What's New
**Deep UI Test Execution (Stage 2)**
- Runs detected UI test categories on proper platform-pool agents (not
in-process on Linux)
- **iOS**: AcesShared Tahoe agents with iOS 26.4 simulator, iPhone 11
Pro (matching `ios-26` baselines from PR dotnet#35061)
- **Android**: ubuntu-22.04 with KVM, AVD boot with `-partition-size
2048`, `ignoreHiddenApiPolicyError` capability
- TRX results + snapshot-diff PNGs published as `drop-deep-uitests`
artifact
**Unified Comment Posting (Stage 3)**
- Comment posting and label application deferred to Stage 3 (after deep
tests complete)
- Single AI summary comment includes ALL results: code review + deep
test results
- Nested collapsible `<details>` for failed tests with full error +
stack trace
- Dynamic section title: `🧪 UI Tests — CollectionView, TabbedPage`
- Artifact download link for snapshot-diff PNGs
**Android Emulator Improvements**
- AVD boot step with proper partition size, ADB key pre-authorization,
boot wait
- `DEVICE_UDID` pass-through prevents double emulator boot
- Disk cleanup on hosted ubuntu agents (frees ~22GB)
- KVM enablement + `appium:ignoreHiddenApiPolicyError` for API 30
**iOS Simulator Improvements**
- Tahoe pool demand ensures macOS 26.x agents
- Explicit iOS 26.4 download via latest Xcode
- Auto-creates iPhone 11 Pro for baseline resolution match
### Validation
Tested across 30+ pipeline iterations on 6 PRs:
| PR | iOS | Android |
|---|---|---|
| 35358 (ViewBaseTests) | **112/112 ALL PASS** ✅ | **118/119 PASS** ✅ |
| 35359 (TabbedPage) | 44/50 (1 real failure) | 74/75 (1 real failure) |
| 35356 (CollectionView) | **415/417 PASS** ✅ | 593/619 (26 real
failures) |
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…35589) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! Backport of dotnet#35460 to `main`. /cc @PureWeen Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35625Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35625" |
|
/review -b feature/enhanced-reviewer |
MauiBot
left a comment
There was a problem hiding this comment.
AI Review Summary
@devanathan-vaithiyanathan — new AI review results are available based on this last commit:
9bac50c.
** Revert "Fix TalkBack not correctly narrating RadioButtons with Content (#34521)"** To request a deterministic rerun after new comments or commits, comment/review rerun.
Review Sessions — click to expand
Gate — Test Before & After Fix
Gate Result: ✅ PASSED
Platform: ANDROID · Base: main · Merge base: b0ea772f
| Test | Without Fix (expect FAIL) | With Fix (expect PASS) |
|---|---|---|
📱 RadioButtonTests RadioButtonTests |
✅ FAIL — 953s | ✅ PASS — 1192s |
🔴 Without fix — 📱 RadioButtonTests: FAIL ✅ · 953s
(truncated to last 15,000 chars)
d.dll.so
[46/133] Xamarin.AndroidX.Lifecycle.ViewModelSavedState.Android.dll -> Xamarin.AndroidX.Lifecycle.ViewModelSavedState.Android.dll.so
[122/133] System.Threading.ThreadPool.dll -> System.Threading.ThreadPool.dll.so
[47/133] Xamarin.AndroidX.Loader.dll -> Xamarin.AndroidX.Loader.dll.so
[123/133] System.Text.Json.dll -> System.Text.Json.dll.so
[124/133] System.Threading.dll -> System.Threading.dll.so
[125/133] System.Xml.Linq.dll -> System.Xml.Linq.dll.so
[48/133] Xamarin.AndroidX.Navigation.Common.Android.dll -> Xamarin.AndroidX.Navigation.Common.Android.dll.so
[126/133] System.Xml.ReaderWriter.dll -> System.Xml.ReaderWriter.dll.so
[127/133] System.Xml.XDocument.dll -> System.Xml.XDocument.dll.so
[49/133] Xamarin.AndroidX.Navigation.Fragment.dll -> Xamarin.AndroidX.Navigation.Fragment.dll.so
[128/133] System.dll -> System.dll.so
[129/133] netstandard.dll -> netstandard.dll.so
[50/133] Xamarin.AndroidX.Navigation.Runtime.Android.dll -> Xamarin.AndroidX.Navigation.Runtime.Android.dll.so
[130/133] Mono.Android.Runtime.dll -> Mono.Android.Runtime.dll.so
[51/133] Xamarin.AndroidX.Navigation.UI.dll -> Xamarin.AndroidX.Navigation.UI.dll.so
[131/133] Java.Interop.dll -> Java.Interop.dll.so
[52/133] Xamarin.AndroidX.RecyclerView.dll -> Xamarin.AndroidX.RecyclerView.dll.so
[53/133] Xamarin.AndroidX.SavedState.SavedState.Android.dll -> Xamarin.AndroidX.SavedState.SavedState.Android.dll.so
[54/133] Xamarin.AndroidX.SwipeRefreshLayout.dll -> Xamarin.AndroidX.SwipeRefreshLayout.dll.so
[55/133] Xamarin.AndroidX.ViewPager.dll -> Xamarin.AndroidX.ViewPager.dll.so
[56/133] Xamarin.AndroidX.ViewPager2.dll -> Xamarin.AndroidX.ViewPager2.dll.so
[57/133] Xamarin.Google.Android.Material.dll -> Xamarin.Google.Android.Material.dll.so
[132/133] Mono.Android.dll -> Mono.Android.dll.so
[58/133] Xamarin.GooglePlayServices.Base.dll -> Xamarin.GooglePlayServices.Base.dll.so
[59/133] Xamarin.GooglePlayServices.Basement.dll -> Xamarin.GooglePlayServices.Basement.dll.so
[60/133] Xamarin.GooglePlayServices.Maps.dll -> Xamarin.GooglePlayServices.Maps.dll.so
[61/133] Xamarin.GooglePlayServices.Tasks.dll -> Xamarin.GooglePlayServices.Tasks.dll.so
[62/133] Xamarin.Kotlin.StdLib.dll -> Xamarin.Kotlin.StdLib.dll.so
[63/133] Xamarin.KotlinX.Coroutines.Core.Jvm.dll -> Xamarin.KotlinX.Coroutines.Core.Jvm.dll.so
[64/133] Xamarin.KotlinX.Serialization.Core.Jvm.dll -> Xamarin.KotlinX.Serialization.Core.Jvm.dll.so
[65/133] xunit.abstractions.dll -> xunit.abstractions.dll.so
[66/133] xunit.assert.dll -> xunit.assert.dll.so
[67/133] xunit.core.dll -> xunit.core.dll.so
[68/133] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.so
[69/133] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.so
[70/133] System.Collections.Concurrent.dll -> System.Collections.Concurrent.dll.so
[71/133] System.Collections.Immutable.dll -> System.Collections.Immutable.dll.so
[72/133] System.Collections.NonGeneric.dll -> System.Collections.NonGeneric.dll.so
[133/133] System.Private.CoreLib.dll -> System.Private.CoreLib.dll.so
[73/133] System.Collections.Specialized.dll -> System.Collections.Specialized.dll.so
[74/133] System.Collections.dll -> System.Collections.dll.so
[75/133] System.ComponentModel.Primitives.dll -> System.ComponentModel.Primitives.dll.so
[76/133] System.ComponentModel.TypeConverter.dll -> System.ComponentModel.TypeConverter.dll.so
[77/133] System.ComponentModel.dll -> System.ComponentModel.dll.so
[78/133] System.Console.dll -> System.Console.dll.so
[79/133] System.Diagnostics.Debug.dll -> System.Diagnostics.Debug.dll.so
[80/133] System.Diagnostics.DiagnosticSource.dll -> System.Diagnostics.DiagnosticSource.dll.so
[81/133] System.Diagnostics.Process.dll -> System.Diagnostics.Process.dll.so
[82/133] System.Diagnostics.Tools.dll -> System.Diagnostics.Tools.dll.so
[83/133] System.Diagnostics.TraceSource.dll -> System.Diagnostics.TraceSource.dll.so
[84/133] System.Diagnostics.Tracing.dll -> System.Diagnostics.Tracing.dll.so
[85/133] System.Drawing.Primitives.dll -> System.Drawing.Primitives.dll.so
[86/133] System.Drawing.dll -> System.Drawing.dll.so
[87/133] System.Formats.Asn1.dll -> System.Formats.Asn1.dll.so
[88/133] System.Globalization.dll -> System.Globalization.dll.so
[89/133] System.IO.Compression.Brotli.dll -> System.IO.Compression.Brotli.dll.so
[90/133] System.IO.Compression.dll -> System.IO.Compression.dll.so
[91/133] System.IO.FileSystem.dll -> System.IO.FileSystem.dll.so
[92/133] System.IO.Pipelines.dll -> System.IO.Pipelines.dll.so
[93/133] System.IO.dll -> System.IO.dll.so
[94/133] System.Linq.Expressions.dll -> System.Linq.Expressions.dll.so
[95/133] System.Linq.dll -> System.Linq.dll.so
[96/133] System.Memory.dll -> System.Memory.dll.so
[97/133] System.Net.Http.dll -> System.Net.Http.dll.so
[98/133] System.Net.NameResolution.dll -> System.Net.NameResolution.dll.so
[99/133] System.Net.Primitives.dll -> System.Net.Primitives.dll.so
[100/133] System.Net.Requests.dll -> System.Net.Requests.dll.so
[101/133] System.Net.Sockets.dll -> System.Net.Sockets.dll.so
[102/133] System.Numerics.Vectors.dll -> System.Numerics.Vectors.dll.so
[103/133] System.ObjectModel.dll -> System.ObjectModel.dll.so
[104/133] System.Private.Uri.dll -> System.Private.Uri.dll.so
[105/133] System.Private.Xml.Linq.dll -> System.Private.Xml.Linq.dll.so
[106/133] System.Private.Xml.dll -> System.Private.Xml.dll.so
[107/133] System.Reflection.Extensions.dll -> System.Reflection.Extensions.dll.so
[108/133] System.Reflection.TypeExtensions.dll -> System.Reflection.TypeExtensions.dll.so
[109/133] System.Reflection.dll -> System.Reflection.dll.so
[110/133] System.Runtime.Extensions.dll -> System.Runtime.Extensions.dll.so
[111/133] System.Runtime.InteropServices.RuntimeInformation.dll -> System.Runtime.InteropServices.RuntimeInformation.dll.so
[112/133] System.Runtime.InteropServices.dll -> System.Runtime.InteropServices.dll.so
[113/133] System.Runtime.Loader.dll -> System.Runtime.Loader.dll.so
[114/133] System.Runtime.Numerics.dll -> System.Runtime.Numerics.dll.so
[115/133] System.Runtime.dll -> System.Runtime.dll.so
[116/133] System.Security.Cryptography.dll -> System.Security.Cryptography.dll.so
[117/133] System.Text.Encoding.dll -> System.Text.Encoding.dll.so
[118/133] System.Text.Encodings.Web.dll -> System.Text.Encodings.Web.dll.so
[119/133] System.Text.Json.dll -> System.Text.Json.dll.so
[120/133] System.Text.RegularExpressions.dll -> System.Text.RegularExpressions.dll.so
[121/133] System.Threading.Tasks.dll -> System.Threading.Tasks.dll.so
[122/133] System.Threading.Thread.dll -> System.Threading.Thread.dll.so
[123/133] System.Threading.ThreadPool.dll -> System.Threading.ThreadPool.dll.so
[124/133] System.Threading.dll -> System.Threading.dll.so
[125/133] System.Xml.Linq.dll -> System.Xml.Linq.dll.so
[126/133] System.Xml.ReaderWriter.dll -> System.Xml.ReaderWriter.dll.so
[127/133] System.Xml.XDocument.dll -> System.Xml.XDocument.dll.so
[128/133] System.dll -> System.dll.so
[129/133] netstandard.dll -> netstandard.dll.so
[130/133] Java.Interop.dll -> Java.Interop.dll.so
[131/133] Mono.Android.Runtime.dll -> Mono.Android.Runtime.dll.so
[132/133] Mono.Android.dll -> Mono.Android.dll.so
[133/133] System.Private.CoreLib.dll -> System.Private.CoreLib.dll.so
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:11:11.33
[11.0.0-prerelease.26230.4+92962e5c46ac08a66ded4c5696209cc60f1a232f] XHarness command issued: android test --app /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk --package-name com.microsoft.maui.controls.devicetests --device-id emulator-5554 -o artifacts/log --timeout 01:00:00 -v --arg TestFilter=RadioButtonTests
�[40m�[37mdbug�[39m�[22m�[49m: ADBRunner using ADB.exe supplied from /home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/tools/net10.0/any/../../../runtimes/any/native/adb/linux/adb
�[40m�[37mdbug�[39m�[22m�[49m: Full resolved path:'/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb'
�[40m�[32minfo�[39m�[22m�[49m: Will attempt to find device supporting architectures: 'arm64-v8a', 'x86_64'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb start-server'
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[32minfo�[39m�[22m�[49m: Finding attached devices/emulators...
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb devices -l'
�[40m�[37mdbug�[39m�[22m�[49m: Found 1 possible devices
�[40m�[37mdbug�[39m�[22m�[49m: Evaluating output line for device serial: emulator-5554 device product:sdk_gphone_x86_64 model:sdk_gphone_x86_64 device:generic_x86_64_arm64 transport_id:1
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 shell getprop ro.product.cpu.abilist'
�[40m�[37mdbug�[39m�[22m�[49m: Found 1 possible devices. Using 'emulator-5554'
�[40m�[32minfo�[39m�[22m�[49m: Active Android device set to serial 'emulator-5554'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 -s emulator-5554 shell getprop ro.product.cpu.abi'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 -s emulator-5554 shell getprop ro.build.version.sdk'
�[40m�[32minfo�[39m�[22m�[49m: Waiting for device to be available (max 5 minutes)
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 wait-for-device'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 -s emulator-5554 shell getprop sys.boot_completed'
�[40m�[37mdbug�[39m�[22m�[49m: sys.boot_completed = '1'
�[40m�[37mdbug�[39m�[22m�[49m: Waited 0 seconds for device boot completion
�[40m�[37mdbug�[39m�[22m�[49m: Working with emulator-5554 (API 30)
�[40m�[37mdbug�[39m�[22m�[49m: Check current adb install and/or package verification settings
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 shell settings get global verifier_verify_adb_installs'
�[40m�[37mdbug�[39m�[22m�[49m: verifier_verify_adb_installs = 0
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 shell settings get global package_verifier_enable'
�[40m�[37mdbug�[39m�[22m�[49m: package_verifier_enable =
�[40m�[1m�[33mwarn�[39m�[22m�[49m: Installing debug apks on a device might be rejected with INSTALL_FAILED_VERIFICATION_FAILURE. Make sure to set 'package_verifier_enable' to '0'
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[40m�[1m�[33mwarn�[39m�[22m�[49m: Hit broken pipe error; Will make one attempt to restart ADB server, and retry the uninstallation
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 kill-server'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 start-server'
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[41m�[30mfail�[39m�[22m�[49m: Error: Exit code: 20
Std out:
Std err:
- waiting for device -
cmd: Can't find service: package
�[40m�[32minfo�[39m�[22m�[49m: Attempting to install /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 install /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk'
�[41m�[30mfail�[39m�[22m�[49m: Error:
Exit code: 1
Std out:
Serving...
Performing Incremental Install
cmd: Can't find service: package
Performing Streamed Install
Std err:
adb: failed to install /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk: cmd: Can't find service: package
�[41m�[1m�[37mcrit�[39m�[22m�[49m: Install failure: Test command cannot continue
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[41m�[30mfail�[39m�[22m�[49m: Error: Exit code: 20
Std out:
Std err:
cmd: Can't find service: package
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[41m�[30mfail�[39m�[22m�[49m: Error: Exit code: 20
Std out:
Std err:
cmd: Can't find service: package
XHarness exit code: 78 (PACKAGE_INSTALLATION_FAILURE)
Tests completed with exit code: 78
🟢 With fix — 📱 RadioButtonTests: PASS ✅ · 1192s
(truncated to last 15,000 chars)
334 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:18.324 15698 19345 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:22.119 15698 19356 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:25.938 15698 19367 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:29.805 15698 19379 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:33.660 15698 19390 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:37.483 15698 19401 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:41.284 15698 19412 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:45.116 15698 19423 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:48.938 15698 19434 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:52.744 15698 19445 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:56.570 15698 19452 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:00.885 15698 19463 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:04.715 15698 19474 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:08.520 15698 19485 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:12.379 15698 19496 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:16.198 15698 19507 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:20.030 15698 19518 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:25.047 15698 19529 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:28.912 15698 19541 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:32.744 15698 19552 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:36.572 15698 19563 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:40.433 15698 19574 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:44.250 15698 19585 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:49.651 15698 19590 I DOTNET : [PASS] CollectionView Header/Footer Doesn't Leak
06-01 08:06:57.729 15698 19595 I DOTNET : [PASS] FlyoutPage Detail Navigation Does Not Leak
06-01 08:06:57.729 15698 19595 I DOTNET : Microsoft.Maui.DeviceTests.Memory.MemoryTests 271.2424895 ms
06-01 08:06:57.730 15698 19595 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.SearchBarTests
06-01 08:06:57.741 15698 19595 I DOTNET : [PASS] RotationYConsistent
06-01 08:06:57.747 15698 19595 I DOTNET : [PASS] ScaleConsistent
06-01 08:06:57.752 15698 19595 I DOTNET : [PASS] ScaleXConsistent
06-01 08:06:57.765 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly at Initialization
06-01 08:06:57.777 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly at Initialization
06-01 08:06:57.784 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly after Initialization
06-01 08:06:57.797 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly after Initialization
06-01 08:06:57.804 15698 19601 I DOTNET : [PASS] VerifySearchBarOpacityProperty
06-01 08:06:57.811 15698 19601 I DOTNET : [PASS] SearchBarTranslationConsistent
06-01 08:06:57.817 15698 19601 I DOTNET : [PASS] RotationXConsistent
06-01 08:06:57.823 15698 19601 I DOTNET : [PASS] VerifySearchBarIsEnabledProperty
06-01 08:06:57.829 15698 19601 I DOTNET : [PASS] ScaleYConsistent
06-01 08:06:57.837 15698 19601 I DOTNET : [PASS] VerifySearchBarIsVisibleProperty
06-01 08:06:57.843 15698 19601 I DOTNET : [PASS] RotationConsistent
06-01 08:06:57.843 15698 19601 I DOTNET : Microsoft.Maui.DeviceTests.SearchBarTests 0.1076797 ms
06-01 08:06:57.843 15698 19601 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_InvokeDotNet
06-01 08:06:58.513 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:06:58.513 15698 15717 I DOTNET : InvokeDotNet endpoint missing or invalid request header
06-01 08:06:59.025 15698 19607 I DOTNET : [PASS] GetRequestsAreBlocked
06-01 08:06:59.757 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:06:59.757 15698 15717 I DOTNET : InvokeDotNet endpoint missing or invalid request header
06-01 08:07:00.267 15698 19613 I DOTNET : [PASS] InvalidTokenHeaderIsBlocked
06-01 08:07:00.268 15698 19613 I DOTNET : [IGNORED] IframeRequestIsBlocked
06-01 08:07:00.914 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:00.914 15698 15717 I DOTNET : InvokeDotNet request missing X-Maui-Request-Body header
06-01 08:07:01.209 15698 19619 I DOTNET : [PASS] EmptyBodyIsBlocked
06-01 08:07:01.890 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:01.890 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: The invoke data did not provide a method name.
06-01 08:07:01.890 15698 15717 I DOTNET : System.InvalidOperationException: The invoke data did not provide a method name.
06-01 08:07:01.890 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:02.392 15698 19625 I DOTNET : [PASS] ValidRequestIsNotBlocked
06-01 08:07:03.086 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:03.086 15698 15717 I DOTNET : InvokeDotNet endpoint only accepts POST requests. Received: GET
06-01 08:07:03.597 15698 19631 I DOTNET : [PASS] GetRequestWithHeaderIsBlocked
06-01 08:07:04.395 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:04.395 15698 15717 I DOTNET : InvokeDotNet endpoint missing or invalid request header
06-01 08:07:04.939 15698 19637 I DOTNET : [PASS] MissingTokenHeaderIsBlocked
06-01 08:07:05.624 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:05.624 15698 15717 I DOTNET : InvokeDotNet request missing X-Maui-Request-Body header
06-01 08:07:06.203 15698 19643 I DOTNET : [PASS] MissingBodyHeaderIsBlocked
06-01 08:07:06.203 15698 19643 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_InvokeDotNet 8.2321229 ms
06-01 08:07:06.203 15698 19643 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_EvaluateJavaScriptAsync
06-01 08:07:06.881 15698 19649 I DOTNET : [PASS] EvaluateJavaScriptAndGetResult
06-01 08:07:06.881 15698 19649 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_EvaluateJavaScriptAsync 0.6768011 ms
06-01 08:07:06.881 15698 19649 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling
06-01 08:07:08.102 15698 19655 I DOTNET : [PASS] CSharpMethodThatSucceeds_ShouldStillWorkNormally
06-01 08:07:08.813 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:08.813 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: Async test exception
06-01 08:07:08.813 15698 15717 I DOTNET : System.InvalidOperationException: Async test exception
06-01 08:07:08.813 15698 15717 I DOTNET : at Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling.TestExceptionMethods.ThrowExceptionAsync()
06-01 08:07:08.813 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetMethodAsync(Type targetType, Object jsInvokeTarget, JSInvokeMethodData invokeData)
06-01 08:07:08.813 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:09.312 15698 19661 I DOTNET : [PASS] CSharpAsyncMethodThatThrowsException_ShouldPropagateToJavaScript
06-01 08:07:10.038 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:10.038 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: Test exception message
06-01 08:07:10.038 15698 15717 I DOTNET : System.InvalidOperationException: Test exception message
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling.TestExceptionMethods.ThrowException()
06-01 08:07:10.038 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
06-01 08:07:10.038 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )
06-01 08:07:10.038 15698 15717 I DOTNET : --- End of stack trace from previous location ---
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.GetDotNetMethodReturnValue(Object jsInvokeTarget, MethodInfo dotnetMethod, Object[] invokeParamValues)
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetMethodAsync(Type targetType, Object jsInvokeTarget, JSInvokeMethodData invokeData)
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:10.550 15698 19667 I DOTNET : [PASS] CSharpMethodThatThrowsException_ShouldPropagateToJavaScript
06-01 08:07:11.264 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:11.264 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: Custom argument exception
06-01 08:07:11.264 15698 15717 I DOTNET : System.ArgumentException: Custom argument exception
06-01 08:07:11.264 15698 15717 I DOTNET : at Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling.TestExceptionMethods.ThrowCustomException()
06-01 08:07:11.264 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
06-01 08:07:11.265 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )
06-01 08:07:11.265 15698 15717 I DOTNET : --- End of stack trace from previous location ---
06-01 08:07:11.265 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.GetDotNetMethodReturnValue(Object jsInvokeTarget, MethodInfo dotnetMethod, Object[] invokeParamValues)
06-01 08:07:11.265 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetMethodAsync(Type targetType, Object jsInvokeTarget, JSInvokeMethodData invokeData)
06-01 08:07:11.265 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:11.775 15698 19673 I DOTNET : [PASS] CSharpMethodThatThrowsCustomException_ShouldIncludeExceptionDetails
06-01 08:07:11.775 15698 19673 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling 4.8904472 ms
06-01 08:07:11.775 15698 19673 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.PickerTests
06-01 08:07:11.959 15698 19678 I DOTNET : [PASS] PickerBackgroundColorConsistent
06-01 08:07:11.968 15698 19678 I DOTNET : [PASS] ItemsUpdateWithCollectionChanges
06-01 08:07:11.972 15698 19678 I DOTNET : [PASS] RotationYConsistent
06-01 08:07:12.039 15698 19678 I DOTNET : [PASS] ScaleConsistent
06-01 08:07:12.044 15698 19678 I DOTNET : [PASS] VerifyPickerOpacityProperty
06-01 08:07:12.047 15698 19678 I DOTNET : [PASS] ScaleYConsistent
06-01 08:07:12.050 15698 19678 I DOTNET : [PASS] ScaleXConsistent
06-01 08:07:12.052 15698 19678 I DOTNET : [PASS] RotationXConsistent
06-01 08:07:12.057 15698 19678 I DOTNET : [PASS] ItemsUpdateWithNewItemSource
06-01 08:07:12.059 15698 19678 I DOTNET : [PASS] RotationConsistent
06-01 08:07:12.059 15698 19678 I DOTNET : Microsoft.Maui.DeviceTests.PickerTests 0.2191462 ms
06-01 08:07:12.060 15698 19678 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_SetInvokeJavaScriptTarget
06-01 08:07:13.208 15698 19684 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:14.461 15698 19690 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:15.625 15698 19696 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:16.975 15698 19702 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:18.232 15698 19708 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:19.455 15698 19714 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:20.684 15698 19720 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:21.897 15698 19726 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:23.116 15698 19732 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:24.358 15698 19738 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:24.358 15698 19738 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_SetInvokeJavaScriptTarget 12.1550019 ms
06-01 08:07:24.358 15698 19738 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.Memory.WindowOverlayTests
06-01 08:07:26.338 15698 19743 I DOTNET : [PASS] Does Not Leak
06-01 08:07:26.338 15698 19743 I DOTNET : Microsoft.Maui.DeviceTests.Memory.WindowOverlayTests 1.9796238 ms
06-01 08:07:26.370 15698 17436 I DOTNET : Xml file was written to the provided writer.
06-01 08:07:26.370 15698 17436 I DOTNET : Tests run: 953 Passed: 940 Inconclusive: 0 Failed: 0 Ignored: 0
�[40m�[32minfo�[39m�[22m�[49m: <<XHARNESS_RESULT_START>>
{
"version": 1,
"machineName": "runnervmm79r7",
"exitCode": 0,
"exitCodeName": "SUCCESS",
"platform": "android",
"instrumentationExitCode": 0,
"device": "emulator-5554",
"deviceOsVersion": "API 30",
"architecture": "x86_64",
"files": [
{
"name": "testResults.xml",
"type": "test-results"
},
{
"name": "adb-logcat-com.microsoft.maui.controls.devicetests-default.log",
"type": "logcat"
}
]
}
<<XHARNESS_RESULT_END>>
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[40m�[32minfo�[39m�[22m�[49m: Successfully uninstalled com.microsoft.maui.controls.devicetests
XHarness exit code: 0
Tests completed successfully
📁 Fix files reverted (3 files)
eng/pipelines/ci-copilot.ymlsrc/Controls/src/Core/RadioButton/RadioButton.cssrc/Core/src/Platform/Android/SemanticExtensions.cs
UI Tests — RadioButton,ViewBaseTests
Detected UI test categories: RadioButton,ViewBaseTests
❌ Deep UI tests — 0 passed; 2 category setup failures (146 impacted tests marked failed by TRX) across 2 categories on platform-pool agent (replaces in-process counts above).
🧪 UI Test Execution Results (deep, platform pool)
| Category | Tests | Snapshot diffs |
|---|---|---|
RadioButton |
0/27 (setup failed; 27 marked failed) | — |
ViewBaseTests |
0/119 (setup failed; 119 marked failed) | — |
⚠️ RadioButton — fixture setup failed for 27 tests
NUnit reported a OneTimeSetUp/fixture setup failure before test bodies ran; the TRX marked each affected test failed.
Multiple setup failure signatures were present; showing the first one. See the TRX artifact for all details.
OneTimeSetUp: System.TimeoutException : ContentPresenter just rendering component string in .Net9
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
at UITest.Appium.NUnit.UITestBase.OneTimeSetup() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 221
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
at System.Run
...
⚠️ ViewBaseTests — fixture setup failed for 119 tests
NUnit reported a OneTimeSetUp/fixture setup failure before test bodies ran; the TRX marked each affected test failed.
Multiple setup failure signatures were present; showing the first one. See the TRX artifact for all details.
OneTimeSetUp: System.TimeoutException : Timed out waiting for Go To Test button to appear
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
at Microsoft.Maui.TestCases.Tests.UtilExtensions.NavigateToGallery(IApp app, String page) in /_/src/Controls/tests/TestCases.Shared.Tests/UtilExtensions.cs:line 37
at Microsoft.Maui.TestCases.Tests._GalleryUITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_GalleryUITest.cs:line 57
at UITest.Appium.NUnit.UITestBase.OneTimeSetup() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 221
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStac
...
📎 Download drop-deep-uitests artifact (TRX + snapshot diffs)
Pre-Flight — Context & Validation
Pre-Flight Summary
PR: #35625
Platform for testing: Android
Gate: Already completed externally — PASSED. Gate output was not modified.
Context
PR #35625 changes RadioButton accessibility behavior by reverting the semantic-content extraction and Android semantic-node updates introduced by the earlier RadioButton accessibility fix. GitHub CLI authentication is unavailable in this environment, so context was gathered from local repository state, public GitHub API access where available, and full source/diff review.
Changed Files
src/Controls/src/Core/RadioButton/RadioButton.cssrc/Core/src/Platform/Android/SemanticExtensions.cssrc/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs
Code Review Summary
Verdict: NEEDS_CHANGES
Confidence: high
The PR appears over-broad: it removes the original accessibility fix and its regression tests instead of addressing likely narrow regressions. The main risks are reintroducing type-name announcements for templated/view-content RadioButtons and losing Android TalkBack role/state for templated RadioButtons.
Try-Fix Inputs
Problem: Preserve correct RadioButton accessibility semantics for templated/view-content RadioButtons on Android while avoiding regressions from the previous implementation.
Target files:
src/Controls/src/Core/RadioButton/RadioButton.cssrc/Core/src/Platform/Android/SemanticExtensions.cssrc/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs
Relevant failure modes:
- View-based RadioButton content should expose child label/semantic text, not a CLR type name.
- Explicit
SemanticProperties.Descriptionshould not be overwritten by content-derived semantics. - Android templated RadioButtons should expose radio-button role and checked state to TalkBack.
- If no text is found in view-based content, fallback should continue to
ValueorContentAsString()rather than returningnull.
Code Review — Deep Analysis
Code Review — PR #35625
Independent Assessment
What this changes: PR #35625 removes the RadioButton semantic-content extraction added by the prior accessibility fix, removes Android AccessibilityNodeInfoCompat radio-button role/state population for IRadioButton, and deletes the corresponding Android device regression tests.
Inferred motivation: The PR appears to be a revert of PR #34521, likely due to a regression in that fix, but the available local/GitHub metadata did not expose a concrete replacement strategy.
Reconciliation with PR Narrative
Author claims: GitHub CLI authentication was unavailable; public API data was partially accessible via curl, but the review is based primarily on local diff/source context and PR metadata.
Agreement/disagreement: The diff does simplify the code, but it also reintroduces the original accessibility regression for templated/view-content RadioButtons and removes the tests proving the behavior.
Findings
❌ Error — Issue #34322 behavior is reintroduced for view-based RadioButton content
src/Controls/src/Core/RadioButton/RadioButton.cs changes UpdateSemantics() back from semantic extraction to ContentAsString(). For Content values that are IView/layout instances, ContentAsString() ultimately uses ToString(), so a templated RadioButton with content like VerticalStackLayout { Label("Dog") } can expose a type name instead of the intended accessible label.
❌ Error — Android templated RadioButtons lose explicit role/state semantics
src/Core/src/Platform/Android/SemanticExtensions.cs removes the IRadioButton block that set ClassName, Checkable, and Checked on AccessibilityNodeInfoCompat. Native non-templated Android radio buttons may still get this from AppCompatRadioButton, but templated RadioButtons use container views and need explicit role/value information for TalkBack.
❌ Error — Regression tests are deleted without replacement
src/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs removes tests for templated RadioButton semantic label extraction and explicit semantic-description precedence. A revert might be justified if PR #34521 introduced a distinct bug, but this PR does not preserve coverage for the original issue or add coverage for the alleged regression.
⚠️ Warning — The prior implementation likely had a surgical bug rather than requiring a wholesale revert
The removed GetSemanticDescriptionFromContent() returned null when Content is IView but no textual semantic description was found, preventing fallback to Value or ContentAsString(). That is a small control-flow bug that can be fixed by falling through when recursive extraction fails.
Failure Modes
- Templated RadioButton with
Content = new VerticalStackLayout { Children = { new Label { Text = "Dog" } } }: accessible description may becomeMicrosoft.Maui.Controls.VerticalStackLayoutinstead ofDog. - Android templated RadioButton: TalkBack may not announce role/state (
radio button,checked/not checked) because the platform view is not anAppCompatRadioButton. Content is IViewwith no text butValue = "Dog": the prior fix can returnnullinstead of falling back toValueunless corrected surgically.
Blast Radius
Affects MAUI RadioButton accessibility on Android and cross-platform semantics for templated/view-content RadioButtons. Native non-templated string-content RadioButtons are lower risk.
Devil's Advocate
The PR may be responding to a real regression from PR #34521, especially around Android native role duplication or the null-return fallback path. However, the broad revert removes both the useful semantic extraction and the Android templated role/state support, so the safer path is a narrower alternative fix.
Verdict: NEEDS_CHANGES
Confidence: high
Summary: The PR reverts a legitimate accessibility fix and deletes its tests. A better candidate should preserve view-content semantic extraction, preserve Android role/state for templated RadioButtons, and fix any regression surgically.
Try-Fix Hints
- Root problem: retain RadioButton accessibility semantics while avoiding regressions introduced by the previous broad implementation.
- Target files:
src/Controls/src/Core/RadioButton/RadioButton.cs,src/Core/src/Platform/Android/SemanticExtensions.cs,src/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs. - Candidate direction: make
GetSemanticDescriptionFromContent()fall through toValue/ContentAsString()when recursive extraction fromIViewfails. - Candidate direction: apply Android
AccessibilityNodeInfoCompatradio-button role/state only for non-native/templated RadioButtons, avoiding duplication onAppCompatRadioButton.
Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix | Preserve RadioButton accessibility fix; add fallback when view-content semantic extraction fails; guard Android role/state injection to non-native platform views | ✅ PASS | 2 files | Better than PR #35625 because it keeps the accessibility behavior and regression tests instead of reverting them wholesale. |
| PR | PR #35625 | Broad revert of RadioButton semantic extraction, Android IRadioButton semantic node info, and regression tests | ✅ PASSED (Gate) | 3 files | Gate passed, but code review found it reintroduces the accessibility regression. |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| maui-expert-reviewer | 1 | Yes | Surgical preserve-and-fix candidate: fall through from failed view-content extraction and guard Android native radio-button role/state duplication. |
Exhausted: No — stopped because Candidate #1 passed the Android regression test command and is materially better than the PR's current broad revert.
Selected Fix: Candidate #1 — Retains correct accessibility semantics while addressing likely regressions narrowly.
Report — Final Recommendation
Comparative Report - PR #35625
Candidates compared
| Rank | Candidate | Regression result | Assessment |
|---|---|---|---|
| 1 | try-fix-1 |
PASS | Best candidate. It preserves the RadioButton accessibility fix and tests while narrowly addressing the Android regression by falling back only when semantic extraction finds no text and avoiding radio-button node-state injection for native CompoundButton platform views. |
| 2 | pr-plus-reviewer |
Not independently rerun | Good direction and effectively converges on the same surgical approach as try-fix-1, but it is a reviewer-derived sandbox candidate rather than the empirically tested Step 5a candidate. |
| 3 | pr |
Gate PASSED | The submitted PR fixes the immediate Android gate scenario but is over-broad: it reintroduces the templated RadioButton accessibility regression by using ContentAsString() for view content, removes Android role/state semantics for templated RadioButtons, and deletes regression tests. |
Analysis
The raw PR should not win because the expert review found a concrete accessibility regression on an added/modified diff line. ContentAsString() is not safe for templated RadioButtons with view content because it can announce a CLR type name instead of meaningful child text, which was the behavior fixed by the earlier accessibility change.
pr-plus-reviewer is materially better than the raw PR because it applies the expert reviewer's feedback: keep semantic extraction and fix only the Android-specific problematic path. However, among the non-raw candidates, try-fix-1 has the same surgical design and has an explicit Android device-test PASS from STEP 5a.
Winner
try-fix-1 is the single winning candidate. It is the highest-ranked candidate with passing regression evidence and avoids both the Android crash/regression targeted by PR #35625 and the accessibility regression reintroduced by the submitted PR.
Future Action — alternative fix proposed (try-fix-1)
Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against automatically generated candidates and selected try-fix-1 as the strongest fix.
Why: try-fix-1 wins because it passed the Android regression test and fixes the issue surgically while preserving the templated RadioButton accessibility behavior and tests. The raw PR passes the gate but reintroduces a known accessibility regression; pr-plus-reviewer converges on the same approach as try-fix-1 but lacks separate Step 5a regression evidence.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (try-fix-1)
diff --git a/src/Controls/src/Core/RadioButton/RadioButton.cs b/src/Controls/src/Core/RadioButton/RadioButton.cs
index 53855d94e1..fdac49a931 100644
--- a/src/Controls/src/Core/RadioButton/RadioButton.cs
+++ b/src/Controls/src/Core/RadioButton/RadioButton.cs
@@ -775,8 +775,10 @@ namespace Microsoft.Maui.Controls
{
// Don't fall back to ContentAsString() for view-based content — it calls ToString()
// on the view and returns a type name rather than meaningful text.
- TryGetSemanticDescription(contentView, out var semanticDescription);
- return semanticDescription;
+ if (TryGetSemanticDescription(contentView, out var semanticDescription))
+ {
+ return semanticDescription;
+ }
}
if (Value is string valueText && !string.IsNullOrWhiteSpace(valueText))
diff --git a/src/Core/src/Platform/Android/SemanticExtensions.cs b/src/Core/src/Platform/Android/SemanticExtensions.cs
index 222b2d91dc..710aadd43b 100644
--- a/src/Core/src/Platform/Android/SemanticExtensions.cs
+++ b/src/Core/src/Platform/Android/SemanticExtensions.cs
@@ -92,7 +92,7 @@ namespace Microsoft.Maui.Platform
if (!string.IsNullOrWhiteSpace(newText))
info.Text = newText;
- if (virtualView is IRadioButton radioButton)
+ if (virtualView is IRadioButton radioButton && platformView is not CompoundButton)
{
info.ClassName = s_radioButtonClassName;
info.Checkable = true;
…nt (#35625) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue details: A regression was introduced by PR #[34521](#34521) on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3. ### Description of changes: Fully reverts PR #[34521](#34521). Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #[34322](#34322) and their helper methods. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #35584 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
…RadioButtons with Content (#35694) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! Backport of #35625 to `release/10.0.1xx-sr7`. /cc @PureWeen Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com>
Issue details:
A regression was introduced by PR #34521 on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3.
Description of changes:
Fully reverts PR #34521. Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #34322 and their helper methods.
Issues Fixed
Fixes #35584