Fix SwipeItemView command leak

[AdamEssenmacher]

Fixes a memory leak in SwipeItemView.Command where assigning a long-lived ICommand caused each SwipeItemView to be retained through a direct CanExecuteChanged subscription.

The retained graph could keep row content, command parameters, binding contexts, and row view models alive after the containing page was closed.

This changes SwipeItemView to use the existing ICommandElement / WeakCommandSubscription infrastructure used by other command-backed controls. It also moves command enablement into IsEnabledCore, so explicit IsEnabled=false, parent disabled state, and Command.CanExecute are composed consistently.

Fixes #35498

Testing

• dotnet test src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj --filter "FullyQualifiedName~CommandTests|FullyQualifiedName~SwipeViewTests"
• dotnet build Microsoft.Maui.BuildTasks.slnf
• Verified the SwipeItemView.Command leaks row views and command parameters through CanExecuteChanged #35498 iOS repro after forced rebuild:
  • SwipeItemViewCommand: commandSubscribers=0, aliveRows=0, retainedPayloadBytes=0
• Verified the SwipeItemView.Command leaks row views and command parameters through CanExecuteChanged #35498 Android repro after forced rebuild:
  • SwipeItemViewCommand no longer retains all 1,000 rows / 125 MiB and drops to the Android platform baseline

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35510

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35510"

[dotnet-policy-service]

Hey there @@AdamEssenmacher! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[kubaflo]

/review -b feature/regression-check

[kubaflo]

/review -b feature/regression-check -p android

[MauiBot]

🤖 AI Summary

👋 @AdamEssenmacher — new AI review results are available. Please review the latest session below.

📊 Review Session — 5ef8007 · Fix SwipeItemView command leak · 2026-05-19 12:06 UTC

🚦 Gate — Test Before & After Fix

Gate Result: ✅ PASSED

Platform: IOS · Base: main · Merge base: eb20ff6e

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🧪 CommandTests CommandTests	✅ FAIL — 37s	✅ PASS — 23s
🧪 SwipeViewTests SwipeViewTests	✅ FAIL — 7s	✅ PASS — 7s

🔴 Without fix — 🧪 CommandTests: FAIL ✅ · 37s

  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 861 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 983 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/TestUtils/TestUtils.csproj (in 4.88 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj (in 5.67 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 5.69 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 5.21 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 6.13 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 6.13 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 6.13 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/maps/src/Maps.csproj (in 6.15 sec).
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  TestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.12]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.82]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.83]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:01.50]     CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SwipeItemView), useWeakEventHandler: False) [FAIL]
[xUnit.net 00:00:01.53]       Assert.False() Failure
[xUnit.net 00:00:01.53]       Expected: False
[xUnit.net 00:00:01.53]       Actual:   True
[xUnit.net 00:00:01.53]       Stack Trace:
[xUnit.net 00:00:01.56]         /_/src/Controls/tests/Core.UnitTests/CommandTests.cs(354,0): at Microsoft.Maui.Controls.Core.UnitTests.CommandTests.CommandsSubscribedToCanExecuteCollect(Type controlType, Boolean useWeakEventHandler)
[xUnit.net 00:00:01.57]         --- End of stack trace from previous location ---
  Passed CanExecuteReturnsFalseIfParameterIsWrongValueType [5 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchBar), useWeakEventHandler: False) [45 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.MenuItem), useWeakEventHandler: True) [33 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.ImageButton), useWeakEventHandler: False) [35 ms]
  Failed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SwipeItemView), useWeakEventHandler: False) [495 ms]
  Error Message:
   Assert.False() Failure
Expected: False
Actual:   True
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.CommandTests.CommandsSubscribedToCanExecuteCollect(Type controlType, Boolean useWeakEventHandler) in /_/src/Controls/tests/Core.UnitTests/CommandTests.cs:line 354
--- End of stack trace from previous location ---
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.Button), useWeakEventHandler: False) [38 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.ImageButton), useWeakEventHandler: True) [35 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.RefreshView), useWeakEventHandler: False) [38 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.TextCell), useWeakEventHandler: False) [57 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchHandler), useWeakEventHandler: True) [39 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SwipeItemView), useWeakEventHandler: True) [38 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.MenuItem), useWeakEventHandler: False) [40 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.RefreshView), useWeakEventHandler: True) [37 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.TextCell), useWeakEventHandler: True) [39 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.Button), useWeakEventHandler: True) [41 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchBar), useWeakEventHandler: True) [47 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchHandler), useWeakEventHandler: False) [35 ms]
  Passed ExecuteDoesNotRunIfParameterIsWrongReferenceType [< 1 ms]
  Passed ExecuteRunsIfReferenceTypeAndSetToNull [< 1 ms]
  Passed CanExecuteIgnoresParameterIfValueTypeAndSetToNull [< 1 ms]
  Passed CanExecute(expected: True) [2 ms]
  Passed CanExecute(expected: False) [< 1 ms]
  Passed GenericExecuteWithCanExecute [< 1 ms]
  Passed GenericThrowsWithNullExecute [< 1 ms]
  Passed Execute [< 1 ms]
  Passed GenericCanExecute(expected: True) [< 1 ms]
  Passed GenericCanExecute(expected: False) [< 1 ms]
  Passed ThrowsWithNullConstructor [< 1 ms]
  Passed ExecuteDoesNotRunIfParameterIsWrongValueType [< 1 ms]
  Passed GenericThrowsWithNullExecuteAndCanExecuteValid [< 1 ms]
  Passed ThrowsWithNullExecuteValidCanExecute [< 1 ms]
  Passed CanExecuteUsesParameterIfReferenceTypeAndSetToNull [< 1 ms]
  Passed ChangeCanExecute [< 1 ms]
  Passed GenericExecute [< 1 ms]
  Passed ThrowsWithNullCanExecute [< 1 ms]
  Passed ThrowsWithNullParameterizedConstructor [< 1 ms]
  Passed CanExecuteUsesParameterIfNullableAndSetToNull [< 1 ms]
  Passed ExecuteDoesNotRunIfValueTypeAndSetToNull [< 1 ms]
  Passed Constructor [< 1 ms]
  Passed ThrowsWithNullParameterizedCanExecute [< 1 ms]
[xUnit.net 00:00:02.00]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed ExecuteRunsIfNullableAndSetToNull [< 1 ms]
  Passed ExecuteParameterized [1 ms]
  Passed GenericThrowsWithValidExecuteAndCanExecuteNull [< 1 ms]
  Passed ExecuteWithCanExecute [< 1 ms]
  Passed CanExecuteReturnsFalseIfParameterIsWrongReferenceType [< 1 ms]

Total tests: 45
Test Run Failed.
     Passed: 44
     Failed: 1
 Total time: 2.3741 Seconds

🟢 With fix — 🧪 CommandTests: PASS ✅ · 23s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  TestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.09]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.73]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.74]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
  Passed CanExecuteReturnsFalseIfParameterIsWrongValueType [3 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchBar), useWeakEventHandler: False) [44 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.MenuItem), useWeakEventHandler: True) [33 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.ImageButton), useWeakEventHandler: False) [32 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SwipeItemView), useWeakEventHandler: False) [34 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.Button), useWeakEventHandler: False) [32 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.ImageButton), useWeakEventHandler: True) [30 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.RefreshView), useWeakEventHandler: False) [33 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.TextCell), useWeakEventHandler: False) [31 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchHandler), useWeakEventHandler: True) [32 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SwipeItemView), useWeakEventHandler: True) [31 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.MenuItem), useWeakEventHandler: False) [32 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.RefreshView), useWeakEventHandler: True) [33 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.TextCell), useWeakEventHandler: True) [30 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.Button), useWeakEventHandler: True) [32 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchBar), useWeakEventHandler: True) [31 ms]
  Passed CommandsSubscribedToCanExecuteCollect(controlType: typeof(Microsoft.Maui.Controls.SearchHandler), useWeakEventHandler: False) [32 ms]
  Passed ExecuteDoesNotRunIfParameterIsWrongReferenceType [< 1 ms]
  Passed ExecuteRunsIfReferenceTypeAndSetToNull [< 1 ms]
  Passed CanExecuteIgnoresParameterIfValueTypeAndSetToNull [< 1 ms]
  Passed CanExecute(expected: True) [1 ms]
  Passed CanExecute(expected: False) [< 1 ms]
  Passed GenericExecuteWithCanExecute [< 1 ms]
  Passed GenericThrowsWithNullExecute [< 1 ms]
  Passed Execute [< 1 ms]
  Passed GenericCanExecute(expected: True) [< 1 ms]
  Passed GenericCanExecute(expected: False) [< 1 ms]
  Passed ThrowsWithNullConstructor [< 1 ms]
  Passed ExecuteDoesNotRunIfParameterIsWrongValueType [< 1 ms]
  Passed GenericThrowsWithNullExecuteAndCanExecuteValid [< 1 ms]
  Passed ThrowsWithNullExecuteValidCanExecute [< 1 ms]
  Passed CanExecuteUsesParameterIfReferenceTypeAndSetToNull [< 1 ms]
  Passed ChangeCanExecute [< 1 ms]
  Passed GenericExecute [< 1 ms]
  Passed ThrowsWithNullCanExecute [< 1 ms]
  Passed ThrowsWithNullParameterizedConstructor [< 1 ms]
[xUnit.net 00:00:01.31]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed CanExecuteUsesParameterIfNullableAndSetToNull [< 1 ms]
  Passed ExecuteDoesNotRunIfValueTypeAndSetToNull [< 1 ms]
  Passed Constructor [< 1 ms]
  Passed ThrowsWithNullParameterizedCanExecute [< 1 ms]
  Passed ExecuteRunsIfNullableAndSetToNull [< 1 ms]
  Passed ExecuteParameterized [1 ms]
  Passed GenericThrowsWithValidExecuteAndCanExecuteNull [< 1 ms]
  Passed ExecuteWithCanExecute [< 1 ms]
  Passed CanExecuteReturnsFalseIfParameterIsWrongReferenceType [< 1 ms]

Test Run Successful.
Total tests: 45
     Passed: 45
 Total time: 1.6163 Seconds

🔴 Without fix — 🧪 SwipeViewTests: FAIL ✅ · 7s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  TestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.09]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.80]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.81]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestSwipeItemView [21 ms]
  Passed TestContentBindingContextPropagatesToPassedInSwipeItem [5 ms]
  Passed BindingContextTransfersToNewSetOfSwipeItems [2 ms]
  Passed TestRightItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToAddedSwipeItems [< 1 ms]
  Passed SwipeViewFindsScrollParentDirectlyWhenTreeIsConnected [1 ms]
  Passed TestBottomItems [< 1 ms]
  Passed TestDefaultSwipeItems [2 ms]
  Passed SwipeViewResubscribesToScrollParentAfterRemovalAndReaddition [< 1 ms]
[xUnit.net 00:00:00.90]       Assert.False() Failure
[xUnit.net 00:00:00.90]       Expected: False
[xUnit.net 00:00:00.90]       Actual:   True
[xUnit.net 00:00:00.90]       Stack Trace:
[xUnit.net 00:00:00.90]         /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs(449,0): at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.SwipeItemViewCommandCanExecuteUpdatesIsEnabled()
[xUnit.net 00:00:00.90]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:00.90]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Passed TestConstructor [< 1 ms]
  Passed TestSwipeViewBindingContextChangedEvent [< 1 ms]
  Passed TestProgrammaticallyClose [< 1 ms]
  Passed TestSwipeItemsSwipeBehaviorOnInvoked [< 1 ms]
  Passed SwipeItemsRemainInLogicalTreeWhenContentIsSet [12 ms]
  Passed TestContentBindingContextChangedEvent [< 1 ms]
  Passed TestTemplatedContentBindingContextChangedEvent [< 1 ms]
  Failed SwipeItemViewCommandCanExecuteUpdatesIsEnabled [2 ms]
  Error Message:
   Assert.False() Failure
Expected: False
Actual:   True
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.SwipeViewTests.SwipeItemViewCommandCanExecuteUpdatesIsEnabled() in /_/src/Controls/tests/Core.UnitTests/SwipeViewTests.cs:line 449
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
[xUnit.net 00:00:00.90]     SwipeItemViewCommandCanExecuteUpdatesIsEnabled [FAIL]
  Passed TestProgrammaticallyOpen [< 1 ms]
[xUnit.net 00:00:00.90]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed ClearRemovesLogicalChildren [< 1 ms]
  Passed TestLeftItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToNewSwipeItems [< 1 ms]
  Passed TestSwipeItemsExecuteMode [< 1 ms]
  Passed TestTopItems [< 1 ms]
  Passed SwipeViewRediscoversScrollParentWhenTemplateRootIsReparented [< 1 ms]
  Passed SwipeViewFindsScrollParentAfterTemplateParentConnected [< 1 ms]

Test Run Failed.
Total tests: 25
     Passed: 24
     Failed: 1
 Total time: 1.2656 Seconds

🟢 With fix — 🧪 SwipeViewTests: PASS ✅ · 7s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14135210
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  TestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.09]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.72]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:00.73]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
  Passed TestSwipeItemView [17 ms]
  Passed TestContentBindingContextPropagatesToPassedInSwipeItem [5 ms]
  Passed BindingContextTransfersToNewSetOfSwipeItems [2 ms]
  Passed TestRightItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToAddedSwipeItems [< 1 ms]
  Passed SwipeViewFindsScrollParentDirectlyWhenTreeIsConnected [1 ms]
  Passed TestBottomItems [< 1 ms]
  Passed TestDefaultSwipeItems [2 ms]
  Passed SwipeViewResubscribesToScrollParentAfterRemovalAndReaddition [< 1 ms]
  Passed TestConstructor [< 1 ms]
  Passed TestSwipeViewBindingContextChangedEvent [< 1 ms]
  Passed TestProgrammaticallyClose [1 ms]
  Passed TestSwipeItemsSwipeBehaviorOnInvoked [< 1 ms]
  Passed SwipeItemsRemainInLogicalTreeWhenContentIsSet [11 ms]
  Passed TestContentBindingContextChangedEvent [< 1 ms]
  Passed TestTemplatedContentBindingContextChangedEvent [< 1 ms]
  Passed SwipeItemViewCommandCanExecuteUpdatesIsEnabled [2 ms]
  Passed TestProgrammaticallyOpen [< 1 ms]
[xUnit.net 00:00:00.81]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed ClearRemovesLogicalChildren [< 1 ms]
  Passed TestLeftItems [< 1 ms]
  Passed TestContentBindingContextPropagatesToNewSwipeItems [< 1 ms]
  Passed TestSwipeItemsExecuteMode [< 1 ms]
  Passed TestTopItems [< 1 ms]
  Passed SwipeViewRediscoversScrollParentWhenTemplateRootIsReparented [< 1 ms]
  Passed SwipeViewFindsScrollParentAfterTemplateParentConnected [< 1 ms]

Test Run Successful.
Total tests: 25
     Passed: 25
 Total time: 1.1910 Seconds

📁 Fix files reverted (6 files)

• src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
• src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt
• src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
• src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt
• src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt
• src/Controls/src/Core/SwipeView/SwipeItemView.cs

---

🧪 UI Tests — SwipeView

Detected UI test categories: SwipeView

✅ Deep UI tests — 69 passed, 0 failed across 1 category on platform-pool agent (replaces in-process counts above).

🧪 UI Test Execution Results (deep, platform pool)

Category	Tests	Snapshot diffs
controls-SwipeView	69/69 ✓	—
📎 Download drop-deep-uitests artifact (TRX + snapshot diffs)

---

🔍 Pre-Flight — Context & Validation

Pre-Flight: PR #35510 — Fix SwipeItemView command leak

Issue #35498 summary

SwipeItemView.Command subscribes directly to ICommand.CanExecuteChanged and unsubscribes only when the Command property changes. When the same long-lived ICommand instance is shared across many rows (e.g. from a page/shell/service VM), the command keeps each SwipeItemView (and its CommandParameter, Content, BindingContext, row VM, and per-row payload) alive forever.

Observed (issue repro):

• iOS: 1,000 retained rows / ~125 MiB after closing the host page (vs. 0 / 0 MiB for the SwipeItem-based control path).
• Android: 1,000 / ~125 MiB (vs. 160 / 20 MiB platform baseline).

Repro retains via:

long-lived ICommand
  -> CanExecuteChanged
  -> SwipeItemView.OnCommandCanExecuteChanged   // strong delegate -> instance
  -> SwipeItemView
  -> CommandParameter / Content / BindingContext

PR #35510 fix (canonical approach)

The PR makes SwipeItemView implement ICommandElement and reuses MAUI's existing weak-subscription infrastructure (the same one used by Button, MenuItem, CheckBox, RefreshView, SearchBar, SearchHandler, ImageButton, TextCell):

1. CommandProperty / CommandParameterProperty wired to CommandElement.OnCommandChanging, OnCommandChanged, OnCommandParameterChanged.
2. CommandProperty.DependsOn(CommandParameterProperty) so binding-order timing is handled (see CommandParameter TemplateBinding Lost During ControlTemplate Reparenting #31939).
3. ICommandElement.CleanupTracker = new WeakCommandSubscription(...) — uses a DependentHandle(bindable, handler). The handler is reachable only while the bindable is reachable, so the command no longer keeps the view alive.
4. IsEnabledCore override composes base.IsEnabledCore && Command.CanExecute(CommandParameter), so an explicit IsEnabled=false (or a disabled parent) is not stomped on the next CanExecuteChanged callback.
5. ICommandElement.CanExecuteChanged → RefreshIsEnabledProperty().

Tests added by the PR (gate)

• CommandsSubscribedToCanExecuteCollect(SwipeItemView, true|false) (in CommandTests) — proves the command no longer retains the view: forces GC and asserts the WeakReference<SwipeItemView> is collected. This is the leak gate.
• SwipeItemViewCommandCanExecuteUpdatesIsEnabled (in SwipeViewTests) — proves behavioral semantics:
  • CanExecute=false ⇒ IsEnabled=false.
  • CanExecuteChanged toggles IsEnabled.
  • Changing CommandParameter re-evaluates CanExecute.
  • IsEnabled=false overrides a CanExecute=true (sticky on next CanExecuteChanged). This last assertion can only be satisfied by composing through IsEnabledCore — a setter-based "IsEnabled = CanExecute" approach would flip it back to true on the next CanExecuteChanged.

Gate result

✅ PASSED (per separate gate phase): tests fail on base, pass with PR.

Implications for alternative candidates

The PR's approach is the canonical MAUI pattern for this exact problem. Meaningful alternatives must differ either in:

• A. Subscription mechanism — hand-rolled weak (WeakReference<T> closure, WeakEventManager, etc.) instead of WeakCommandSubscription/DependentHandle. Functionally equivalent at best; more code; same outcome.
• B. IsEnabled composition — set IsEnabled property directly (original design) instead of IsEnabledCore override. Demonstrably regresses the "explicit IsEnabled=false is sticky" assertion in the new test.
• C. No subscription at all — lazy CanExecute only at OnInvoked time. Loses reactive IsEnabled updates → regresses the SwipeItemViewCommandCanExecuteUpdatesIsEnabled test.

Any alternative must (1) eliminate the strong reference from command -> view, (2) reactively update IsEnabled on CanExecuteChanged, (3) honor explicit IsEnabled=false. The PR satisfies all three with the least amount of bespoke code.

Base / branch

• Base: main @ eb20ff6e
• PR head: 5ef8007b (working branch pr-review-35510 @ 2236d7be — squashed PR diff).

---

🔧 Fix — Analysis & Comparison

Try-Fix Aggregate — PR #35510

Summary

Two alternative fix candidates were generated and tested against the PR's gate (CommandTests + SwipeViewTests, iOS-targeting unit tests). Both were chosen to explore meaningfully different axes from the PR's approach.

#	Approach	Tests passed	Verdict
1	Hand-rolled WeakReference<SwipeItemView> closure + IsEnabledCore composition (replaces canonical ICommandElement/WeakCommandSubscription)	70/70 ✅	Functionally equivalent to PR; strictly worse (more bespoke code, no DependsOn/GetCanExecute binding-timing protection for #31939, divergent from other MAUI commandable controls)
2	No subscription at all — lazy CanExecute evaluation only on property changes	69/70 ❌	Invalid — regresses SwipeItemViewCommandCanExecuteUpdatesIsEnabled because IsEnabled no longer reactively tracks CanExecuteChanged events between property writes

Design constraints established by gate tests

1. Weak subscription required. CommandsSubscribedToCanExecuteCollect(SwipeItemView, …) mandates that the command does not retain the view.
2. Reactive subscription required. SwipeItemViewCommandCanExecuteUpdatesIsEnabled mandates that IsEnabled updates when ICommand.CanExecuteChanged fires (i.e., the lazy/no-subscription approach is ruled out).
3. IsEnabledCore composition required. The last assertion of SwipeItemViewCommandCanExecuteUpdatesIsEnabled (explicit IsEnabled=false sticky across a subsequent ChangeCanExecute) is impossible to satisfy with the original "IsEnabled = Command.CanExecute(...)" setter pattern; only an IsEnabledCore override composes correctly.

The PR's fix is the only design that satisfies all three constraints and reuses the canonical ICommandElement pattern already used by Button, MenuItem, CheckBox, RefreshView, SearchBar, SearchHandler, ImageButton, and TextCell, and inherits the CommandElement.GetCanExecute binding-timing fix from #31939.

Recommendation

Approve PR #35510 as-is. No demonstrably better alternative exists in the explored design space. The PR is consistent with the established MAUI pattern, minimal in bespoke code, and passes all gate tests.

Details for each candidate are in try-fix-1/content.md and try-fix-2/content.md.

Phase metadata

• Platform: iOS (unit tests, runs on macOS host, .NET 10)
• Base: main @ eb20ff6e
• PR head: 5ef8007b
• Gate (separately verified): ✅ PASSED
• Try-fix candidates: 2 (1 functionally-valid-but-worse, 1 invalid). Search stopped — no meaningfully different axes remain.

---

📋 Report — Final Recommendation

Comparative Report — PR #35510

Candidates compared

Candidate	Approach	Gate tests	Verdict
pr	ICommandElement + WeakCommandSubscription + IsEnabledCore (canonical MAUI pattern).	✅ 17/17 pass (per gate phase).	Correct fix; 4 PublicAPI.Unshipped.txt files have an accidental BOM.
pr-plus-reviewer	pr + strip accidental UTF-8 BOM from 4 PublicAPI.Unshipped.txt files.	✅ 17/17 pass (re-verified on candidate).	Strictly better than pr — same correct fix + minor hygiene cleanup.
try-fix-1	Hand-rolled WeakReference<SwipeItemView> closure + IsEnabledCore (replaces canonical ICommandElement).	✅ 70/70 gate pass.	Functionally equivalent to PR but ~3× bespoke code, loses DependsOn/GetCanExecute binding-timing protection from #31939, diverges from 8 other commandable controls. Worse than PR.
try-fix-2	No subscription at all — lazy CanExecute on property changes only.	❌ 69/70 — regresses SwipeItemViewCommandCanExecuteUpdatesIsEnabled (line 436: command.ChangeCanExecute() no longer reactively updates IsEnabled).	Invalid — behavioral regression.

Ranking (failing-regression candidates ranked below passing ones, as required)

1. 🥇 pr-plus-reviewer — passes gate, canonical fix, no hygiene issues.
2. 🥈 pr — passes gate, canonical fix, minor BOM hygiene issue.
3. 🥉 try-fix-1 — passes gate, but functionally redundant and strictly inferior on consistency/binding-timing/maintainability.
4. ❌ try-fix-2 — fails gate (regresses behavioral test). Ranked below all passing candidates per scoring rule.

Dimensions

Dimension	pr	pr-plus-reviewer	try-fix-1	try-fix-2
Leak fix (gate test)	✅	✅	✅	✅ (trivially — no subscription)
Reactive CanExecuteChanged → IsEnabled	✅	✅	✅	❌
Sticky explicit IsEnabled=false	✅	✅	✅	✅
CommandParameter binding-timing fix (#31939)	✅ (via GetCanExecute)	✅	❌	❌
Consistency with 8 other MAUI commandable controls	✅	✅	❌ (bespoke)	❌ (bespoke)
Lines of bespoke code	~16	~16	~45	~6 (but invalid)
PublicAPI.Unshipped.txt hygiene	❌ (BOM noise)	✅	n/a	n/a

Winner: pr-plus-reviewer

The PR's substantive code change is already optimal — it is the canonical MAUI commandable-control pattern, reuses shared infrastructure (WeakCommandSubscription/DependentHandle), inherits the #31939 binding-timing fix, and satisfies all behavioral invariants the new tests pin (including the subtle "explicit IsEnabled=false is sticky" assertion that rules out a naive setter-based design). The only actionable reviewer feedback is the accidental UTF-8 BOM addition to 4 of the 5 PublicAPI.Unshipped.txt files. Stripping the BOM is a 40-line, text-file-only delta that re-verifies green against the full gate (17/17). Therefore pr-plus-reviewer is strictly better than pr (same behavior + cleaner artifact) and strictly better than every try-fix candidate explored.

Recommendation for the human reviewer: approve the PR, optionally request the BOM cleanup as a nit (or post it as inline review comments — captured in inline-findings.json).

Phase metadata

• Platform: iOS (unit tests, .NET 10, macOS host)
• Base: main @ eb20ff6eca
• PR head: 5ef8007b
• Gate (separately verified): ✅ PASSED
• Candidates evaluated: 4 (pr, pr-plus-reviewer, try-fix-1, try-fix-2)

---

[kubaflo]

/azp run maui-pr

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kubaflo]

/azp run maui-pr

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kubaflo]

/review -b feature/regression-check -p android