Fix Entry select all text on refocus not working on WinUI

[kubaflo]

Description of Change

Fixes the issue where setting CursorPosition and SelectionLength on an Entry during the Focused event only works on the first focus but not on subsequent focuses on WinUI.

Root cause: When the same cursor position / selection length values are set again, the bindable property system detects no change and skips propagation to the native WinUI TextBox. The native control then handles the focus input event and moves the cursor, overriding the intended selection.

Fix:

• Override OnBindablePropertySet in InputView to always push CursorPosition and SelectionLength to the native handler even when the value has not changed.
• In TextBoxExtensions, only write back the clamped value when it actually differs from the current value, preventing the clamping assignment from blocking the xplat → native flow.

Review suggestions applied from #23329:

• Changed IssueTracker.ManualTest → IssueTracker.Github, 23329 so the test runner correlates the page with the automated test class
• Changed PlatformAffected.UWP → PlatformAffected.Windows (correct value for .NET MAUI)
• Removed unused using System.Diagnostics; import

Based on the work by @Foda in #23329.

Issues Fixed

Supersedes #23329

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35383

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35383"

[Copilot]

Pull request overview

Fixes a WinUI-specific Entry behavior where setting CursorPosition/SelectionLength during Focused works on first focus but not on subsequent focuses, by ensuring the xplat → native update flow still runs even when the bindable-property value is re-set to the same value.

Changes:

• Force handler value updates for CursorPosition and SelectionLength even when the bindable-property system reports changed == false.
• Avoid redundant “clamping write-back” to ITextInput.CursorPosition / SelectionLength in the WinUI TextBox extensions (only write back when the clamped value differs).
• Add a WinUI visual regression test + HostApp repro page for the refocus “select all” scenario.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Core/src/Platform/Windows/TextBoxExtensions.cs	Prevents redundant clamping assignments that can interfere with repeated selection updates.
src/Controls/src/Core/InputView/InputView.cs	Forces handler updates for cursor/selection even when values are set to the same value.
src/Controls/tests/TestCases.WinUI.Tests/EntrySelectionTest.cs	Adds a WinUI screenshot-based regression test for select-all-on-refocus.
src/Controls/tests/TestCases.HostApp/Issues/EntrySelectionTest.xaml	Adds the HostApp UI needed to reproduce/validate the scenario.
src/Controls/tests/TestCases.HostApp/Issues/EntrySelectionTest.xaml.cs	Implements the Focused handler that sets cursor position + selection length.

[kubaflo]

/review -b feature/regression-check -p windows

[kubaflo]

/azp run maui-pr

[kubaflo]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kubaflo]

/review -b feature/refactor-copilot-yml -p windows

[MauiBot]

Expert Review — 1 findings

See inline comments for details.

[MauiBot]

[moderate] Cross-Platform Consistency / Regression Prevention - This shared InputView override changes same-value CursorPosition/SelectionLength propagation for every Entry/Editor handler, not just WinUI. The regression and bug are Windows-specific, but Android/iOS/Tizen now receive extra mapper updates when app code re-sets the same selection values, and those handlers have platform-specific focus/timing behavior. Please either scope the forced same-value update to Windows (for example by moving this override into a Windows-specific partial/guard) or add non-Windows coverage proving same-value selection updates do not move or corrupt caret/selection state.

[MauiBot]

🤖 Automated review — alternative fix proposed

The expert-reviewer evaluation compared the PR fix against #2 automatically generated candidates and selected try-fix-2 as the strongest fix.

Why: try-fix-2 passed the Windows Issue23329 regression and fixes the WinUI Entry refocus ordering problem in the narrowest affected layer. The PR fix also passed and has no expert inline findings, but it changes shared InputView same-value cursor/selection propagation across platforms and controls.

Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.

Candidate diff (`try-fix-2`)

diff --git a/src/Core/src/Handlers/Entry/EntryHandler.Windows.cs b/src/Core/src/Handlers/Entry/EntryHandler.Windows.cs
index 6b7ec0c2d8..fd06b845b1 100644
--- a/src/Core/src/Handlers/Entry/EntryHandler.Windows.cs
+++ b/src/Core/src/Handlers/Entry/EntryHandler.Windows.cs
@@ -1,11 +1,13 @@
 #nullable enable
 using System;
 using Microsoft.Maui.Devices;
+using Microsoft.Maui.Platform;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 using Microsoft.UI.Xaml.Input;
 using Microsoft.UI.Xaml.Media;
 using Windows.System;
+using WFocusManager = Microsoft.UI.Xaml.Input.FocusManager;
 
 namespace Microsoft.Maui.Handlers
 {
@@ -35,6 +37,11 @@ namespace Microsoft.Maui.Handlers
 			platformView.KeyUp += OnPlatformKeyUp;
 			platformView.TextChanged += OnPlatformTextChanged;
 			platformView.SizeChanged += OnPlatformViewSizeChanged;
+
+			// Subscribe AFTER ViewHandler's static FocusManager.GotFocus handler so our
+			// callback runs AFTER MAUI has set VirtualView.IsFocused = true (which
+			// raises the Focused event and runs any user-provided Focused handler).
+			WFocusManager.GotFocus += OnFocusManagerGotFocus;
 		}
 
 		protected override void DisconnectHandler(TextBox platformView)
@@ -43,6 +50,8 @@ namespace Microsoft.Maui.Handlers
 			platformView.KeyUp -= OnPlatformKeyUp;
 			platformView.TextChanged -= OnPlatformTextChanged;
 
+			WFocusManager.GotFocus -= OnFocusManagerGotFocus;
+
 			if (_set)
 				platformView.SelectionChanged -= OnPlatformSelectionChanged;
 
@@ -141,5 +150,39 @@ namespace Microsoft.Maui.Handlers
 
 		void OnPlatformViewSizeChanged(object sender, SizeChangedEventArgs e) =>
 			MauiTextBox.InvalidateAttachedProperties(PlatformView);
+
+		// Root-cause fix for Entry select-all-on-refocus on WinUI:
+		//
+		// When the Entry is re-focused and the user's Focused handler sets
+		// CursorPosition / SelectionLength to the SAME values as the previous focus,
+		// InputView's bindable-property change tracking sees "no change" and skips
+		// the platform mapper. The TextBox therefore never receives a fresh selection
+		// update, and WinUI's pointer-driven caret placement wins: typing inserts
+		// at the click position instead of replacing the selected text.
+		//
+		// FocusManager.GotFocus is a static singleton event whose subscribers fire in
+		// subscription order. ViewHandler.Windows subscribes its handler from its
+		// static constructor (which runs before any per-instance work), so any
+		// per-instance subscription we add here is guaranteed to run AFTER MAUI has
+		// set VirtualView.IsFocused = true, which is the exact point at which the
+		// user's Focused handler has run, possibly re-applying same-value selection
+		// state. Forcing the platform mappers to run at that moment pushes the
+		// (possibly unchanged) requested selection back to the TextBox.
+		void OnFocusManagerGotFocus(object? sender, FocusManagerGotFocusEventArgs e)
+		{
+			if (e?.NewFocusedElement != (object?)PlatformView)
+				return;
+
+			if (VirtualView is not { } virtualView)
+				return;
+
+			// Re-push the requested selection state to the platform TextBox. Unlike
+			// going through Handler.UpdateValue, this calls the extension methods
+			// directly and unconditionally, guarding against the case where the
+			// bindable property's value never changed across refocus cycles so the
+			// mapper would otherwise be skipped entirely.
+			PlatformView.UpdateCursorPosition(virtualView);
+			PlatformView.UpdateSelectionLength(virtualView);
+		}
 	}
 }

[MauiBot]

🤖 AI Summary

👋 @kubaflo — new AI review results are available. Please review the latest session below.

📊 Review Session — 503f3a0 · Fix nullable syntax in Issue23329 test page · 2026-05-26 23:32 UTC

🚦 Gate — Test Before & After Fix

Gate Result: ✅ PASSED

Platform: WINDOWS · Base: main · Merge base: b0ea772f

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🖥️ Issue23329 Issue23329	✅ FAIL — 503s	✅ PASS — 486s

🔴 Without fix — 🖥️ Issue23329: FAIL ✅ · 503s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Graphics -> D:\a\1\s\artifacts\bin\Graphics\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Graphics.Win2D -> D:\a\1\s\artifacts\bin\Graphics.Win2D\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Graphics.Win2D.WinUI.Desktop.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Essentials -> D:\a\1\s\artifacts\bin\Essentials\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Core -> D:\a\1\s\artifacts\bin\Core\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.dll
  Controls.BindingSourceGen -> D:\a\1\s\artifacts\bin\Controls.BindingSourceGen\Debug\netstandard2.0\Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Controls.Core -> D:\a\1\s\artifacts\bin\Controls.Core\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Maps -> D:\a\1\s\artifacts\bin\Maps\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Maps.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> D:\a\1\s\artifacts\bin\Microsoft.AspNetCore.Components.WebView.Maui\Debug\net10.0-windows10.0.19041.0\Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Foldable -> D:\a\1\s\artifacts\bin\Controls.Foldable\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.Foldable.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Controls.Maps -> D:\a\1\s\artifacts\bin\Controls.Maps\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.Maps.dll
  Controls.Xaml -> D:\a\1\s\artifacts\bin\Controls.Xaml\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.Xaml.dll
  Controls.TestCases.HostApp -> D:\a\1\s\artifacts\bin\Controls.TestCases.HostApp\Debug\net10.0-windows10.0.19041.0\win-x64\Controls.TestCases.HostApp.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:06:08.55
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Graphics -> D:\a\1\s\artifacts\bin\Graphics\Debug\net10.0\Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Essentials -> D:\a\1\s\artifacts\bin\Essentials\Debug\net10.0\Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Core -> D:\a\1\s\artifacts\bin\Core\Debug\net10.0\Microsoft.Maui.dll
  Controls.CustomAttributes -> D:\a\1\s\artifacts\bin\Controls.CustomAttributes\Debug\net10.0\Controls.CustomAttributes.dll
  Controls.Core.Design -> D:\a\1\s\artifacts\bin\Controls.Core.Design\Debug\net472\Microsoft.Maui.Controls.DesignTools.dll
  Controls.BindingSourceGen -> D:\a\1\s\artifacts\bin\Controls.BindingSourceGen\Debug\netstandard2.0\Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Controls.Core -> D:\a\1\s\artifacts\bin\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.dll
  UITest.Core -> D:\a\1\s\artifacts\bin\UITest.Core\Debug\net10.0\UITest.Core.dll
  UITest.NUnit -> D:\a\1\s\artifacts\bin\UITest.NUnit\Debug\net10.0\UITest.NUnit.dll
  VisualTestUtils -> D:\a\1\s\artifacts\bin\VisualTestUtils\Debug\netstandard2.0\VisualTestUtils.dll
  UITest.Appium -> D:\a\1\s\artifacts\bin\UITest.Appium\Debug\net10.0\UITest.Appium.dll
  VisualTestUtils.MagickNet -> D:\a\1\s\artifacts\bin\VisualTestUtils.MagickNet\Debug\netstandard2.0\VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> D:\a\1\s\artifacts\bin\UITest.Analyzers\Debug\netstandard2.0\UITest.Analyzers.dll
  Controls.TestCases.WinUI.Tests -> D:\a\1\s\artifacts\bin\Controls.TestCases.WinUI.Tests\Debug\net10.0\Controls.TestCases.WinUI.Tests.dll
Test run for D:\a\1\s\artifacts\bin\Controls.TestCases.WinUI.Tests\Debug\net10.0\Controls.TestCases.WinUI.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in D:\a\1\s\artifacts\bin\Controls.TestCases.WinUI.Tests\Debug\net10.0\Controls.TestCases.WinUI.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 5/26/2026 9:18:15 PM FixtureSetup for Issue23329(Windows)
>>>>> 5/26/2026 9:18:23 PM EntrySelectAllOnRefocusReplacesText Start
>>>>> 5/26/2026 9:18:28 PM EntrySelectAllOnRefocusReplacesText Stop
>>>>> 5/26/2026 9:18:28 PM Log types: 
  Failed EntrySelectAllOnRefocusReplacesText [5 s]
  Error Message:
     Assert.That(text, Is.EqualTo("X"))
  Expected string length 1 but was 6. Strings differ at index 0.
  Expected: "X"
  But was:  "HelloX"
  -----------^

  Stack Trace:
     at Microsoft.Maui.TestCases.Tests.Issues.Issue23329.EntrySelectAllOnRefocusReplacesText() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23329.cs:line 41

1)    at Microsoft.Maui.TestCases.Tests.Issues.Issue23329.EntrySelectAllOnRefocusReplacesText() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23329.cs:line 41


NUnit Adapter 4.5.0.0: Test execution complete
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.13]   Discovering: Controls.TestCases.WinUI.Tests
[xUnit.net 00:00:00.33]   Discovered:  Controls.TestCases.WinUI.Tests
Results File: D:\a\1\s\CustomAgentLogsTmp\UITests\TestResults\Issue23329.trx

Total tests: 1
     Failed: 1
Test Run Failed.
 Total time: 28.1415 Seconds
>>> TRX_RESULT_FILE: D:\a\1\s\CustomAgentLogsTmp\UITests\TestResults\Issue23329.trx

🟢 With fix — 🖥️ Issue23329: PASS ✅ · 486s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Graphics -> D:\a\1\s\artifacts\bin\Graphics\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Essentials -> D:\a\1\s\artifacts\bin\Essentials\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Essentials.dll
  Graphics.Win2D -> D:\a\1\s\artifacts\bin\Graphics.Win2D\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Graphics.Win2D.WinUI.Desktop.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Core -> D:\a\1\s\artifacts\bin\Core\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.dll
  Controls.BindingSourceGen -> D:\a\1\s\artifacts\bin\Controls.BindingSourceGen\Debug\netstandard2.0\Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Maps -> D:\a\1\s\artifacts\bin\Maps\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Maps.dll
  Controls.Core -> D:\a\1\s\artifacts\bin\Controls.Core\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Controls.Maps -> D:\a\1\s\artifacts\bin\Controls.Maps\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.Maps.dll
  Controls.Foldable -> D:\a\1\s\artifacts\bin\Controls.Foldable\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.Foldable.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> D:\a\1\s\artifacts\bin\Microsoft.AspNetCore.Components.WebView.Maui\Debug\net10.0-windows10.0.19041.0\Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> D:\a\1\s\artifacts\bin\Controls.Xaml\Debug\net10.0-windows10.0.19041.0\Microsoft.Maui.Controls.Xaml.dll
  Controls.TestCases.HostApp -> D:\a\1\s\artifacts\bin\Controls.TestCases.HostApp\Debug\net10.0-windows10.0.19041.0\win-x64\Controls.TestCases.HostApp.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:05:54.11
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Graphics -> D:\a\1\s\artifacts\bin\Graphics\Debug\net10.0\Microsoft.Maui.Graphics.dll
  Controls.CustomAttributes -> D:\a\1\s\artifacts\bin\Controls.CustomAttributes\Debug\net10.0\Controls.CustomAttributes.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Essentials -> D:\a\1\s\artifacts\bin\Essentials\Debug\net10.0\Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Core -> D:\a\1\s\artifacts\bin\Core\Debug\net10.0\Microsoft.Maui.dll
  Controls.Core.Design -> D:\a\1\s\artifacts\bin\Controls.Core.Design\Debug\net472\Microsoft.Maui.Controls.DesignTools.dll
  Controls.BindingSourceGen -> D:\a\1\s\artifacts\bin\Controls.BindingSourceGen\Debug\netstandard2.0\Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14198162
  Controls.Core -> D:\a\1\s\artifacts\bin\Controls.Core\Debug\net10.0\Microsoft.Maui.Controls.dll
  UITest.Core -> D:\a\1\s\artifacts\bin\UITest.Core\Debug\net10.0\UITest.Core.dll
  UITest.Appium -> D:\a\1\s\artifacts\bin\UITest.Appium\Debug\net10.0\UITest.Appium.dll
  UITest.NUnit -> D:\a\1\s\artifacts\bin\UITest.NUnit\Debug\net10.0\UITest.NUnit.dll
  VisualTestUtils -> D:\a\1\s\artifacts\bin\VisualTestUtils\Debug\netstandard2.0\VisualTestUtils.dll
  VisualTestUtils.MagickNet -> D:\a\1\s\artifacts\bin\VisualTestUtils.MagickNet\Debug\netstandard2.0\VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> D:\a\1\s\artifacts\bin\UITest.Analyzers\Debug\netstandard2.0\UITest.Analyzers.dll
  Controls.TestCases.WinUI.Tests -> D:\a\1\s\artifacts\bin\Controls.TestCases.WinUI.Tests\Debug\net10.0\Controls.TestCases.WinUI.Tests.dll
Test run for D:\a\1\s\artifacts\bin\Controls.TestCases.WinUI.Tests\Debug\net10.0\Controls.TestCases.WinUI.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in D:\a\1\s\artifacts\bin\Controls.TestCases.WinUI.Tests\Debug\net10.0\Controls.TestCases.WinUI.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 5/26/2026 9:26:22 PM FixtureSetup for Issue23329(Windows)
>>>>> 5/26/2026 9:26:30 PM EntrySelectAllOnRefocusReplacesText Start
>>>>> 5/26/2026 9:26:35 PM EntrySelectAllOnRefocusReplacesText Stop
  Passed EntrySelectAllOnRefocusReplacesText [4 s]
NUnit Adapter 4.5.0.0: Test execution complete
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.14]   Discovering: Controls.TestCases.WinUI.Tests
[xUnit.net 00:00:00.39]   Discovered:  Controls.TestCases.WinUI.Tests
Results File: D:\a\1\s\CustomAgentLogsTmp\UITests\TestResults\Issue23329.trx

Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 28.1293 Seconds
>>> TRX_RESULT_FILE: D:\a\1\s\CustomAgentLogsTmp\UITests\TestResults\Issue23329.trx

📁 Fix files reverted (3 files)

• eng/pipelines/ci-copilot.yml
• src/Controls/src/Core/InputView/InputView.cs
• src/Core/src/Platform/Windows/TextBoxExtensions.cs

---

🧪 UI Tests — Entry,ViewBaseTests

Detected UI test categories: Entry,ViewBaseTests

✅ Deep UI tests — 215 passed, 0 failed across 2 categories on platform-pool agent (replaces in-process counts above).

🧪 UI Test Execution Results (deep, platform pool)

Category	Tests	Snapshot diffs
Entry	100/101 ✓	—
ViewBaseTests	115/115 ✓	—
📎 Download drop-deep-uitests artifact (TRX + snapshot diffs)

---

🔍 Regression Cross-Reference

🔍 Regression Cross-Reference

🟢 No regression risks detected. No labeled bug-fix PRs in the last 6 months touched the modified files.

---

🔍 Pre-Flight — Context & Validation

Issue: #23329 - [Windows] Fix select-all Entry select logic
PR: #35383 - Fix Entry select all text on refocus not working on WinUI
Platforms Affected: Windows / WinUI
Files Changed: 2 implementation, 2 test

Key Findings

• The reproduction sets CursorPosition = 0 and SelectionLength = Text.Length from Entry.Focused; first focus selects text, but later refocus reuses the same MAUI property values so WinUI TextBox does not receive the selection update before native focus input moves the caret.
• PR Fix Entry select all text on refocus not working on WinUI #35383 fixes this by forcing same-value CursorPosition and SelectionLength updates from shared InputView.OnBindablePropertySet, plus guarding Windows clamp write-backs in TextBoxExtensions to avoid re-entry loops.
• Regression coverage is a Windows UI test under the Entry category. Gate was already completed externally and passed (tests fail without fix, pass with fix); this run did not overwrite gate/content.md.
• Prior inline feedback noted stale comments and nullable syntax in the HostApp issue page; the current diff no longer shows nullable object? syntax.
• Impacted UI categories: Entry directly, and Focus indirectly because the bug depends on focus/refocus ordering.

Code Review Summary

Verdict: NEEDS_DISCUSSION
Confidence: medium
Errors: 0 | Warnings: 2 | Suggestions: 0

Key code review findings:

• src/Controls/src/Core/InputView/InputView.cs:327-335 shared same-value cursor/selection updates affect all Entry/Editor handlers, while only Windows received matching same-value write-back safeguards; Tizen selection callbacks/extensions may not have equivalent guards.
• Latest visible CI was not fully green/in-progress at review time; not investigated as PR-caused because this task focuses on alternative fix candidates.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #35383	Shared InputView.OnBindablePropertySet forces unchanged cursor/selection handler updates; Windows TextBoxExtensions avoids redundant clamp write-backs.	PASSED (Gate)	src/Controls/src/Core/InputView/InputView.cs, src/Core/src/Platform/Windows/TextBoxExtensions.cs, 2 UI test files	Original PR; concern is cross-platform blast radius from shared same-value propagation.

---

🔬 Code Review — Deep Analysis

Code Review PR #35383

Independent Assessment

What this changes: Forces unchanged CursorPosition/SelectionLength assignments on InputView to update the handler, and guards WinUI clamp write-backs from same-value re-entry. Adds a Windows UI regression test.
Inferred motivation: WinUI resets native selection on refocus, so re-applying the same MAUI selection values must still reach the native TextBox.

Reconciliation with PR Narrative

Author claims: Fixes Entry select-all-on-refocus on WinUI by propagating same-value cursor/selection updates and preventing Windows clamp re-entry.
Agreement/disagreement: The implementation matches the stated WinUI root cause. The description appears stale where it says the test changed to PlatformAffected.Windows; the current enum/code uses PlatformAffected.UWP.

Findings

Warning Shared same-value selection update may affect non-Windows handlers

src/Controls/src/Core/InputView/InputView.cs:327-335

The bug and Windows mapper safeguards are WinUI-specific, but the new InputView override forces unchanged cursor/selection mapper updates for all Entry/Editor handlers. Android/iOS mostly guard same-value native updates, but Tizen still assigns native cursor/selection values and writes selection callbacks back to the virtual view without equivalent guards (EntryExtensions.cs:90-103, EditorExtensions.cs:80-94, EntryHandler.Tizen.cs:149-167). This may be only redundant work if Tizen suppresses same-value callbacks, but the PR is globally enabling the same re-entry pattern it explicitly guarded on Windows. This needs platform-owner confirmation, Windows scoping, or equivalent non-Windows guards/coverage.

Warning CI is not currently green

Latest visible check runs include failures/in-progress items, including maui-pr-uitests (Android UITests Controls (API 30) CollectionView), maui-pr-uitests (WinUI UITests Controls Editor,Effects,Essentials,FlyoutPage,Focus,Fonts,Frame,Gestures,GraphicsView), and maui-pr-uitests (macOS UITests Controls WebView). I did not investigate whether these are PR-caused or infrastructure/flakes, but this prevents an LGTM verdict.

Devil's Advocate

The cross-platform concern depends on native Tizen controls firing callbacks for same-value assignments; if they do not, the impact is likely extra mapper work only. However, because the fix deliberately adds Windows equality guards while changing shared InputView behavior, the broader blast radius is real enough to require discussion.

Verdict: NEEDS_DISCUSSION

Confidence: medium
Summary: The WinUI fix direction and regression test are sound, but the shared InputView change affects non-Windows handlers without matching safeguards. CI is also not fully green in the latest visible checks.

---

🔧 Fix — Analysis & Comparison

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix-1 (claude-opus-4.6)	Windows-only EntryHandler GotFocus + SelectionChanged reconciliation re-applies desired virtual selection when native focus handling diverges.	FAIL	src/Core/src/Handlers/Entry/EntryHandler.Windows.cs	Test command failed during HostApp search/navigation before reaching Issue23329; no behavioral pass demonstrated.
2	try-fix-2 (claude-opus-4.7)	Windows-only EntryHandler per-instance FocusManager.GotFocus subscription replays UpdateCursorPosition/UpdateSelectionLength after MAUI Focused handlers run.	PASS	src/Core/src/Handlers/Entry/EntryHandler.Windows.cs	Passes Issue23329; avoids shared InputView cross-platform blast radius.
PR	PR #35383	Shared InputView.OnBindablePropertySet forces unchanged cursor/selection handler updates; Windows clamp write-backs are guarded.	PASSED (Gate)	4 files	Original PR; code-review concern is cross-platform blast radius from shared same-value propagation.

Cross-Pollination

Model	Round	New Ideas?	Details
claude-opus-4.6	1	Yes	Tried Windows-only focus/selection reconciliation; failed to demonstrate due HostApp search/navigation failure.
claude-opus-4.7	1	Yes	Tried Windows-only FocusManager.GotFocus ordering-based replay; passed targeted UI test.

Exhausted: No stopped because candidate #2 passed all required tests and is demonstrably better-scoped than the PR's shared fix.
Selected Fix: Candidate #2 passes the regression while limiting behavior changes to WinUI Entry handling instead of changing shared InputView behavior for all platforms.

---

📋 Report — Final Recommendation

Comparative Report — PR #35383

Candidates compared

Rank	Candidate	Test result	Assessment
1	try-fix-2	PASS	Best balance of correctness and scope. It fixes the WinUI refocus timing path inside EntryHandler.Windows.cs, passes the targeted Issue23329 UI regression, and avoids changing shared InputView semantics for non-Windows platforms or Editor.
2	pr	PASS	Correctly fixes the regression and has no expert inline findings, but does so by forcing same-value cursor/selection mapper updates from shared InputView, which has a broader cross-platform blast radius than the Windows-only root-cause fix.
2	pr-plus-reviewer	PASS	Identical to pr; the expert reviewer returned no actionable feedback to apply.
4	try-fix-1	FAIL	Lower-ranked by rule because its regression run failed. The failure was a HostApp navigation/search timeout before validating behavior, so it does not prove the code is wrong, but it did not produce a passing candidate.

Analysis

The raw PR fix is functional: the gate already proved the regression fails without the fix and passes with the fix, and the expert reviewer produced no inline findings. The Windows TextBoxExtensions guards also address the obvious re-entry risk introduced by forcing mapper updates on same-value CursorPosition and SelectionLength assignments.

However, the issue is specifically a WinUI Entry refocus ordering problem. try-fix-2 addresses that narrower root cause by replaying the requested cursor and selection state from the Windows EntryHandler after MAUI focus processing has raised the app's Focused handler. That keeps the behavioral change on Windows Entry, where the bug exists, instead of altering shared InputView property propagation for every platform and text input implementation.

try-fix-2 does rely on FocusManager.GotFocus event ordering and a per-handler subscription to a static WinUI event, but it unsubscribes in DisconnectHandler, filters to the handler's own PlatformView, and passed the targeted Windows regression. That tradeoff is preferable to the PR's larger shared-property semantic change.

Winner

Winner: try-fix-2

try-fix-2 is the single best candidate because it passed the regression test and fixes the Windows-specific root cause with the narrowest implementation scope. The PR and pr-plus-reviewer are acceptable and test-passing, but they rank below try-fix-2 because they change shared InputView same-value behavior beyond the affected platform/control path.

---