Fix TextColor null reset to restore platform defaults on iOS and Android by Shalini-Ashokan · Pull Request #35563 · dotnet/maui

Shalini-Ashokan · 2026-05-21T11:28:43Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

Button TextColor is set at runtime (for example, DarkRed) and then reset to null.
Expected behavior: the button text should return to the platform default color.

Root Cause

Setting TextColor applies native foreground/title overrides. When TextColor was reset to null, some handlers did not actively clear those native overrides.

Description of Change

Android : Saved each control’s original TextColors once and reused it when TextColor is null, restoring the real platform default.

iOS : Updated iOS button text color handling in ButtonExtensions.cs to clear overridden title colors when TextColor is null.

Validated the behavior in the following platforms

Android
Windows
iOS
Mac

Issues Fixed

Fixes #35513

Output ScreenShot

Android

Before	After
35513-Android-BeforeFix.mov	35513-AfterFix-Android.mov

iOS

Before	After
35513-BeforeFix-iOS.mov	35513-AfterFix-iOS.mov

github-actions · 2026-05-21T11:28:55Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35563

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35563"

dotnet-policy-service · 2026-05-21T11:29:12Z

Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

kubaflo · 2026-05-21T13:01:46Z

/review -b feature/regression-check -p ios

kubaflo · 2026-05-21T19:40:11Z

/review -b feature/regression-check

> [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## What Restrict the agentic-labeler to apply **exactly one `area-*` label** per item, while still allowing multiple `platform/*` labels. ## Why Backfilling the 26 items affected by the `max:1` bug (fixed in dotnet#35540) revealed that the labeler occasionally applies multiple `area-*` labels for ambiguous cases: - **dotnet#35501** got both `area-layout` and `area-safearea` - **dotnet#35490** got both `area-navigation` and `area-controls-tabbedpage` The intended behavior is exactly one best-fit `area-*` per item (a label-quota distinction not expressible via `safe-outputs.add-labels.max:` — that field counts total labels, not labels per prefix). The fix has to live in the agent's instructions. ## Changes ### `.github/skills/agentic-labeler/SKILL.md` - Scope section: "Exactly one `area-*`" / "One or more `platform/*`". - Area rules section: renamed heading, changed "pick one or more" → "apply exactly one". - New **tie-breaking heuristics** for the area-* selection: - Specific control beats generic area (`area-controls-tabbedpage` over `area-navigation`) - Sub-area beats parent area (`area-safearea` over `area-layout`) - Subject-matter focus beats incidental touch - When genuinely tied, prefer the user-visible feature - Mixed-PR rule clarified: infra-primary PRs get only `area-infrastructure` (no second product area). ### `.github/workflows/agentic-labeler.md` - Added explicit reinforcement in the workflow prompt: "Apply exactly one `area-*` label … and one or more `platform/*` labels". - Fixed two stale `max: 1` comments left over from dotnet#35540 (the cap is now `max: 10`). ### `.github/workflows/agentic-labeler.lock.yml` - Regenerated via `gh aw compile`. Diff is frontmatter-hash + heredoc rotations only — no semantic change to the compiled config. ## Validation - Reviewed all 21 existing eval scenarios in `tests/eval.yaml` — none assert multiple `area-*` labels, so no test updates needed. - The `max: 10` cap in `safe-outputs` is preserved as a blast-radius safeguard (one area + several platforms still fit comfortably). ## Follow-ups (not in this PR) If accuracy of the "one area" rule drops below ~95% in eval runs, consider adding a deterministic post-step that strips extra `area-*` labels per a known precedence list (Option B from the design discussion). Co-authored-by: bot <bot@test> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

sheiksyedm · 2026-05-22T06:13:27Z

/azp run maui-pr-uitests

azure-pipelines · 2026-05-22T06:13:40Z

Azure Pipelines successfully started running 1 pipeline(s).

kubaflo · 2026-05-22T10:42:32Z

/review -b feature/regression-check

## Description Extends the `maui-copilot` DevDiv pipeline (pipeline 27723) with a 3-stage architecture that runs real UI tests on platform-pool agents and reports results directly in the AI summary PR comment. ### Pipeline Workflow ``` ┌─────────────────────────────────────────────────────────┐ │ Stage 1: ReviewPR │ │ │ │ STEP 1: Branch Setup (checkout + cherry-pick PR) │ │ STEP 2: Detect UI Test Categories │ │ STEP 3: Run Detected UI Tests (in-process, fast) │ │ STEP 4: Regression Cross-Reference │ │ STEP 5: Gate — verify tests fail/pass before/after fix │ │ STEP 6: Code Review — deep analysis via Copilot agent │ │ │ │ Outputs → CopilotLogs artifact + detectedCategories │ └──────────────────────┬──────────────────────────────────┘ │ ┌──────────────────────▼──────────────────────────────────┐ │ Stage 2: RunDeepUITests (platform-pool agent) │ │ │ │ iOS: AcesShared Tahoe + iOS 26.4 │ │ Android: ubuntu-22.04 + KVM + AVD │ │ │ │ Runs BuildAndRunHostApp.ps1 per detected category │ │ Outputs → drop-deep-uitests artifact (TRX + diffs) │ └──────────────────────┬──────────────────────────────────┘ │ ┌──────────────────────▼──────────────────────────────────┐ │ Stage 3: PostResults │ │ │ │ 1. Download CopilotLogs (review content files) │ │ 2. Download drop-deep-uitests (TRX results) │ │ 3. Merge deep results into uitests/content.md │ │ 4. Post full AI Summary comment on PR │ │ 5. Apply labels (s/agent-reviewed, etc.) │ │ │ │ One comment with everything — no patching needed │ └─────────────────────────────────────────────────────────┘ ``` ### What's New **Deep UI Test Execution (Stage 2)** - Runs detected UI test categories on proper platform-pool agents (not in-process on Linux) - **iOS**: AcesShared Tahoe agents with iOS 26.4 simulator, iPhone 11 Pro (matching `ios-26` baselines from PR dotnet#35061) - **Android**: ubuntu-22.04 with KVM, AVD boot with `-partition-size 2048`, `ignoreHiddenApiPolicyError` capability - TRX results + snapshot-diff PNGs published as `drop-deep-uitests` artifact **Unified Comment Posting (Stage 3)** - Comment posting and label application deferred to Stage 3 (after deep tests complete) - Single AI summary comment includes ALL results: code review + deep test results - Nested collapsible `<details>` for failed tests with full error + stack trace - Dynamic section title: `🧪 UI Tests — CollectionView, TabbedPage` - Artifact download link for snapshot-diff PNGs **Android Emulator Improvements** - AVD boot step with proper partition size, ADB key pre-authorization, boot wait - `DEVICE_UDID` pass-through prevents double emulator boot - Disk cleanup on hosted ubuntu agents (frees ~22GB) - KVM enablement + `appium:ignoreHiddenApiPolicyError` for API 30 **iOS Simulator Improvements** - Tahoe pool demand ensures macOS 26.x agents - Explicit iOS 26.4 download via latest Xcode - Auto-creates iPhone 11 Pro for baseline resolution match ### Validation Tested across 30+ pipeline iterations on 6 PRs: | PR | iOS | Android | |---|---|---| | 35358 (ViewBaseTests) | **112/112 ALL PASS** ✅ | **118/119 PASS** ✅ | | 35359 (TabbedPage) | 44/50 (1 real failure) | 74/75 (1 real failure) | | 35356 (CollectionView) | **415/417 PASS** ✅ | 593/619 (26 real failures) | --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@PureWeen

…35589) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! Backport of dotnet#35460 to `main`. /cc @PureWeen Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com>

### Description of Change https://github.com/GitOps-microsoft/GitOps.PullRequestIssueManagement/pull/262 (internal Microsoft link) changed the `${issueAuthor}` placeholder to include the `@` character. Remove the one we added so we don't duplicate it. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Shalini-Ashokan · 2026-06-01T06:49:16Z

Could you check the ai's suggestions?

@kubaflo, I checked the AI concerns,
Concern 1 : (CharacterSpacing + TextColor reset): Confirmed issue. The scenario still does not reset correctly; we will fix this in a separate follow-up.

Concern 2: (MacCatalyst reset path): Not valid. I debugged this path and UserInterfaceIdiom is not Mac in our run environment on macOS, so that branch is not hit.

kubaflo

Alright! Could you resolve conflicts and we will be able to merge this one :)

github-actions · 2026-06-01T16:00:45Z

🔍 Skill Validation Results

✅ Static Checks Passed

Skills checked: 18 | Agents checked: 4

Full validator output

Found 2 skill(s)
[agentic-labeler] 📊 agentic-labeler: 2,839 BPE tokens [chars/4: 2,788] (standard ~), 8 sections, 0 code blocks
[agentic-labeler]    ⚠  Skill is 2,839 BPE tokens (chars/4 estimate: 2,788) — approaching "comprehensive" range where gains diminish.
[agentic-labeler]    ⚠  No code blocks — agents perform better with concrete snippets and commands.
[find-regression-risk] 📊 find-regression-risk: 967 BPE tokens [chars/4: 905] (detailed ✓), 10 sections, 2 code blocks
[find-regression-risk]    ⚠  No YAML frontmatter — agents use name/description for skill discovery.
✅ All checks passed (2 skill(s))
Found 4 agent(s)
Validated 4 agent(s)

✅ All checks passed (4 agent(s))

⏭️ LLM Evaluation: Skipped

💡 LLM evaluation was not run for this external PR.
A repository contributor can post /evaluate-skills on this PR to trigger full evaluation.

🔍 Full results and investigation steps

Shalini-Ashokan · 2026-06-01T16:11:46Z

Alright! Could you resolve conflicts and we will be able to merge this one :)

@kubaflo, I resolved the conflights

kubaflo · 2026-06-01T19:10:45Z

/review -b feature/enhanced-reviewer

MauiBot

AI Review Summary

@Shalini-Ashokan — new AI review results are available based on this last commit: af16bd2.
Merge branch 'inflight/current' into fix-35513 To request a fresh review after new comments or commits, comment /review rerun.

Review Sessions — click to expand

Gate — Test Before & After Fix

Gate Result: ❌ FAILED

Platform: IOS · Base: main · Merge base: b0ea772f

🩺 Fix does not compile — applying the PR's fix produces a build error before tests can run. The earlier-than-test failure is the root cause; the per-test ❌ FAIL marks are downstream effects, not real test failures.

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🖥️ Issue35513 `Issue35513`	✅ FAIL — 320s	🛠️ BUILD ERROR

🔴 Without fix — 🖥️ Issue35513: FAIL ✅ · 320s

  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 577 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 707 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 8.23 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 8.39 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 8.41 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 8.41 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/maps/src/Maps.csproj (in 8.42 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 8.42 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 8.42 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 8.43 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 8.43 sec).
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:02:30.10
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 666 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 668 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 665 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 762 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 996 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 1.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 1.33 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 1.35 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 1.81 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 2.41 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 3.64 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 6.86 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj (in 6.88 sec).
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.08]   Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.22]   Discovered:  Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
   NUnit3TestExecutor discovered 2 of 2 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 6/1/2026 12:33:51 PM FixtureSetup for Issue35513(iOS)
>>>>> 6/1/2026 12:33:57 PM TextViewBasedControlsTextColorUpdates Start
>>>>> 6/1/2026 12:33:59 PM TextViewBasedControlsTextColorUpdates Stop
  Passed TextViewBasedControlsTextColorUpdates [1 s]
>>>>> 6/1/2026 12:33:59 PM TextViewBasedControlsRestoreDefaultAfterResetToNull Start
>>>>> 6/1/2026 12:34:01 PM TextViewBasedControlsRestoreDefaultAfterResetToNull Stop
>>>>> 6/1/2026 12:34:01 PM Log types: syslog, crashlog, performance, safariConsole, safariNetwork, server
  Failed TextViewBasedControlsRestoreDefaultAfterResetToNull [2 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: AfterResetTextColorToNullOnTextViewBasedControls.png (1.66% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
   at Microsoft.Maui.TestCases.Tests.Issues.Issue35513.TextViewBasedControlsRestoreDefaultAfterResetToNull() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue35513.cs:line 29
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

NUnit Adapter 4.5.0.0: Test execution complete
Results File: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/UITests/TestResults/Issue35513.trx

Test Run Failed.
Total tests: 2
     Passed: 1
     Failed: 1
 Total time: 1.7229 Minutes
>>> TRX_RESULT_FILE: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/UITests/TestResults/Issue35513.trx

🟢 With fix — 🖥️ Issue35513: 🛠️ BUILD ERROR · 41s

  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 424 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 450 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 456 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 504 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 524 ms).
  6 of 11 projects are up-to-date for restore.
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14251243
/Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt(17,1): error RS0025: The symbol 'override Microsoft.Maui.Controls.Handlers.Items2.StructuredItemsViewController2<TItemsView>.UpdateFlowDirection() -> void' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net10.0-ios26.0]

Build FAILED.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
/Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt(17,1): error RS0025: The symbol 'override Microsoft.Maui.Controls.Handlers.Items2.StructuredItemsViewController2<TItemsView>.UpdateFlowDirection() -> void' appears more than once in the public API files (https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net10.0-ios26.0]
    1 Warning(s)
    1 Error(s)

Time Elapsed 00:00:32.95

⚠️ Failure Details

🛠️ Issue35513 with fix: build failed (fix does not compile)

📁 Fix files reverted (301 files)

eng/Signing.props
eng/Versions.props
eng/devices/run-windows-devicetests.cmd
eng/devices/windows.cake
eng/pipelines/ci-copilot.yml
src/BlazorWebView/src/Maui/Android/BlazorAndroidWebView.cs
src/BlazorWebView/src/Maui/Android/BlazorWebViewHandler.Android.cs
src/BlazorWebView/src/Maui/Android/WebKitWebViewClient.cs
src/Compatibility/Core/src/Android/CollectionView/TemplatedItemViewHolder.cs
src/Compatibility/Core/src/Android/Renderers/SwipeViewRenderer.cs
src/Compatibility/Core/src/MacOS/Extensions/NSMenuExtensions.cs
src/Compatibility/Core/src/Windows/CollectionView/ItemContentControl.cs
src/Compatibility/Core/src/iOS/CollectionView/TemplatedCell.cs
src/Compatibility/Core/src/iOS/EventTracker.cs
src/Compatibility/Core/src/iOS/Renderers/SwipeViewRenderer.cs
src/Compatibility/Core/src/iOS/Renderers/UIContainerCell.cs
src/Controls/samples/Controls.Sample/Pages/Controls/MapsGalleries/MapPinsGallery.xaml
src/Controls/samples/Controls.Sample/Pages/Controls/MapsGalleries/MapPinsGallery.xaml.cs
src/Controls/src/Build.Tasks/SetPropertiesVisitor.cs
src/Controls/src/Core/ActionSheetArguments.cs
src/Controls/src/Core/AlertArguments.cs
src/Controls/src/Core/BindableObject.cs
src/Controls/src/Core/BindableProperty.cs
src/Controls/src/Core/Border/Border.cs
src/Controls/src/Core/Button/Button.iOS.cs
src/Controls/src/Core/Compatibility/Android/Resources/layout/flyoutcontent.axml
src/Controls/src/Core/Compatibility/Handlers/FlyoutPage/iOS/PhoneFlyoutPageRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutRecyclerAdapter.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFragmentContainer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFragmentStateAdapter.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellItemRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellSectionRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellToolbarTracker.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutLayoutManager.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootRenderer.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewController.cs
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/UIContainerCell.cs
src/Controls/src/Core/Compatibility/Handlers/TabbedPage/iOS/TabbedRenderer.cs
src/Controls/src/Core/Editor/Editor.Mapper.cs
src/Controls/src/Core/Editor/Editor.iOS.cs
src/Controls/src/Core/Element/Element.cs
src/Controls/src/Core/Entry/Entry.Mapper.cs
src/Controls/src/Core/Entry/Entry.iOS.cs
src/Controls/src/Core/FlyoutPage/FlyoutPage.cs
src/Controls/src/Core/FormattedString.cs
src/Controls/src/Core/GestureElement.cs
src/Controls/src/Core/Handlers/Items/Android/Adapters/GroupableItemsViewAdapter.cs
src/Controls/src/Core/Handlers/Items/Android/Adapters/ItemsViewAdapter.cs
src/Controls/src/Core/Handlers/Items/Android/GridLayoutSpanSizeLookup.cs
src/Controls/src/Core/Handlers/Items/Android/ItemContentView.cs
src/Controls/src/Core/Handlers/Items/Android/MauiCarouselRecyclerView.cs
src/Controls/src/Core/Handlers/Items/Android/MauiRecyclerView.cs
src/Controls/src/Core/Handlers/Items/Android/TemplatedItemViewHolder.cs
src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs
src/Controls/src/Core/Handlers/Items/ItemsViewHandler.cs
src/Controls/src/Core/Handlers/Items/ItemsViewHandler.iOS.cs
src/Controls/src/Core/Handlers/Items/StructuredItemsViewHandler.Android.cs
src/Controls/src/Core/Handlers/Items/Tizen/ItemTemplateAdaptor.cs
src/Controls/src/Core/Handlers/Items/iOS/ItemsViewController.cs
src/Controls/src/Core/Handlers/Items/iOS/ItemsViewDelegator.cs
src/Controls/src/Core/Handlers/Items/iOS/SelectableItemsViewController.cs
src/Controls/src/Core/Handlers/Items/iOS/TemplatedCell.cs
src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cs
src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs
src/Controls/src/Core/Handlers/Items2/iOS/GroupableItemsViewController2.cs
src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewController2.cs
src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewDelegator2.cs
src/Controls/src/Core/Handlers/Items2/iOS/LayoutFactory2.cs
src/Controls/src/Core/Handlers/Items2/iOS/SelectableItemsViewController2.cs
src/Controls/src/Core/Handlers/Items2/iOS/StructuredItemsViewController2.cs
src/Controls/src/Core/Handlers/Items2/iOS/TemplatedCell2.cs
src/Controls/src/Core/Handlers/Shapes/Polygon/PolygonHandler.Android.cs
src/Controls/src/Core/Handlers/Shapes/Polygon/PolygonHandler.Tizen.cs
src/Controls/src/Core/Handlers/Shapes/Polygon/PolygonHandler.Windows.cs
src/Controls/src/Core/Handlers/Shapes/Polygon/PolygonHandler.cs
src/Controls/src/Core/Handlers/Shapes/Polygon/PolygonHandler.iOS.cs
src/Controls/src/Core/Handlers/Shapes/Polyline/PolylineHandler.Android.cs
src/Controls/src/Core/Handlers/Shapes/Polyline/PolylineHandler.Tizen.cs
src/Controls/src/Core/Handlers/Shapes/Polyline/PolylineHandler.Windows.cs
src/Controls/src/Core/Handlers/Shapes/Polyline/PolylineHandler.cs
src/Controls/src/Core/Handlers/Shapes/Polyline/PolylineHandler.iOS.cs
src/Controls/src/Core/Handlers/Shell/ShellHandler.Windows.cs
src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs
src/Controls/src/Core/Handlers/Shell/ShellSectionHandler.Windows.cs
src/Controls/src/Core/Handlers/Shell/Windows/ShellFlyoutItemView.cs
src/Controls/src/Core/Handlers/Shell/Windows/ShellView.cs
src/Controls/src/Core/Hosting/AppHostBuilderExtensions.cs
src/Controls/src/Core/ImageElement.cs
src/Controls/src/Core/IndicatorView/IndicatorStackLayout.cs
src/Controls/src/Core/InputView/InputView.cs
src/Controls/src/Core/Internals/WeakEventProxy.cs
src/Controls/src/Core/Items/SelectionList.cs
src/Controls/src/Core/Label/Label.Mapper.cs
src/Controls/src/Core/Label/Label.cs
src/Controls/src/Core/Label/Label.iOS.cs
src/Controls/src/Core/ListView/ListView.cs
src/Controls/src/Core/NavigationPage/NavigationPage.cs
src/Controls/src/Core/NavigationPage/NavigationPageToolbar.cs
src/Controls/src/Core/Page/Page.cs
src/Controls/src/Core/Picker/Picker.cs
src/Controls/src/Core/Platform/AlertManager/AlertManager.Android.cs
src/Controls/src/Core/Platform/AlertManager/AlertManager.cs
src/Controls/src/Core/Platform/Android/BottomNavigationViewUtils.cs
src/Controls/src/Core/Platform/Android/DragAndDropGestureHandler.cs
src/Controls/src/Core/Platform/Android/Extensions/ToolbarExtensions.cs
src/Controls/src/Core/Platform/Android/GenericAnimatorListener.cs
src/Controls/src/Core/Platform/Android/TabbedPageManager.cs
src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.iOS.cs
src/Controls/src/Core/Platform/ModalNavigationManager/ModalNavigationManager.iOS.cs
src/Controls/src/Core/Platform/Windows/CollectionView/ItemContentControl.cs
src/Controls/src/Core/Platform/Windows/CollectionView/ScrollHelpers.cs
src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs
src/Controls/src/Core/Platform/iOS/Extensions/LabelExtensions.cs
src/Controls/src/Core/PromptArguments.cs
src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt
src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt
src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt
src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt
src/Controls/src/Core/RadioButton/RadioButton.cs
src/Controls/src/Core/RadioButton/RadioButtonGroup.cs
src/Controls/src/Core/RadioButton/RadioButtonGroupController.cs
src/Controls/src/Core/ResourcesExtensions.cs
src/Controls/src/Core/Setter.cs
src/Controls/src/Core/Shadow.cs
src/Controls/src/Core/Shapes/Shape.cs
src/Controls/src/Core/Shell/Shell.cs
src/Controls/src/Core/Shell/ShellNavigationManager.cs
src/Controls/src/Core/Shell/ShellSection.cs
src/Controls/src/Core/SwipeView/SwipeItem.cs
src/Controls/src/Core/SwipeView/SwipeItemView.cs
src/Controls/src/Core/SwipeView/SwipeItems.cs
src/Controls/src/Core/SwipeView/SwipeView.cs
src/Controls/src/Core/TabbedPage/TabbedPage.Windows.cs
src/Controls/src/Core/Toolbar/Toolbar.Android.cs
src/Controls/src/Core/VisualElement/VisualElement.cs
src/Controls/src/Core/VisualStateManager.cs
src/Controls/src/Core/WebView/WebViewSource.cs
src/Controls/src/Core/Window/Window.Android.cs
src/Controls/src/Core/Window/Window.cs
src/Controls/src/SourceGen/NodeSGExtensions.cs
src/Controls/src/Xaml/ApplyPropertiesVisitor.cs
src/Controls/src/Xaml/MarkupExtensions/OnIdiomExtension.cs
src/Controls/src/Xaml/MarkupExtensions/StaticResourceExtension.cs
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformWrapperView.java
src/Core/maps/src/Handlers/Map/MapHandler.Android.cs
src/Core/maps/src/Handlers/Map/MapHandler.iOS.cs
src/Core/maps/src/Handlers/MapPin/MapPinHandler.Android.cs
src/Core/maps/src/Platform/iOS/MauiMKMapView.cs
src/Core/maps/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
src/Core/src/Animations/AnimationManager.cs
src/Core/src/Diagnostics/DiagnosticsManager.cs
src/Core/src/Diagnostics/IDiagnosticsManager.cs
src/Core/src/Diagnostics/Instrumentation/DiagnosticInstrumentation.cs
src/Core/src/Diagnostics/Instrumentation/LayoutArrangeInstrumentation.cs
src/Core/src/Diagnostics/Instrumentation/LayoutDiagnosticMetrics.cs
src/Core/src/Diagnostics/Instrumentation/LayoutMeasureInstrumentation.cs
src/Core/src/Graphics/MauiDrawable.Android.cs
src/Core/src/Handlers/Button/ButtonHandler.Android.cs
src/Core/src/Handlers/Button/ButtonHandler.cs
src/Core/src/Handlers/Button/ButtonHandler.iOS.cs
src/Core/src/Handlers/DatePicker/DatePickerHandler.Android.cs
src/Core/src/Handlers/DatePicker/DatePickerHandler.MacCatalyst.cs
src/Core/src/Handlers/Editor/EditorHandler.iOS.cs
src/Core/src/Handlers/Entry/EntryHandler.cs
src/Core/src/Handlers/Entry/EntryHandler.iOS.cs
src/Core/src/Handlers/FlyoutView/FlyoutViewHandler.Android.cs
src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.Standard.cs
src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.Tizen.cs
src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.Windows.cs
src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.cs
src/Core/src/Handlers/Image/ImageHandler.Windows.cs
src/Core/src/Handlers/Image/ImageHandler.iOS.cs
src/Core/src/Handlers/Label/LabelHandler.cs
src/Core/src/Handlers/Label/LabelHandler.iOS.cs
src/Core/src/Handlers/Picker/PickerHandler.Windows.cs
src/Core/src/Handlers/Picker/PickerHandler.iOS.cs
src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs
src/Core/src/Handlers/RadioButton/RadioButtonHandler.cs
src/Core/src/Handlers/RadioButton/RadioButtonHandler.iOS.cs
src/Core/src/Handlers/RefreshView/RefreshViewHandler.Windows.cs
src/Core/src/Handlers/ScrollView/ScrollViewHandler.Android.cs
src/Core/src/Handlers/ScrollView/ScrollViewHandler.Windows.cs
src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
src/Core/src/Handlers/SearchBar/SearchBarHandler.iOS.cs
src/Core/src/Handlers/SearchBar/SearchBarHandler2.Android.cs
src/Core/src/Handlers/ShapeView/ShapeViewHandler.Standard.cs
src/Core/src/Handlers/ShapeView/ShapeViewHandler.cs
src/Core/src/Handlers/Stepper/StepperHandler.iOS.cs
src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Android.cs
src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.Windows.cs
src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.cs
src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs
src/Core/src/Handlers/Switch/SwitchHandler.iOS.cs
src/Core/src/Handlers/TimePicker/TimePickerHandler.Android.cs
src/Core/src/Handlers/TimePicker/TimePickerHandler.Windows.cs
src/Core/src/Handlers/TimePicker/TimePickerHandler.cs
src/Core/src/Handlers/TimePicker/TimePickerHandler.iOS.cs
src/Core/src/Handlers/View/ViewHandler.cs
src/Core/src/Handlers/WebView/WebViewHandler.Android.cs
src/Core/src/Hosting/EssentialsMauiAppBuilderExtensions.cs
src/Core/src/Hosting/LifecycleEvents/AppHostBuilderExtensions.Android.cs
src/Core/src/ImageSources/FontImageSourceService/FontImageSourceService.Windows.cs
src/Core/src/Layouts/Flex.cs
src/Core/src/Platform/Android/ActivityIndicatorExtensions.cs
src/Core/src/Platform/Android/ActivityResultCallbackRegistry.cs
src/Core/src/Platform/Android/BorderDrawable.cs
src/Core/src/Platform/Android/ContainerView.cs
src/Core/src/Platform/Android/EditTextExtensions.cs
src/Core/src/Platform/Android/MauiAppCompatActivity.Lifecycle.cs
src/Core/src/Platform/Android/MauiAppCompatActivity.cs
src/Core/src/Platform/Android/MauiHybridWebView.cs
src/Core/src/Platform/Android/MauiHybridWebViewClient.cs
src/Core/src/Platform/Android/MauiScrollView.cs
src/Core/src/Platform/Android/MauiSearchView.cs
src/Core/src/Platform/Android/MauiSwipeRefreshLayout.cs
src/Core/src/Platform/Android/MauiSwipeView.cs
src/Core/src/Platform/Android/MauiWebView.cs
src/Core/src/Platform/Android/MauiWebViewClient.cs
src/Core/src/Platform/Android/MauiWindowInsetListener.cs
src/Core/src/Platform/Android/Navigation/NavigationRootManager.cs
src/Core/src/Platform/Android/RadioButtonExtensions.cs
src/Core/src/Platform/Android/SafeAreaExtensions.cs
src/Core/src/Platform/Android/SearchViewExtensions.cs
src/Core/src/Platform/Android/TextViewExtensions.cs
src/Core/src/Platform/Android/TimePickerExtensions.cs
src/Core/src/Platform/Android/ViewExtensions.cs
src/Core/src/Platform/Android/WrapperView.cs
src/Core/src/Platform/Windows/ContentPanel.cs
src/Core/src/Platform/Windows/LayoutPanel.cs
src/Core/src/Platform/Windows/MauiPasswordTextBox.cs
src/Core/src/Platform/Windows/MauiToolbar.xaml.cs
src/Core/src/Platform/Windows/PickerExtensions.cs
src/Core/src/Platform/Windows/RadioButtonExtensions.cs
src/Core/src/Platform/Windows/RootNavigationView.cs
src/Core/src/Platform/Windows/ScrollViewerExtensions.cs
src/Core/src/Platform/Windows/Styles/MauiComboBoxStyle.xaml
src/Core/src/Platform/Windows/Styles/Resources.xaml
src/Core/src/Platform/Windows/TextBoxExtensions.cs
src/Core/src/Platform/Windows/TimePickerExtensions.cs
src/Core/src/Platform/Windows/WebViewExtensions.cs
src/Core/src/Platform/iOS/ButtonExtensions.cs
src/Core/src/Platform/iOS/KeyboardAcceleratorExtensions.cs
src/Core/src/Platform/iOS/LayerExtensions.cs
src/Core/src/Platform/iOS/MauiPageControl.cs
src/Core/src/Platform/iOS/MauiScrollView.cs
src/Core/src/Platform/iOS/MauiSwipeView.cs
src/Core/src/Platform/iOS/MauiTextField.cs
src/Core/src/Platform/iOS/MauiTextView.cs
src/Core/src/Platform/iOS/MauiUIApplicationDelegate.Menu.cs
src/Core/src/Platform/iOS/MauiView.cs
src/Core/src/Platform/iOS/NoCaretField.cs
src/Core/src/Platform/iOS/PickerExtensions.cs
src/Core/src/Platform/iOS/SemanticExtensions.cs
src/Core/src/Platform/iOS/SliderExtensions.cs
src/Core/src/Platform/iOS/TabbedViewExtensions.cs
src/Core/src/Platform/iOS/TextFieldExtensions.cs
src/Core/src/Platform/iOS/TimePickerExtensions.cs
src/Core/src/Platform/iOS/WrapperView.cs
src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt
src/Core/src/ViewExtensions.cs
src/Core/src/WindowExtensions.cs
src/Essentials/samples/Samples/View/ScreenshotPage.xaml
src/Essentials/src/AssemblyInfo/AssemblyInfo.shared.cs
src/Essentials/src/Browser/Browser.android.cs
src/Essentials/src/Clipboard/Clipboard.shared.cs
src/Essentials/src/FilePicker/FilePicker.tizen.cs
src/Essentials/src/FileSystem/FileSystemUtils.android.cs
src/Essentials/src/FileSystem/FileSystemUtils.shared.cs
src/Essentials/src/MainThread/MainThread.netstandard.cs
src/Essentials/src/MainThread/MainThread.shared.cs
src/Essentials/src/MediaPicker/MediaPicker.android.cs
src/Essentials/src/MediaPicker/MediaPicker.ios.cs
src/Essentials/src/MediaPicker/MediaPicker.tizen.cs
src/Essentials/src/Screenshot/Screenshot.android.cs
src/Essentials/src/TextToSpeech/TextToSpeech.ios.tvos.watchos.cs
src/Essentials/src/TextToSpeech/TextToSpeech.shared.cs
src/Essentials/src/TextToSpeech/TextToSpeech.windows.cs
src/Essentials/src/Types/Shared/WebUtils.shared.cs
src/Graphics/src/Graphics/Platforms/Android/PlatformGraphicsView.cs
src/Graphics/src/Graphics/Platforms/MaciOS/PlatformCanvas.cs
src/Graphics/src/Graphics/Platforms/Windows/PlatformGraphicsView.cs
src/Graphics/src/Graphics/Platforms/iOS/PlatformGraphicsView.cs
src/SingleProject/Resizetizer/src/GenerateTizenManifest.cs
src/SingleProject/Resizetizer/src/SkiaSharpSvgTools.cs
src/SingleProject/Resizetizer/src/nuget/buildTransitive/Microsoft.Maui.Resizetizer.After.targets
src/Templates/src/Microsoft.Maui.Templates.csproj
src/Templates/src/templates/maui-mobile/MauiApp.1.csproj

New files (not reverted):

eng/devices/Run-PackagedAppAndWait.ps1
src/Controls/src/Core/Handlers/Items/iOS/IScrollTrackingDelegator.cs
src/Controls/src/Core/Platform/AlertManager/DelegateAlertSubscription.cs
src/Core/maps/src/Handlers/Map/MapElementPlatformOptions.Android.cs
src/Core/src/Handlers/HybridWebView/HybridWebViewHelper.cs
src/Core/src/Platform/Android/AppbarLayoutExtensions.cs
src/Core/src/Platform/Android/IBackNavigationState.cs
src/Core/src/Platform/Android/RefreshViewWebViewScrollCapture.cs
src/Core/src/Platform/Windows/CharacterSpacingConverter.cs
src/Core/src/Platform/Windows/ContentPanelAutomationPeer.cs
src/Core/src/Platform/Windows/MauiBorderAutomationPeer.cs
src/Core/src/Platform/Windows/MauiLayoutAutomationPeer.cs
src/Core/src/Platform/iOS/MauiProgressView.cs
src/Core/src/ScreenshotDispatch.cs
src/Templates/src/templates/maui-blazor-solution/.gitignore
src/Templates/src/templates/maui-blazor/.gitignore
src/Templates/src/templates/maui-lib/.gitignore
src/Templates/src/templates/maui-mobile/.gitignore
src/Templates/src/templates/maui-multiproject/.gitignore

UI Tests — Button,ViewBaseTests

Detected UI test categories: Button,ViewBaseTests

Pre-Flight — Context & Validation

Issue: #35513 - Button TextColor does not restore to platform default when reset to null after dynamic update
PR: #35563 - Local PR branch pr-review-35563
Platforms Affected: iOS (gate platform); issue metadata also lists Android/macOS
Files Changed: 301 implementation/support files, Issue35513 UI test files present

Key Findings

GitHub metadata could not be fetched because gh is unauthenticated; context was gathered from local branch diff and existing gate artifacts.
Gate already verified the base branch reproduces Issue35513 on iOS: TextViewBasedControlsRestoreDefaultAfterResetToNull fails by screenshot difference after TextColor is reset to null.
The PR branch initially failed before runtime validation because iOS PublicAPI analyzer errors blocked build.
The PR's Issue35513-relevant fix changes UIButton.UpdateTextColor to clear title colors only after platformButton.Window is available.

Code Review Summary

Verdict: NEEDS_CHANGES
Confidence: high
Errors: 1 | Warnings: 1 | Suggestions: 0

Key code review findings:

ERROR: iOS PublicAPI analyzer errors block validation: duplicate StructuredItemsViewController2.UpdateFlowDirection() and FormattedStringExtensions public signature drift.
WARNING: Original Button reset logic depends on window attachment and may miss mapper updates that happen before the platform button is attached.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #35563	Clear UIButton title colors on TextColor null only when attached to a Window, then use window TintColor	FAIL - BUILD ERROR (Gate)	ButtonExtensions.cs, PublicAPI/test files	Original PR did not compile in gate

Code Review — Deep Analysis

Code Review - PR #35563

Independent Assessment

What this changes: The local PR branch contains a large squashed change set. The Issue35513-relevant code changes add an iOS Button TextColor reset fix in src/Core/src/Platform/iOS/ButtonExtensions.cs, add Issue35513 UI coverage, and include unrelated build/API changes that affect iOS compilation.
Inferred motivation: Fix iOS text-color reset behavior after dynamically setting TextColor and then resetting it to null, while preserving platform defaults.

Reconciliation with PR Narrative

Author claims: GitHub PR metadata could not be fetched because gh is unauthenticated in this environment. Gate artifacts show the targeted regression is Issue35513 on iOS.
Agreement/disagreement: Local code and gate artifacts agree that Issue35513 is the target. The original PR fix did not reach runtime validation because the PR branch failed iOS build validation on PublicAPI analyzer errors.

Findings

Error - iOS PublicAPI files block validation

The gate failed before tests could run because src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt declared StructuredItemsViewController2.UpdateFlowDirection() twice. Candidate testing also uncovered shipped API signature drift in FormattedStringExtensions.ToNSAttributedString(...) caused by adding a new optional public parameter without corresponding API compatibility handling.

Warning - PR Button reset relies on window attachment

The original PR UIButton.UpdateTextColor fix clears title colors only when platformButton.Window exists, so mapper timing can determine whether resetting TextColor to null actually restores native defaults.

Devil's Advocate

The gate failure is partly caused by broad PR-branch compile blockers rather than the Button fix itself. However, a fix candidate must build before runtime behavior can be evaluated, so build-blocker cleanup was included as validation support rather than treated as the alternative text-color strategy.

Verdict: NEEDS_CHANGES

Confidence: high
Summary: The original PR branch does not compile on iOS under the gate. The Button fix can be improved by restoring captured native defaults instead of relying on window attachment and null title-color clearing.

Fix — Analysis & Comparison

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix	Capture native UIButton title/tint defaults in ButtonHandler.iOS.cs and restore them on TextColor null; clean iOS PublicAPI build blockers so validation reaches runtime	PASS	4 files	Better than PR fix: no Window lifecycle dependency, preserves UIAppearance/proxy defaults
PR	PR #35563	Clear UIButton title colors on null only when platformButton.Window exists, then use window TintColor	FAIL - BUILD ERROR (Gate)	multiple files	Original PR blocked by iOS PublicAPI analyzer errors

Cross-Pollination

Model	Round	New Ideas?	Details
maui-expert-reviewer	2	No	NO NEW IDEAS for standard iOS Button; optional future MacCatalyst-specific UIButtonConfiguration.BaseForegroundColor reset if expanding scope

Exhausted: Yes - Candidate 1 passed all requested iOS tests and expert review found no better meaningfully distinct standard iOS Button approach.
Selected Fix: Candidate #1 - Captured native defaults are more deterministic than the PR's window-guarded null clearing and passed the iOS Issue35513 regression test.

Report — Final Recommendation

Comparative Fix Report - PR #35563

Candidates

Rank	Candidate	Result	Assessment
1	`pr-plus-reviewer`	PASS by equivalence to `try-fix-1`	Best candidate. It keeps the PR's target scenario but applies expert feedback: removes iOS PublicAPI blockers and restores captured UIButton native defaults instead of relying on `Window` attachment timing.
2	`try-fix-1`	PASS	Same effective implementation as `pr-plus-reviewer`: captured default title/tint colors plus PublicAPI cleanup. It passed `BuildAndRunHostApp.ps1 -Platform ios -TestFilter FullyQualifiedName~Issue35513`.
3	`pr`	FAIL	Raw PR failed iOS validation before runtime due to PublicAPI analyzer/build blockers. Its Button reset logic also remains timing-dependent because it only clears native title colors when `platformButton.Window` exists.

Candidate details

pr clears explicit UIButton title colors on TextColor = null only after the button is attached to a window, then sets TintColor from the window. This did not compile under gate validation because the PR branch also included iOS PublicAPI issues, and the reset strategy can miss pre-window mapper updates.

try-fix-1 captures native UIButton defaults after proxy setup and restores them on null reset. It also fixes the unrelated iOS PublicAPI blockers that prevented runtime validation. This candidate passed the targeted iOS Issue35513 UI tests.

pr-plus-reviewer applies the expert reviewer's actionable feedback to the PR fix in the sandbox. The resulting implementation matches the proven try-fix-1 behavior while preserving the PR-centered candidate identity required by this phase.

Winner

pr-plus-reviewer is the winning candidate. It ranks above the raw PR because failed candidates must rank below passing candidates, and it ranks above try-fix-1 only because it is the same passing fix expressed as the PR plus expert-review feedback, which is the intended output of Phase 1.

Future Action — review latest findings

No alternative fix was selected for this run. Review the session findings and CI results before merging.

Shalini-Ashokan · 2026-06-02T07:10:56Z

I verified the test locally. The test case passed both with and without the fix because the fix is already included in the in-flight branch.

…oid (#35563)  > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!  ### Issue Details Button TextColor is set at runtime (for example, DarkRed) and then reset to null. Expected behavior: the button text should return to the platform default color. ### Root Cause Setting TextColor applies native foreground/title overrides. When TextColor was reset to null, some handlers did not actively clear those native overrides. ### Description of Change Android : Saved each control’s original TextColors once and reused it when TextColor is null, restoring the real platform default. iOS : Updated iOS button text color handling in [ButtonExtensions.cs](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) to clear overridden title colors when TextColor is null. Validated the behavior in the following platforms - [x] Android - [x] Windows - [x] iOS - [x] Mac ### Issues Fixed Fixes #35513 ### Output ScreenShot Android |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/9728c36a-5b0d-4061-8190-fc550e65d128" >| <video src="https://github.com/user-attachments/assets/5a3470c6-b663-4ae6-9d88-5222102a455b">| iOS |Before|After| |--|--| | <video src="https://github.com/user-attachments/assets/bfd4f513-9bf0-4f25-8151-621a593c5d1f" >| <video src="https://github.com/user-attachments/assets/faebe1b3-c01a-4906-8a9b-7da581dec527">| ---------

dotnet-policy-service Bot added the community ✨ Community Contribution label May 21, 2026

dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label May 21, 2026

github-actions Bot added platform/android platform/ios area-button labels May 21, 2026

sheiksyedm marked this pull request as ready for review May 21, 2026 11:53

MauiBot added s/agent-review-incomplete s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels May 21, 2026

dotnet deleted a comment from MauiBot May 21, 2026

PureWeen and others added 2 commits May 21, 2026 16:04

Add version 10.0.70 to bug report template (dotnet#35569)

4408e3e

This was referenced May 22, 2026

[PR Review Queue] 2026-05-22 #35581

Closed

[PR Review Queue] 2026-05-22 PureWeen/maui#65

Closed

dotnet deleted a comment from MauiBot May 22, 2026

This comment was marked as outdated.

Sign in to view

MauiBot added the s/agent-fix-win AI found a better alternative fix than the PR label May 22, 2026

kubaflo and others added 2 commits May 22, 2026 17:18

github-actions Bot mentioned this pull request May 29, 2026

[PR Review Queue] 2026-05-29 #35660

Closed

github-actions Bot mentioned this pull request May 29, 2026

[PR Review Queue] 2026-05-29 PureWeen/maui#89

Closed

This was referenced Jun 1, 2026

[PR Review Queue] 2026-06-01 #35682

Closed

[PR Review Queue] 2026-06-01 PureWeen/maui#93

Closed

kubaflo changed the base branch from main to inflight/current June 1, 2026 10:43

kubaflo requested changes Jun 1, 2026

View reviewed changes

Shalini-Ashokan added 10 commits June 1, 2026 21:29

Added test case and fixed the issue

38ccdee

Simplified the fix

90dece7

Removed windows fix

b4434f0

Changed the public api to internal

66e136c

Modified the android fix

7dee201

modified the fix

34a0e82

Revert "modified the fix"

5c517ba

modified the test cases

a8cae32

committed the images

8193fb2

committed the base images

2d52e10

Shalini-Ashokan force-pushed the fix-35513 branch from 9f5878a to 2d52e10 Compare June 1, 2026 16:00

Merge branch 'inflight/current' into fix-35513

af16bd2

MauiBot reviewed Jun 1, 2026

View reviewed changes

This was referenced Jun 2, 2026

[PR Review Queue] 2026-06-02 PureWeen/maui#98

Closed

[PR Review Queue] 2026-06-02 #35699

Closed

kubaflo merged commit 57b485e into dotnet:inflight/current Jun 2, 2026
33 of 36 checks passed

github-actions Bot added this to the .NET 10.0 SR8 milestone Jun 2, 2026

Conversation

Shalini-Ashokan commented May 21, 2026

Issue Details

Root Cause

Description of Change

Issues Fixed

Output ScreenShot

Uh oh!

github-actions Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 21, 2026

Uh oh!

kubaflo commented May 21, 2026

Uh oh!

kubaflo commented May 21, 2026

Uh oh!

sheiksyedm commented May 22, 2026

Uh oh!

azure-pipelines Bot commented May 22, 2026

Uh oh!

kubaflo commented May 22, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Shalini-Ashokan commented Jun 1, 2026

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 1, 2026

🔍 Skill Validation Results

✅ Static Checks Passed

⏭️ LLM Evaluation: Skipped

Uh oh!

Shalini-Ashokan commented Jun 1, 2026

Uh oh!

kubaflo commented Jun 1, 2026

Uh oh!

MauiBot left a comment

Choose a reason for hiding this comment

AI Review Summary

Gate Result: ❌ FAILED

⚠️ Failure Details

Key Findings

Code Review Summary

Fix Candidates

Code Review - PR #35563

Independent Assessment

Reconciliation with PR Narrative

Findings

Error - iOS PublicAPI files block validation

Warning - PR Button reset relies on window attachment

Devil's Advocate

Verdict: NEEDS_CHANGES

Fix Candidates

Cross-Pollination

Comparative Fix Report - PR #35563

Candidates

Candidate details

Winner

Uh oh!

Shalini-Ashokan commented Jun 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions Bot commented May 21, 2026 •

edited

Loading