Skip to content

Fix Binding for ListView.IsRefreshing - #28516

Merged
kubaflo merged 2 commits into
dotnet:inflight/currentfrom
bill2004158:bill2004158-patch-issues/28514
May 9, 2026
Merged

Fix Binding for ListView.IsRefreshing#28516
kubaflo merged 2 commits into
dotnet:inflight/currentfrom
bill2004158:bill2004158-patch-issues/28514

Conversation

@bill2004158

Copy link
Copy Markdown
Contributor

Description of Change

Set IsRefreshingProperty with SetterSpecificity.FromHandler,
to avoid break Binding.

Issues Fixed

Fixes #28514

Set IsRefreshingProperty with SetterSpecificity.FromHandler.
@bill2004158
bill2004158 requested a review from a team as a code owner March 19, 2025 16:38
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Mar 19, 2025

@mattleibow mattleibow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

Are you able to write a unit test demonstrating the fix? I think somewhere in this file: https://github.com/dotnet/maui/blob/main/src/Controls/tests/Core.UnitTests/ListViewTests.cs

@mattleibow mattleibow added the area-controls-listview ListView and TableView label Mar 19, 2025
@bill2004158

Copy link
Copy Markdown
Contributor Author

@mattleibow ,
Ok, added the UnitTest.

@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen

Copy link
Copy Markdown
Member

/rebase

@MauiBot MauiBot added s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Mar 23, 2026
@MauiBot MauiBot added s/agent-changes-requested AI agent recommends changes - found a better alternative or issues and removed s/agent-approved AI agent recommends approval - PR fix is correct and optimal labels Apr 3, 2026
@kubaflo
kubaflo changed the base branch from main to inflight/current May 9, 2026 14:51
@kubaflo
kubaflo merged commit ded10c0 into dotnet:inflight/current May 9, 2026
1 check passed
@github-actions github-actions Bot added this to the .NET 10 SR7 milestone May 9, 2026
@dotnet dotnet deleted a comment from MauiBot May 11, 2026
@dotnet dotnet deleted a comment from MauiBot May 11, 2026
PureWeen pushed a commit that referenced this pull request Jun 2, 2026
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

Set IsRefreshingProperty with SetterSpecificity.FromHandler,
to avoid break Binding.


### Issues Fixed

<!-- Please make sure that there is a bug logged for the issue being
fixed. The bug should describe the problem and how to reproduce it. -->

Fixes #28514

<!--
Are you targeting main? All PRs should target the main branch unless
otherwise noted.
-->

---------
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
@github-actions github-actions Bot modified the milestones: .NET 10 SR7, .NET 10 SR9 Jul 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-listview ListView and TableView community ✨ Community Contribution s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bind ListView.IsRefreshing is not work.

6 participants