[Main] Merge release/8.0 into main #4689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependencies from https://github.com/dotnet/aspnetcore build 20231012.4 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23510.7 -> To Version 8.0.0-rtm.23512.4 Dependency coherency updates Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.Net.Http.Json,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Runtime.Caching From Version 8.0.0-rtm.23478.17 -> To Version 8.0.0-rtm.23511.16 (parent: Microsoft.AspNetCore.App.Runtime.win-x64 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231012.20 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23510.7 -> To Version 8.0.0-rtm.23512.20 Dependency coherency updates Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.Net.Http.Json,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Runtime.Caching From Version 8.0.0-rtm.23478.17 -> To Version 8.0.0-rtm.23511.16 (parent: Microsoft.AspNetCore.App.Runtime.win-x64 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231013.13 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23510.7 -> To Version 8.0.0-rtm.23513.13 Dependency coherency updates Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.Net.Http.Json,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Runtime.Caching From Version 8.0.0-rtm.23478.17 -> To Version 8.0.0-rtm.23511.16 (parent: Microsoft.AspNetCore.App.Runtime.win-x64 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231014.1 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23510.7 -> To Version 8.0.0-rtm.23514.1 Dependency coherency updates Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.Net.Http.Json,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Runtime.Caching From Version 8.0.0-rtm.23478.17 -> To Version 8.0.0-rtm.23511.16 (parent: Microsoft.AspNetCore.App.Runtime.win-x64 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231016.6 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23510.7 -> To Version 8.0.0-rtm.23516.6 Dependency coherency updates Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.Net.Http.Json,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Runtime.Caching From Version 8.0.0-rtm.23478.17 -> To Version 8.0.0-rtm.23513.17 (parent: Microsoft.AspNetCore.App.Runtime.win-x64 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Resolves #4570 * Add a little tool that collects the diagnostic IDs * Update docs/list-of-diagnostics.md with the missing IDs * Restructure how diagnostic IDs are defined and referenced
* Fix LegacyLoggingFixer when eventId is missing in Log * Update test/Analyzers/Microsoft.Analyzers.Extra.Tests/CallAnalysis/LegacyLoggingTests.cs --------- Co-authored-by: Jan Guttek <[email protected]> Co-authored-by: Nikita Balabaev <[email protected]>
Co-authored-by: Jan Guttek <[email protected]>
#4580) * Commit a0d6364e: Merged PR 801011: Increased the max supported dimensions via source-gen to 30 dimensions * Update test/Generators/Microsoft.Gen.Metrics/Unit/ParserTests.StrongTypes.cs * Revert * Check correct property --------- Co-authored-by: Jan Guttek <[email protected]> Co-authored-by: Nikita Balabaev <[email protected]>
- Add the HMAC redactor. - Add support for salting redacted values. The salt is derived from the name of the item being redacted, and can optionally include the current day of the year (which induces daily rotation). - Delete the xxHash3 redactor. Co-authored-by: Martin Taillefer <[email protected]>
* OTel semantic conventions for log exceptions * Fix compilation after merge Fix a test
* Update dependencies from https://github.com/dotnet/aspnetcore build 20231017.6 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23516.6 -> To Version 8.0.0-rtm.23517.6 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231018.6 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23516.6 -> To Version 8.0.0-rtm.23518.6 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Hosting.Testing readme * Experimental * Revert Experimental * Cleanup description
* AspNetCore.Testing readme, namespaces * Update src/Libraries/Microsoft.AspNetCore.Testing/README.md * Update baselines * Delete activate.ps1 --------- Co-authored-by: Dan Moseley <[email protected]>
* Update dependencies from https://github.com/dotnet/aspnetcore build 20231019.14 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23518.6 -> To Version 8.0.0-rtm.23519.14 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231020.10 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23518.6 -> To Version 8.0.0-rtm.23520.10 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231020.10 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23518.6 -> To Version 8.0.0-rtm.23520.10 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Martin Taillefer (from Dev Box) <[email protected]>
Co-authored-by: Martin Taillefer (from Dev Box) <[email protected]>
* Aligning metrics with OTel semantic convention
* Fill in the readme * -ruleset
- Use OTel semantic conventions for the names of logging dimensions where possible. Since semantic conventions for logs are Experimental, and are missed for the most of areas/objects we need to agree on the dimensions names, we decided to use semantic conventions for traces. Semantic conventions for traces are also Experimental, but they are defined for a wide variety of areas/objects. - If a semantic convention for a dimensions or a log message parameter is missing, then we use PascalCase for the name of the dimension. - Use dot "." instead of underscore "_" as a separator for the names of dimension of LogPropertiesAttribute and TagProviderAttribute. - Remove "env_" preffix from the names of enrichment dimensions.
…016.4 (#4603) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23505.1 -> To Version 8.0.0-beta.23516.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Drop FailureResultContext
* Adding ExceptionSummarization readme * Update src/Libraries/Microsoft.Extensions.Diagnostics.ExceptionSummarization/README.md Co-authored-by: Dan Moseley <[email protected]> * Correction --------- Co-authored-by: Dan Moseley <[email protected]>
Co-authored-by: Martin Taillefer (from Dev Box) <[email protected]>
* Update dependencies from https://github.com/dotnet/aspnetcore build 20231023.8 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23520.10 -> To Version 8.0.0-rtm.23523.8 * Update dependencies from https://github.com/dotnet/aspnetcore build 20231024.15 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rtm.23520.10 -> To Version 8.0.0-rtm.23524.15 Dependency coherency updates Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Diagnostics,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.Net.Http.Json,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Runtime.Caching From Version 8.0.0-rtm.23513.17 -> To Version 8.0.0 (parent: Microsoft.AspNetCore.App.Runtime.win-x64 * Update NuGet.config --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Igor Velikorossov <[email protected]>
* Add readme for Microsoft.Extensions.Compliance.Abstractions * Feedback
* Revamp data classification model. - Introduce the DataClassificationSet type that represents a set of combined classifications. This replaces the previous ability to OR together multiple classifications, which was too constraining. * Simplify classification model * Address PR feedback --------- Co-authored-by: Martin Taillefer (from Dev Box) <[email protected]>
…s.Telemetry (#4618) * Rename Microsoft.Extensions.Diagnostics.Extra* -> Microsoft.Extensions.Telemetry * M.E.TelemetryAbstractions -> M.E.Telemetry.Abstractions
* Add readme for Ambient Metadata * Update src/Libraries/Microsoft.Extensions.AmbientMetadata.Application/README.md
* Expand Contenxtual Options readme * Cleanup
* Fix inconsistent signature of `GetOptions` method * PR comments
* Added a test to showcase the bug * added another test case to be fixed
* Http resilience readme * Update HttpStandardHedgingResilienceOptions.cs * Apply suggestions from code review Co-authored-by: martintmk <[email protected]> * Custom pipeline * Fixup * Better pipeline --------- Co-authored-by: martintmk <[email protected]>
* Adding Microsoft.Extensions.Telemetry README * Add annotation about Hmac Redactor * Apply suggestions from code review Co-authored-by: Chris Ross <[email protected]> Co-authored-by: Sébastien Ros <[email protected]> * PR Feedback and add full exporters example --------- Co-authored-by: Chris Ross <[email protected]> Co-authored-by: Sébastien Ros <[email protected]>
* Adding Microsoft.Extensions.Telemetry.Abstractions README * Apply suggestions from code review Co-authored-by: Sébastien Ros <[email protected]> --------- Co-authored-by: Sébastien Ros <[email protected]>
* Resources Health Check ReadMe * Update src/Libraries/Microsoft.Extensions.Diagnostics.HealthChecks.ResourceUtilization/README.md Co-authored-by: Sébastien Ros <[email protected]> --------- Co-authored-by: Sébastien Ros <[email protected]>
* Probes readme * Update src/Libraries/Microsoft.Extensions.Diagnostics.Probes/README.md Co-authored-by: Sébastien Ros <[email protected]> --------- Co-authored-by: Sébastien Ros <[email protected]>
* Add auto-activation README * Typos * Activate
* Fix standard hedging for primary callbacks * Fix test
* add summary information * Add usage details * Include AddHealthcChecks() in telemetry publisher example * Add link to built in metrics doc
Member
Author
|
I need a temp branch to resolve conflicts in. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggering this manually since it was blocked for a while.
Microsoft Reviewers: Open in CodeFlow