Skip to content

Conversation

@RussKie
Copy link
Contributor

@RussKie RussKie commented Nov 3, 2023

Resolves #4643
Resolves #4649

If the property isn't specified, the build will fail:
image

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question but that is unrelated to your changes. This LGTM thanks for fixing @RussKie!

Did you get a chance to validate the consumption side and ensure that an app using this package APIs gets the right diagnostic IDs?

@RussKie
Copy link
Contributor Author

RussKie commented Nov 3, 2023

Did you get a chance to validate the consumption side and ensure that an app using this package APIs gets the right diagnostic IDs?

If you remove any of the new suppressions, you'll see the build failing. For example:

D:\Development\dotnet-extensions\test\Libraries\Microsoft.Extensions.Options.ContextualOptions.Tests\ContextualOptionsFactoryTests.cs(52,25): error EXTEXP0017: 'Microsoft.Extensions.Options.Contextual.ValidateContextualOptions<System.Collections.Generic.List<string>>' is for evaluation purposes o 
nly and is subject to change or removal in future updates. Suppress this diagnostic to proceed. (https://aka.ms/dotnet-extensions-warnings/EXTEXP0017) [D:\Development\dotnet-extensions\test\Libraries\Microsoft.Extensions.Options.ContextualOptions.Tests\Microsoft.Extensions.Options.Contextual.Test 
s.csproj::TargetFramework=net6.0]

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Telemetry 92 93
Microsoft.AspNetCore.Diagnostics.Middleware 99 100

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=459079&view=codecoverage-tab

@joperezr joperezr merged commit 0bcda4d into release/8.0 Nov 3, 2023
@joperezr joperezr deleted the dev_packages branch November 3, 2023 17:50
This was linked to issues Nov 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@RussKie RussKie added this to the 8.1 milestone Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify experimental package warning Experimental ID is TBD

5 participants