-
Notifications
You must be signed in to change notification settings - Fork 841
Mark experimental packages #4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Generators/Microsoft.Gen.MetricsReports/Directory.Build.props
Outdated
Show resolved
Hide resolved
joperezr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question but that is unrelated to your changes. This LGTM thanks for fixing @RussKie!
Did you get a chance to validate the consumption side and ensure that an app using this package APIs gets the right diagnostic IDs?
If you remove any of the new suppressions, you'll see the build failing. For example: |
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=459079&view=codecoverage-tab |
Resolves #4643
Resolves #4649
If the property isn't specified, the build will fail:

Microsoft Reviewers: Open in CodeFlow